|Bill Allombert on Fri, 13 Feb 2009 13:38:24 +0100|
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
|Re: PATCH: gcmp1 and gcmp_1 for t_SERs|
On Tue, Feb 10, 2009 at 12:09:22PM +0100, Jeroen Demeyer wrote: > Hello pari-dev, > > It seems that gcmp1() and gcmp_1() were not implemented for t_SER (they > always returned 0). This patch should fix that. > > CHANGES: > - Implemented gcmp1() and gcmp_1() for t_SERs. Well, this change the semantic of gcmp1() and gcmp_1(), but I think it is in an expected way, the current behaviour being rather unexpecected. However I am not entirely sure the implementation is correct: We should have the equivalence gcmp1(x) == gequal(x,gen_1) and this is far from obvious from the code, though that might be an issue with gequal rather than with your code. Thanks for your patch, Bill.