Bill Allombert on Thu, 17 Dec 2009 22:26:43 +0100 |
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
Re: A patch for native PARI/GP build on Windows (Mingw+Msys) |
On Thu, Dec 17, 2009 at 06:07:10PM +0200, Vasili Burdo wrote: > It includes: > - Configuration changes to recognize Mingw build. > - Native hires plotting for Windows. > - Native support of Windows console including terminal size and colors. > - All tests are passed for gp-syn. For gp-sta, tests involving install() > fail. > > This patch is based on current PARI SVN. > Comments and suggestions are VERY welcome. This looks fine except for this: > Index: src/test/dotest > =================================================================== > --- src/test/dotest (revision 12034) > +++ src/test/dotest (working copy) > @@ -74,7 +74,7 @@ > gp=$execdir/gp-$suf;; > esac > (cat $file_in; echo 'print("Total time spent: ",gettime);') | $gp -q --test > $file_test 2>&1 > - diff -c $file_out $file_test > $file_diff > + diff -cwb $file_out $file_test > $file_diff > pat=`grep "^[-+!] " $file_diff | grep -v "Total time"` > time=`${tail}1 $file_test | sed -n 's,.*Total time spent: \(.*\),\1,p'` > if test -n "$time"; then I suppose -wb is required to deal with CR/LF vs LF issue ? Please change it so that -wb is only added for windows build. Without that, we will miss some white-space changes in the output even when running the tests on Linux. Cheers, Bill.