Bill Allombert on Tue, 10 Feb 2015 18:18:12 +0100

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: FlxqM_mul_Kronecker

On Mon, Feb 09, 2015 at 11:58:20PM +0100, Peter Bruin wrote:
> Hello Bill,
> > On Sat, Feb 07, 2015 at 01:22:47PM +0100, Peter Bruin wrote:
> >> Bonjour,
> >> 
> >> Here is a patch to add a new (private) function FlxqM_mul_Kronecker that
> >> I have been working on since the Atelier PARI/GP in January.  It uses
> >> Kronecker substitution to multiply matrices over non-prime finite fields
> >> of small characteristics.  Over the range of matrices I tested it on, it
> >> is on average 60%-80% faster than the existing FlxqM_mul; for some
> >> examples, the speedup is up to 4-5 times.
> >
> > I read your patch.
> Thanks!  More changes are in the attached patch.  (I guess it is not
> possible for me to directly update the peter-FlxqM_mul_Kronecker
> branch?)

Thanks! I have commited your change to master.

> > I think the function FlxM_to_ZM and ZM_to_FlxqM should be renamed
> > to something more awkward, maybe FlxM_pack_ZM/ZM_pack_FlxqM
> They are now called kron_pack_FlxM and kron_unpack_FlxM; how about that?

Well, I changed it to FlxM_pack_ZM and ZM_unpack_FlxqM 
because the convetion is to start the function name with the input type.

Also I have changed RgM_sqr to call FFM_mul.