|
Bill Allombert on Wed, 02 Aug 2023 18:20:21 +0200
|
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
|
Re: [PATCH 1/1] config/{Makefile.SH,get_fltk}: include fltk's CXXFLAGS
|
- To: pari-dev@pari.math.u-bordeaux.fr
- Subject: Re: [PATCH 1/1] config/{Makefile.SH,get_fltk}: include fltk's CXXFLAGS
- From: Bill Allombert <Bill.Allombert@math.u-bordeaux.fr>
- Date: Wed, 2 Aug 2023 18:15:37 +0200
- Arc-authentication-results: i=1; smail; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; d=math.u-bordeaux.fr; s=openarc; t=1690992930; c=relaxed/relaxed; bh=AVPsE3ov0i/VZu3A6byTy6sJVJ0ZBXd0EGtjwibYGYM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: Content-Transfer-Encoding:In-Reply-To; b=gbuj47TLYCul/3VMFmLzCeEzDc6eQvHF9KTwI9xLSWLlm8ieSsyuLRVDWhdxxqBXvNQbLKmobBIusGI8UwAed9lKD2o5qxjKqy1ouODbRNvvYtn0kAD5KtwXnH/qq4DqQo/3JO5l34BOqoqNUjmY0LPtWYsDNFFhPuknFhYKqmzK+c0sQsqLmok50vbnHMe1dg4LLjMR4thPTlhZa1P2oNOFqA+cW6H0ydWYbuHESKNUQmvUV5d/KjyCUZnjMbJxcynB0GKfbjQhNlHWxfQ54z1Kv7RF62U3QPFNHv508PDVKZ5vOkiAqco0wvJTa9p266zgv3Xh6ey/DLE42tx86P7p877TcDzYSHHcGVpPyfE+T/umaWhU5c63NysYKSUsMEP3SGHyIDSVRsiIZpeF6GuFpwesU0gBoaL+k68FhGTaH5TRsWQ/BEdalGgPGU/JhL9aLNImod3rDYQZateyqqvXmvodRY5j858bGxg10k4dENUb7ZSnMoPjqZmcVos7WOk72DA3KwtkH23TQKXNXOe+MjD9tqjcZmqV/vt4wSR59eXxzKKEER1054PAvAiftxVp2OvDbpmwyve3JTQpu9IWepMj6t/MSD+9pTm2pGqEKzfFaeZhCkSaglHB5BVo2db4vXPuufd0rT3c0/DWaGKU+dmf43GRFLKutcgOtgo=
- Arc-seal: i=1; a=rsa-sha256; d=math.u-bordeaux.fr; s=openarc; t=1690992930; cv=none; b=RU87HD+p8H3SB3kYICPgVs8ZGbvjgtXAGS/gI7qGzdUJhW8GNvQCNUSpRxgFyRLQfwtiHh6tH5wdqTkNN7GMxascFfDqCmw2K7Hm6hg9lxLoBCdE4tMOvF6ylDFx+2mZ7QhwYFjoyJZTsgKTqz5gUD++LYZ4OyjHGckJvCHA2PZQfHwEgeE/MHjwQQYRde9B+k32h7TzuL7Y/cdsvdU26tqH1N/ge2nGgUvMz/3X9WRiC6IQ5ggIcgevLJrJu6QrygyB/bgKd0l9fLM+9c+XUECf1hEJZ0rjW7o6KyD4Qs8yBls0l89eaw5xqfA3yYzgCDek5GZxhy4Z4KgDxV0Ek5fVIORNFQfJjhR6w5r4BEitSarUlfq7mc/RYfYjhaSxb+ugdMTgwvIwpHtp2YuY4lB5NnIAJaUiYWiOlMF7/oIN8ZraGk4dhvbHRTfyfgl328DvliJJSxttdzYZKZ+wfn/vkMPpaASSq8x7icKYTrNW3U12p+BO7yj1h6dIg4MqQBbtdqtvIGEGG/4l3ydClNFZTkRZyUVMtnOnR5tSuM9nrcPOZJKrZq9RdP58UsoveLOU89zlpVFbTsXYivtKUCn39Tv8PrEkXlphmdKr+BNbl7BzMdYJMr7zPcIvkbdBDHKR1NYaD5TZEQK0DIDuqojxtamRozyFOCgYjvjyBVg=
- Authentication-results: smail; arc=none
- Delivery-date: Wed, 02 Aug 2023 18:20:21 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=math.u-bordeaux.fr; s=2022; t=1690992930; bh=AVPsE3ov0i/VZu3A6byTy6sJVJ0ZBXd0EGtjwibYGYM=; h=Date:From:To:Subject:References:In-Reply-To:From; b=lsjzQPt6Un62Lrp1oyl2tHKM6UR6wPZw5XhvK1g2C1hlCKGr3M1upKQStbHCvaJlq J7p5nsYb5OAZejtTRdLaho/eEMm5EGSjsp4HYAjUZz4KfrbN/BkAheo/DurGK7DXJb W9zvC2UZfwoTofoqHVRVyjF8XMg+ZOmTuPzQyYEo/2vfROLJwA/vz2GbfeHbEQTda6 V1gf+PKOgN2iFHXg/PT2TxE6VC07WTsd7lbxv81bNrKkN2/HQ4w6/0QAuc/CRO76mr 0ICQVfBsl25NJ2DwBYy+OVaPlJiiZGicA+a/bduUTHYu1TRwweWeu43IS/L27BEt8g kWUMayt3zdjwi4/R+9SUt4kNK0V8tpB0+6MmOm8qxKtEcKNNvK/NMEtNG8IocUEyu/ fxDghhSPPjMv2psj59LzgJvsMbWmuevT0oyaG5Sn4dcXDQ7vHn7e1xGnd10slrBCNs yJS2stao4B+kURyarQFrEKgu79Q0PB2WWtc0ISSJCXHJqpIK/3Pm/G1RuixKZ8NfAa ARrbfBGepSicT5drBXFRY1V3MruccqaN14WlS1ZC7J18bVuau6DaBPsqocPi40FkkT NqGeGrf71WLJSedRSGkXNvPAYvKgfHZDIrAgXNhn9D5+fxOPrtQTgG9jttahF2MzEb Xs1P0DLt5GJL1z4hMz3JOO+g=
- In-reply-to: <ZMqA0CyPl+HldDEA@seventeen>
- Mail-followup-to: pari-dev@pari.math.u-bordeaux.fr
- References: <20230801193531.27415-1-michael@orlitzky.com> <20230801193531.27415-2-michael@orlitzky.com> <ZMqA0CyPl+HldDEA@seventeen>
On Tue, Aug 01, 2023 at 03:35:31PM -0400, Michael Orlitzky wrote:
> To test for fltk, pari compiles a test program using the output from
> "fltk-config --ldflags". That provides the necessary -l and -L flags,
> but if fltk's headers are in a nonstandard location, then the
> corresponding -I flags will be absent. This can cause a compilation
> failure (and thus feature misdetection) on e.g. Gentoo, where fltk's
> headers are stored in /usr/include/fltk rather than /usr/include.
> To fix the problem, this commit includes the output from "fltk-config
> --cxxflags" in the compilation command.
>
> The same issue arises when compiling pari (plotfltk.c) itself, and the
> same fix applied to PLOTCFLAGS in Makefile.SH solves it.
>
> This issue was originally debugged and fixed by François Bissey.
Thanks for your patch.
I think you also need this hunk:
diff --git a/config/get_graphic_lib b/config/get_graphic_lib
index 5e72fbf989..b685c13c58 100644
--- a/config/get_graphic_lib
+++ b/config/get_graphic_lib
@@ -3,7 +3,7 @@ if test "$optimization" = profiling; then
fi
_graphic_list="which_graphic_lib X11 X11_INC X11_LIBS \
-FLTK_LIBS QTDIR QTLIB gp_mime_open"
+FLTK_CXXFLAGS FLTK_LIBS QTDIR QTLIB gp_mime_open"
if test -n "$with_fltk"; then which_graphic_lib=fltk; fi
if test -n "$with_qt"; then which_graphic_lib=Qt; fi
I have commited the combination as GIT commit
9d84c29705119000fef53d50cbc681c00473a4b1
I hope this fixes your issues.
Cheers,
Bill