Code coverage tests

This page documents the degree to which the PARI/GP source code is tested by our public test suite, distributed with the source distribution in directory src/test/. This is measured by the gcov utility; we then process gcov output using the lcov frond-end.

We test a few variants depending on Configure flags on the pari.math.u-bordeaux.fr machine (x86_64 architecture), and agregate them in the final report:

The target is to exceed 90% coverage for all mathematical modules (given that branches depending on DEBUGLEVEL or DEBUGMEM are not covered). This script is run to produce the results below.

LCOV - code coverage report
Current view: top level - basemath - buch2.c (source / functions) Hit Total Coverage
Test: PARI/GP v2.18.1 lcov report (development 30074-db9b3c0519) Lines: 2175 2397 90.7 %
Date: 2025-03-13 08:38:27 Functions: 155 166 93.4 %
Legend: Lines: hit not hit

          Line data    Source code
       1             : /* Copyright (C) 2000  The PARI group.
       2             : 
       3             : This file is part of the PARI/GP package.
       4             : 
       5             : PARI/GP is free software; you can redistribute it and/or modify it under the
       6             : terms of the GNU General Public License as published by the Free Software
       7             : Foundation; either version 2 of the License, or (at your option) any later
       8             : version. It is distributed in the hope that it will be useful, but WITHOUT
       9             : ANY WARRANTY WHATSOEVER.
      10             : 
      11             : Check the License for details. You should have received a copy of it, along
      12             : with the package; see the file 'COPYING'. If not, write to the Free Software
      13             : Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */
      14             : #include "pari.h"
      15             : #include "paripriv.h"
      16             : 
      17             : #define DEBUGLEVEL DEBUGLEVEL_bnf
      18             : 
      19             : /*******************************************************************/
      20             : /*                                                                 */
      21             : /*         CLASS GROUP AND REGULATOR (McCURLEY, BUCHMANN)          */
      22             : /*                    GENERAL NUMBER FIELDS                        */
      23             : /*                                                                 */
      24             : /*******************************************************************/
      25             : /* get_random_ideal */
      26             : static const long RANDOM_BITS = 4;
      27             : /* Buchall */
      28             : static const long RELSUP = 5;
      29             : static const long FAIL_DIVISOR = 32;
      30             : static const long MINFAIL = 10;
      31             : /* small_norm */
      32             : static const long BNF_RELPID = 4;
      33             : static const long maxtry_FACT = 500;
      34             : /* rnd_rel */
      35             : static const long RND_REL_RELPID = 1;
      36             : /* random relations */
      37             : static const long MINSFB = 3;
      38             : static const long SFB_MAX = 3;
      39             : static const long DEPSIZESFBMULT = 16;
      40             : static const long DEPSFBDIV = 10;
      41             : /* add_rel_i */
      42             : static const ulong mod_p = 27449UL;
      43             : /* be_honest */
      44             : static const long maxtry_HONEST = 50;
      45             : 
      46             : typedef struct FACT {
      47             :     long pr, ex;
      48             : } FACT;
      49             : 
      50             : typedef struct subFB_t {
      51             :   GEN subFB;
      52             :   struct subFB_t *old;
      53             : } subFB_t;
      54             : 
      55             : /* a factor base contains only noninert primes
      56             :  * KC = # of P in factor base (p <= n, NP <= n2)
      57             :  * KC2= # of P assumed to generate class group (NP <= n2)
      58             :  *
      59             :  * KCZ = # of rational primes under ideals counted by KC
      60             :  * KCZ2= same for KC2 */
      61             : 
      62             : typedef struct FB_t {
      63             :   GEN FB; /* FB[i] = i-th rational prime used in factor base */
      64             :   GEN LP; /* vector of all prime ideals in FB, by increasing norm */
      65             :   GEN LV; /* LV[p] = vector of P|p, NP <= n2
      66             :             * isclone() is set for LV[p] iff all P|p are in FB
      67             :             * LV[i], i not prime or i > n2, is undefined! */
      68             :   GEN iLP; /* iLP[p] = i such that LV[p] = [LP[i],...] */
      69             :   GEN L_jid; /* indexes of "useful" prime ideals for rnd_rel */
      70             :   long KC, KCZ, KCZ2;
      71             :   GEN prodZ; /* product of the primes in KCZ*/
      72             :   GEN subFB; /* LP o subFB =  part of FB used to build random relations */
      73             :   int sfb_chg; /* need to change subFB ? */
      74             :   GEN perm; /* permutation of LP used to represent relations [updated by
      75             :                hnfspec/hnfadd: dense rows come first] */
      76             :   GEN idealperm; /* permutation of ideals under field automorphisms */
      77             :   GEN minidx; /* minidx[i] min ideal in orbit of LP[i] under field autom */
      78             :   subFB_t *allsubFB; /* all subFB's used */
      79             :   GEN embperm; /* permutations of the complex embeddings */
      80             :   long MAXDEPSIZESFB; /* # trials before increasing subFB */
      81             :   long MAXDEPSFB; /* MAXDEPSIZESFB / DEPSFBDIV, # trials befor rotating subFB */
      82             :   double ballvol;
      83             : } FB_t;
      84             : 
      85             : enum { sfb_CHANGE = 1, sfb_INCREASE = 2 };
      86             : 
      87             : typedef struct REL_t {
      88             :   GEN R; /* relation vector as t_VECSMALL; clone */
      89             :   long nz; /* index of first nonzero elt in R (hash) */
      90             :   GEN m; /* pseudo-minimum yielding the relation; clone */
      91             :   long relorig; /* relation this one is an image of */
      92             :   long relaut; /* automorphim used to compute this relation from the original */
      93             :   GEN emb; /* archimedean embeddings */
      94             :   GEN junk[2]; /*make sure sizeof(struct) is a power of two.*/
      95             : } REL_t;
      96             : 
      97             : typedef struct RELCACHE_t {
      98             :   REL_t *chk; /* last checkpoint */
      99             :   REL_t *base; /* first rel found */
     100             :   REL_t *last; /* last rel found so far */
     101             :   REL_t *end; /* target for last relation. base <= last <= end */
     102             :   size_t len; /* number of rels pre-allocated in base */
     103             :   long relsup; /* how many linearly dependent relations we allow */
     104             :   GEN basis; /* mod p basis (generating family actually) */
     105             :   ulong missing; /* missing vectors in generating family above */
     106             : } RELCACHE_t;
     107             : 
     108             : typedef struct FP_t {
     109             :   double **q, *v, *y, *z;
     110             :   GEN x;
     111             : } FP_t;
     112             : 
     113             : static void
     114           0 : wr_rel(GEN e)
     115             : {
     116           0 :   long i, l = lg(e);
     117           0 :   for (i = 1; i < l; i++)
     118           0 :     if (e[i]) err_printf("%ld^%ld ",i,e[i]);
     119           0 : }
     120             : static void
     121           0 : dbg_newrel(RELCACHE_t *cache)
     122             : {
     123           0 :   if (DEBUGLEVEL > 1)
     124             :   {
     125           0 :     err_printf("\n++++ cglob = %ld\nrel = ", cache->last - cache->base);
     126           0 :     wr_rel(cache->last->R);
     127           0 :     err_printf("\n");
     128             :   }
     129             :   else
     130           0 :     err_printf("%ld ", cache->last - cache->base);
     131           0 : }
     132             : 
     133             : static void
     134       54767 : delete_cache(RELCACHE_t *M)
     135             : {
     136             :   REL_t *rel;
     137      898435 :   for (rel = M->base+1; rel <= M->last; rel++)
     138             :   {
     139      843668 :     gunclone(rel->R);
     140      843668 :     if (rel->m) gunclone(rel->m);
     141             :   }
     142       54767 :   pari_free((void*)M->base); M->base = NULL;
     143       54767 : }
     144             : 
     145             : static void
     146       56633 : delete_FB(FB_t *F)
     147             : {
     148             :   subFB_t *s, *sold;
     149      113904 :   for (s = F->allsubFB; s; s = sold) { sold = s->old; pari_free(s); }
     150       56633 :   gunclone(F->minidx);
     151       56633 :   gunclone(F->idealperm);
     152       56633 : }
     153             : 
     154             : static void
     155       54767 : reallocate(RELCACHE_t *M, long len)
     156             : {
     157       54767 :   M->len = len;
     158       54767 :   if (!M->base)
     159       54767 :     M->base = (REL_t*)pari_malloc((len+1) * sizeof(REL_t));
     160             :   else
     161             :   {
     162           0 :     size_t l = M->last - M->base, c = M->chk - M->base, e = M->end - M->base;
     163           0 :     pari_realloc_ip((void**)&M->base, (len+1) * sizeof(REL_t));
     164           0 :     M->last = M->base + l;
     165           0 :     M->chk  = M->base + c;
     166           0 :     M->end  = M->base + e;
     167             :   }
     168       54767 : }
     169             : 
     170             : #define pr_get_smallp(pr) gel(pr,1)[2]
     171             : 
     172             : /* don't take P|p all other Q|p are already there */
     173             : static int
     174      262777 : bad_subFB(FB_t *F, long t)
     175             : {
     176      262777 :   GEN LP, P = gel(F->LP,t);
     177      262777 :   long p = pr_get_smallp(P);
     178      262777 :   LP = gel(F->LV,p);
     179      262777 :   return (isclone(LP) && t == F->iLP[p] + lg(LP)-1);
     180             : }
     181             : 
     182             : static void
     183       57271 : assign_subFB(FB_t *F, GEN yes, long iyes)
     184             : {
     185       57271 :   long i, lv = sizeof(subFB_t) + iyes*sizeof(long); /* for struct + GEN */
     186       57271 :   subFB_t *s = (subFB_t *)pari_malloc(lv);
     187       57271 :   s->subFB = (GEN)&s[1];
     188       57271 :   s->old = F->allsubFB; F->allsubFB = s;
     189      246704 :   for (i = 0; i < iyes; i++) s->subFB[i] = yes[i];
     190       57271 :   F->subFB = s->subFB;
     191       57271 :   F->MAXDEPSIZESFB = (iyes-1) * DEPSIZESFBMULT;
     192       57271 :   F->MAXDEPSFB = F->MAXDEPSIZESFB / DEPSFBDIV;
     193       57271 : }
     194             : 
     195             : /* Determine the permutation of the ideals made by each field automorphism */
     196             : static GEN
     197       56633 : FB_aut_perm(FB_t *F, GEN auts, GEN cyclic)
     198             : {
     199       56633 :   long i, j, m, KC = F->KC, nauts = lg(auts)-1;
     200       56633 :   GEN minidx, perm = zero_Flm_copy(KC, nauts);
     201             : 
     202       56633 :   if (!nauts) { F->minidx = gclone(identity_zv(KC)); return cgetg(1,t_MAT); }
     203       35819 :   minidx = zero_Flv(KC);
     204       77998 :   for (m = 1; m < lg(cyclic); m++)
     205             :   {
     206       42179 :     GEN thiscyc = gel(cyclic, m);
     207       42179 :     long k0 = thiscyc[1];
     208       42179 :     GEN aut = gel(auts, k0), permk0 = gel(perm, k0), ppermk;
     209       42179 :     i = 1;
     210      181375 :     while (i <= KC)
     211             :     {
     212      139196 :       pari_sp av2 = avma;
     213      139196 :       GEN seen = zero_Flv(KC), P = gel(F->LP, i);
     214      139196 :       long imin = i, p, f, l;
     215      139196 :       p = pr_get_smallp(P);
     216      139196 :       f = pr_get_f(P);
     217             :       do
     218             :       {
     219      409470 :         if (++i > KC) break;
     220      367291 :         P = gel(F->LP, i);
     221             :       }
     222      367291 :       while (p == pr_get_smallp(P) && f == pr_get_f(P));
     223      548666 :       for (j = imin; j < i; j++)
     224             :       {
     225      409470 :         GEN img = ZM_ZC_mul(aut, pr_get_gen(gel(F->LP, j)));
     226     1425709 :         for (l = imin; l < i; l++)
     227     1425709 :           if (!seen[l] && ZC_prdvd(img, gel(F->LP, l)))
     228             :           {
     229      409470 :             seen[l] = 1; permk0[j] = l; break;
     230             :           }
     231             :       }
     232      139196 :       set_avma(av2);
     233             :     }
     234       58627 :     for (ppermk = permk0, i = 2; i < lg(thiscyc); i++)
     235             :     {
     236       16448 :       GEN permk = gel(perm, thiscyc[i]);
     237      329332 :       for (j = 1; j <= KC; j++) permk[j] = permk0[ppermk[j]];
     238       16448 :       ppermk = permk;
     239             :     }
     240             :   }
     241      264953 :   for (j = 1; j <= KC; j++)
     242             :   {
     243      229134 :     if (minidx[j]) continue;
     244      110248 :     minidx[j] = j;
     245      307580 :     for (i = 1; i <= nauts; i++) minidx[coeff(perm, j, i)] = j;
     246             :   }
     247       35819 :   F->minidx = gclone(minidx); return perm;
     248             : }
     249             : 
     250             : /* set subFB.
     251             :  * Fill F->perm (if != NULL): primes ideals sorted by increasing norm (except
     252             :  * the ones in subFB come first [dense rows for hnfspec]) */
     253             : static void
     254       56633 : subFBgen(FB_t *F, GEN auts, GEN cyclic, double PROD, long minsFB)
     255             : {
     256             :   GEN y, perm, yes, no;
     257       56633 :   long i, j, k, iyes, ino, lv = F->KC + 1;
     258             :   double prod;
     259             :   pari_sp av;
     260             : 
     261       56633 :   F->LP   = cgetg(lv, t_VEC);
     262       56633 :   F->L_jid = F->perm = cgetg(lv, t_VECSMALL);
     263       56633 :   av = avma;
     264       56633 :   y = cgetg(lv,t_COL); /* Norm P */
     265      266971 :   for (k=0, i=1; i <= F->KCZ; i++)
     266             :   {
     267      210338 :     GEN LP = gel(F->LV,F->FB[i]);
     268      210338 :     long l = lg(LP);
     269      608264 :     for (j = 1; j < l; j++)
     270             :     {
     271      397926 :       GEN P = gel(LP,j);
     272      397926 :       k++;
     273      397926 :       gel(y,k) = pr_norm(P);
     274      397926 :       gel(F->LP,k) = P;
     275             :     }
     276             :   }
     277             :   /* perm sorts LP by increasing norm */
     278       56633 :   perm = indexsort(y);
     279       56633 :   no  = cgetg(lv, t_VECSMALL); ino  = 1;
     280       56633 :   yes = cgetg(lv, t_VECSMALL); iyes = 1;
     281       56633 :   prod = 1.0;
     282      259310 :   for (i = 1; i < lv; i++)
     283             :   {
     284      233594 :     long t = perm[i];
     285      233594 :     if (bad_subFB(F, t)) { no[ino++] = t; continue; }
     286             : 
     287      130653 :     yes[iyes++] = t;
     288      130653 :     prod *= (double)itos(gel(y,t));
     289      130653 :     if (iyes > minsFB && prod > PROD) break;
     290             :   }
     291       56633 :   setlg(yes, iyes);
     292      187286 :   for (j=1; j<iyes; j++)     F->perm[j] = yes[j];
     293      159574 :   for (i=1; i<ino; i++, j++) F->perm[j] =  no[i];
     294      220965 :   for (   ; j<lv; j++)       F->perm[j] =  perm[j];
     295       56633 :   F->allsubFB = NULL;
     296       56633 :   F->idealperm = gclone(FB_aut_perm(F, auts, cyclic));
     297       56633 :   if (iyes) assign_subFB(F, yes, iyes);
     298       56633 :   set_avma(av);
     299       56633 : }
     300             : static int
     301       22669 : subFB_change(FB_t *F)
     302             : {
     303       22669 :   long i, iyes, minsFB, lv = F->KC + 1, l = lg(F->subFB)-1;
     304       22669 :   pari_sp av = avma;
     305       22669 :   GEN yes, L_jid = F->L_jid, present = zero_zv(lv-1);
     306             : 
     307       22669 :   switch (F->sfb_chg)
     308             :   {
     309          12 :     case sfb_INCREASE: minsFB = l + 1; break;
     310       22657 :     default: minsFB = l; break;
     311             :   }
     312             : 
     313       22669 :   yes = cgetg(minsFB+1, t_VECSMALL); iyes = 1;
     314       22669 :   if (L_jid)
     315             :   {
     316       29110 :     for (i = 1; i < lg(L_jid); i++)
     317             :     {
     318       28994 :       long l = L_jid[i];
     319       28994 :       if (bad_subFB(F, l)) continue;
     320       27095 :       yes[iyes++] = l;
     321       27095 :       present[l] = 1;
     322       27095 :       if (iyes > minsFB) break;
     323             :     }
     324             :   }
     325           0 :   else i = 1;
     326       22669 :   if (iyes <= minsFB)
     327             :   {
     328         260 :     for ( ; i < lv; i++)
     329             :     {
     330         195 :       long l = F->perm[i];
     331         195 :       if (present[l] || bad_subFB(F, l)) continue;
     332          58 :       yes[iyes++] = l;
     333          58 :       if (iyes > minsFB) break;
     334             :     }
     335         116 :     if (i == lv) return 0;
     336             :   }
     337       22604 :   if (zv_equal(F->subFB, yes))
     338             :   {
     339       21966 :     if (DEBUGLEVEL) err_printf("\n*** NOT Changing sub factor base\n");
     340             :   }
     341             :   else
     342             :   {
     343         638 :     if (DEBUGLEVEL) err_printf("\n*** Changing sub factor base\n");
     344         638 :     assign_subFB(F, yes, iyes);
     345             :   }
     346       22604 :   F->sfb_chg = 0; return gc_bool(av, 1);
     347             : }
     348             : 
     349             : /* make sure enough room to store n more relations */
     350             : static void
     351      103934 : pre_allocate(RELCACHE_t *cache, size_t n)
     352             : {
     353      103934 :   size_t len = (cache->last - cache->base) + n;
     354      103934 :   if (len >= cache->len) reallocate(cache, len << 1);
     355      103934 : }
     356             : 
     357             : void
     358      114976 : init_GRHcheck(GRHcheck_t *S, long N, long R1, double LOGD)
     359             : {
     360      114976 :   const double c1 = M_PI*M_PI/2;
     361      114976 :   const double c2 = 3.663862376709;
     362      114976 :   const double c3 = 3.801387092431; /* Euler + log(8*Pi)*/
     363      114976 :   S->clone = 0;
     364      114976 :   S->cN = R1*c2 + N*c1;
     365      114976 :   S->cD = LOGD - N*c3 - R1*M_PI/2;
     366      114976 :   S->maxprimes = 16000; /* sufficient for LIMC=176081*/
     367      114976 :   S->primes = (GRHprime_t*)pari_malloc(S->maxprimes*sizeof(*S->primes));
     368      114976 :   S->nprimes = 0;
     369      114976 :   S->limp = 0;
     370      114976 :   u_forprime_init(&S->P, 2, ULONG_MAX);
     371      114976 : }
     372             : 
     373             : void
     374      114976 : free_GRHcheck(GRHcheck_t *S)
     375             : {
     376      114976 :   if (S->clone)
     377             :   {
     378       54702 :     long i = S->nprimes;
     379             :     GRHprime_t *pr;
     380     6471480 :     for (pr = S->primes, i = S->nprimes; i > 0; pr++, i--) gunclone(pr->dec);
     381             :   }
     382      114976 :   pari_free(S->primes);
     383      114976 : }
     384             : 
     385             : int
     386     1309946 : GRHok(GRHcheck_t *S, double L, double SA, double SB)
     387             : {
     388     1309946 :   return (S->cD + (S->cN + 2*SB) / L - 2*SA < -1e-8);
     389             : }
     390             : 
     391             : /* Return factorization pattern of p: [f,n], where n[i] primes of
     392             :  * residue degree f[i] */
     393             : static GEN
     394     6416778 : get_fs(GEN nf, GEN P, GEN index, ulong p)
     395             : {
     396             :   long j, k, f, n, l;
     397             :   GEN fs, ns;
     398             : 
     399     6416778 :   if (umodiu(index, p))
     400             :   { /* easy case: p does not divide index */
     401     6384127 :     GEN F = Flx_degfact(ZX_to_Flx(P,p), p);
     402     6384127 :     fs = gel(F,1); l = lg(fs);
     403             :   }
     404             :   else
     405             :   {
     406       32651 :     GEN F = idealprimedec(nf, utoipos(p));
     407       32651 :     l = lg(F);
     408       32651 :     fs = cgetg(l, t_VECSMALL);
     409      102296 :     for (j = 1; j < l; j++) fs[j] = pr_get_f(gel(F,j));
     410             :   }
     411     6416778 :   ns = cgetg(l, t_VECSMALL);
     412     6416778 :   f = fs[1]; n = 1;
     413    11870730 :   for (j = 2, k = 1; j < l; j++)
     414     5453952 :     if (fs[j] == f)
     415     3977172 :       n++;
     416             :     else
     417             :     {
     418     1476780 :       ns[k] = n; fs[k] = f; k++;
     419     1476780 :       f = fs[j]; n = 1;
     420             :     }
     421     6416778 :   ns[k] = n; fs[k] = f; k++;
     422     6416778 :   setlg(fs, k);
     423     6416778 :   setlg(ns, k); return mkvec2(fs,ns);
     424             : }
     425             : 
     426             : /* cache data for all rational primes up to the LIM */
     427             : static void
     428      787205 : cache_prime_dec(GRHcheck_t *S, ulong LIM, GEN nf)
     429             : {
     430      787205 :   pari_sp av = avma;
     431             :   GRHprime_t *pr;
     432             :   GEN index, P;
     433             :   double nb;
     434             : 
     435      787205 :   if (S->limp >= LIM) return;
     436      281718 :   S->clone = 1;
     437      281718 :   nb = primepi_upper_bound((double)LIM); /* #{p <= LIM} <= nb */
     438      281718 :   GRH_ensure(S, nb+1); /* room for one extra prime */
     439      281718 :   P = nf_get_pol(nf);
     440      281718 :   index = nf_get_index(nf);
     441      281718 :   for (pr = S->primes + S->nprimes;;)
     442     6135060 :   {
     443     6416778 :     ulong p = u_forprime_next(&(S->P));
     444     6416778 :     pr->p = p;
     445     6416778 :     pr->logp = log((double)p);
     446     6416778 :     pr->dec = gclone(get_fs(nf, P, index, p));
     447     6416778 :     S->nprimes++;
     448     6416778 :     pr++;
     449     6416778 :     set_avma(av);
     450             :     /* store up to nextprime(LIM) included */
     451     6416778 :     if (p >= LIM) { S->limp = p; break; }
     452             :   }
     453             : }
     454             : 
     455             : static double
     456     1930404 : tailresback(long R1, long R2, double rK, long C, double C2, double C3, double r1K, double r2K, double logC, double logC2, double logC3)
     457             : {
     458     1930404 :   const double  rQ = 1.83787706641;
     459     1930404 :   const double r1Q = 1.98505372441;
     460     1930404 :   const double r2Q = 1.07991541347;
     461     3860808 :   return fabs((R1+R2-1)*(12*logC3+4*logC2-9*logC-6)/(2*C*logC3)
     462     1930404 :          + (rK-rQ)*(6*logC2 + 5*logC + 2)/(C*logC3)
     463     1930404 :          - R2*(6*logC2+11*logC+6)/(C2*logC2)
     464     1930404 :          - 2*(r1K-r1Q)*(3*logC2 + 4*logC + 2)/(C2*logC3)
     465     1930404 :          + (R1+R2-1)*(12*logC3+40*logC2+45*logC+18)/(6*C3*logC3)
     466     1930404 :          + (r2K-r2Q)*(2*logC2 + 3*logC + 2)/(C3*logC3));
     467             : }
     468             : 
     469             : static double
     470      965202 : tailres(long R1, long R2, double al2K, double rKm, double rKM, double r1Km,
     471             :         double r1KM, double r2Km, double r2KM, double C, long i)
     472             : {
     473             :   /* C >= 3*2^i, lower bound for eint1(log(C)/2) */
     474             :   /* for(i=0,30,print(eint1(log(3*2^i)/2))) */
     475             :   static double tab[] = {
     476             :     0.50409264803,
     477             :     0.26205336997,
     478             :     0.14815491171,
     479             :     0.08770540561,
     480             :     0.05347651832,
     481             :     0.03328934284,
     482             :     0.02104510690,
     483             :     0.01346475900,
     484             :     0.00869778586,
     485             :     0.00566279855,
     486             :     0.00371111950,
     487             :     0.00244567837,
     488             :     0.00161948049,
     489             :     0.00107686891,
     490             :     0.00071868750,
     491             :     0.00048119961,
     492             :     0.00032312188,
     493             :     0.00021753772,
     494             :     0.00014679818,
     495             :     9.9272855581E-5,
     496             :     6.7263969995E-5,
     497             :     4.5656812967E-5,
     498             :     3.1041124593E-5,
     499             :     2.1136011590E-5,
     500             :     1.4411645381E-5,
     501             :     9.8393304088E-6,
     502             :     6.7257395409E-6,
     503             :     4.6025878272E-6,
     504             :     3.1529719271E-6,
     505             :     2.1620490021E-6,
     506             :     1.4839266071E-6
     507             :   };
     508      965202 :   const double logC = log(C), logC2 = logC*logC, logC3 = logC*logC2;
     509      965202 :   const double C2 = C*C, C3 = C*C2;
     510      965202 :   double E1 = i >30? 0: tab[i];
     511      965202 :   return al2K*((33*logC2+22*logC+8)/(8*logC3*sqrt(C))+15*E1/16)
     512      965202 :     + maxdd(tailresback(rKm,r1KM,r2Km, C,C2,C3,R1,R2,logC,logC2,logC3),
     513      965202 :             tailresback(rKM,r1Km,r2KM, C,C2,C3,R1,R2,logC,logC2,logC3))/2
     514      965202 :     + ((R1+R2-1)*4*C+R2)*(C2+6*logC)/(4*C2*C2*logC2);
     515             : }
     516             : 
     517             : static long
     518       54702 : primeneeded(long N, long R1, long R2, double LOGD)
     519             : {
     520       54702 :   const double lim = 0.25; /* should be log(2)/2 == 0.34657... */
     521       54702 :   const double al2K =  0.3526*LOGD - 0.8212*N + 4.5007;
     522       54702 :   const double  rKm = -1.0155*LOGD + 2.1042*N - 8.3419;
     523       54702 :   const double  rKM = -0.5   *LOGD + 1.2076*N + 1;
     524       54702 :   const double r1Km = -       LOGD + 1.4150*N;
     525       54702 :   const double r1KM = -       LOGD + 1.9851*N;
     526       54702 :   const double r2Km = -       LOGD + 0.9151*N;
     527       54702 :   const double r2KM = -       LOGD + 1.0800*N;
     528       54702 :   long Cmin = 3, Cmax = 3, i = 0;
     529      490716 :   while (tailres(R1, R2, al2K, rKm, rKM, r1Km, r1KM, r2Km, r2KM, Cmax, i) > lim)
     530             :   {
     531      436014 :     Cmin = Cmax;
     532      436014 :     Cmax *= 2;
     533      436014 :     i++;
     534             :   }
     535       54702 :   i--;
     536      529188 :   while (Cmax - Cmin > 1)
     537             :   {
     538      474486 :     long t = (Cmin + Cmax)/2;
     539      474486 :     if (tailres(R1, R2, al2K, rKm, rKM, r1Km, r1KM, r2Km, r2KM, t, i) > lim)
     540      293988 :       Cmin = t;
     541             :     else
     542      180498 :       Cmax = t;
     543             :   }
     544       54702 :   return Cmax;
     545             : }
     546             : 
     547             : /* ~ 1 / Res(s = 1, zeta_K) */
     548             : static GEN
     549       54702 : compute_invres(GRHcheck_t *S, long LIMC)
     550             : {
     551       54702 :   pari_sp av = avma;
     552       54702 :   double loginvres = 0.;
     553             :   GRHprime_t *pr;
     554             :   long i;
     555       54702 :   double logLIMC = log((double)LIMC);
     556       54702 :   double logLIMC2 = logLIMC*logLIMC, denc;
     557             :   double c0, c1, c2;
     558       54702 :   denc = 1/(pow((double)LIMC, 3.) * logLIMC * logLIMC2);
     559       54702 :   c2 = (    logLIMC2 + 3 * logLIMC / 2 + 1) * denc;
     560       54702 :   denc *= LIMC;
     561       54702 :   c1 = (3 * logLIMC2 + 4 * logLIMC     + 2) * denc;
     562       54702 :   denc *= LIMC;
     563       54702 :   c0 = (3 * logLIMC2 + 5 * logLIMC / 2 + 1) * denc;
     564     6423558 :   for (pr = S->primes, i = S->nprimes; i > 0; pr++, i--)
     565             :   {
     566             :     GEN dec, fs, ns;
     567             :     long addpsi;
     568             :     double addpsi1, addpsi2;
     569     6416778 :     double logp = pr->logp, NPk;
     570     6416778 :     long j, k, limp = logLIMC/logp;
     571     6416778 :     ulong p = pr->p, p2 = p*p;
     572     6416778 :     if (limp < 1) break;
     573     6368856 :     dec = pr->dec;
     574     6368856 :     fs = gel(dec, 1); ns = gel(dec, 2);
     575     6368856 :     loginvres += 1./p;
     576             :     /* NB: limp = 1 nearly always and limp > 2 for very few primes */
     577     7536288 :     for (k=2, NPk = p; k <= limp; k++) { NPk *= p; loginvres += 1/(k * NPk); }
     578     6368856 :     addpsi = limp;
     579     6368856 :     addpsi1 = p *(pow((double)p , (double)limp)-1)/(p -1);
     580     6368856 :     addpsi2 = p2*(pow((double)p2, (double)limp)-1)/(p2-1);
     581     6368856 :     j = lg(fs);
     582    14204196 :     while (--j > 0)
     583             :     {
     584             :       long f, nb, kmax;
     585             :       double NP, NP2, addinvres;
     586     7835340 :       f = fs[j]; if (f > limp) continue;
     587     3406386 :       nb = ns[j];
     588     3406386 :       NP = pow((double)p, (double)f);
     589     3406386 :       addinvres = 1/NP;
     590     3406386 :       kmax = limp / f;
     591     4156652 :       for (k=2, NPk = NP; k <= kmax; k++) { NPk *= NP; addinvres += 1/(k*NPk); }
     592     3406386 :       NP2 = NP*NP;
     593     3406386 :       loginvres -= nb * addinvres;
     594     3406386 :       addpsi -= nb * f * kmax;
     595     3406386 :       addpsi1 -= nb*(f*NP *(pow(NP ,(double)kmax)-1)/(NP -1));
     596     3406386 :       addpsi2 -= nb*(f*NP2*(pow(NP2,(double)kmax)-1)/(NP2-1));
     597             :     }
     598     6368856 :     loginvres -= (addpsi*c0 - addpsi1*c1 + addpsi2*c2)*logp;
     599             :   }
     600       54702 :   return gerepileuptoleaf(av, mpexp(dbltor(loginvres)));
     601             : }
     602             : 
     603             : static long
     604       54702 : nthideal(GRHcheck_t *S, GEN nf, long n)
     605             : {
     606       54702 :   pari_sp av = avma;
     607       54702 :   GEN P = nf_get_pol(nf);
     608       54702 :   ulong p = 0, *vecN = (ulong*)const_vecsmall(n, LONG_MAX);
     609       54702 :   long i, N = poldegree(P, -1);
     610       54702 :   for (i = 0; ; i++)
     611      197016 :   {
     612             :     GRHprime_t *pr;
     613             :     GEN fs;
     614      251718 :     cache_prime_dec(S, p+1, nf);
     615      251718 :     pr = S->primes + i;
     616      251718 :     fs = gel(pr->dec, 1);
     617      251718 :     p = pr->p;
     618      251718 :     if (fs[1] != N)
     619             :     {
     620      168912 :       GEN ns = gel(pr->dec, 2);
     621      168912 :       long k, l, j = lg(fs);
     622      378696 :       while (--j > 0)
     623             :       {
     624      209784 :         ulong NP = upowuu(p, fs[j]);
     625             :         long nf;
     626      209784 :         if (!NP) continue;
     627      643628 :         for (k = 1; k <= n; k++) if (vecN[k] > NP) break;
     628      209434 :         if (k > n) continue;
     629             :         /* vecN[k] <= NP */
     630      135689 :         nf = ns[j]; /*#{primes of norme NP} = nf, insert them here*/
     631      303789 :         for (l = k+nf; l <= n; l++) vecN[l] = vecN[l-nf];
     632      342759 :         for (l = 0; l < nf && k+l <= n; l++) vecN[k+l] = NP;
     633      312071 :         while (l <= k) vecN[l++] = NP;
     634             :       }
     635             :     }
     636      251718 :     if (p > vecN[n]) break;
     637             :   }
     638       54702 :   return gc_long(av, vecN[n]);
     639             : }
     640             : 
     641             : /* volume of unit ball in R^n: \pi^{n/2} / \Gamma(n/2 + 1) */
     642             : static double
     643       56633 : ballvol(long n)
     644             : {
     645       56633 :   double v = odd(n)? 2: 1;
     646      129405 :   for (; n > 1; n -= 2) v *= (2 * M_PI) / n;
     647       56633 :   return v;
     648             : }
     649             : 
     650             : /* Compute FB, LV, iLP + KC*. Reset perm
     651             :  * C2: bound for norm of tested prime ideals (includes be_honest())
     652             :  * C1: bound for p, such that P|p (NP <= C2) used to build relations */
     653             : static void
     654       56633 : FBgen(FB_t *F, GEN nf, long N, ulong C1, ulong C2, GRHcheck_t *S)
     655             : {
     656             :   GRHprime_t *pr;
     657             :   long i, ip;
     658             :   GEN prim;
     659       56633 :   const double L = log((double)C2 + 0.5);
     660             : 
     661       56633 :   cache_prime_dec(S, C2, nf);
     662       56633 :   pr = S->primes;
     663       56633 :   F->sfb_chg = 0;
     664       56633 :   F->FB  = cgetg(C2+1, t_VECSMALL);
     665       56633 :   F->iLP = cgetg(C2+1, t_VECSMALL);
     666       56633 :   F->LV = zerovec(C2);
     667             : 
     668       56633 :   prim = icopy(gen_1);
     669       56633 :   i = ip = 0;
     670       56633 :   F->KC = F->KCZ = 0;
     671      372971 :   for (;; pr++) /* p <= C2 */
     672      372971 :   {
     673      429604 :     ulong p = pr->p;
     674             :     long k, l, m;
     675             :     GEN LP, nb, f;
     676             : 
     677      429604 :     if (!F->KC && p > C1) { F->KCZ = i; F->KC = ip; }
     678      429604 :     if (p > C2) break;
     679             : 
     680      397667 :     if (DEBUGLEVEL>1) err_printf(" %ld",p);
     681             : 
     682      397667 :     f = gel(pr->dec, 1); nb = gel(pr->dec, 2);
     683      397667 :     if (f[1] == N)
     684             :     {
     685      125115 :       if (p == C2) break;
     686      117795 :       continue; /* p inert */
     687             :     }
     688      272552 :     l = (long)(L/pr->logp); /* p^f <= C2  <=> f <= l */
     689      497188 :     for (k=0, m=1; m < lg(f) && f[m]<=l; m++) k += nb[m];
     690      272552 :     if (!k)
     691             :     { /* too inert to appear in FB */
     692       62208 :       if (p == C2) break;
     693       61662 :       continue;
     694             :     }
     695      210344 :     prim[2] = p; LP = idealprimedec_limit_f(nf,prim, l);
     696             :     /* keep noninert ideals with Norm <= C2 */
     697      210344 :     if (m == lg(f)) setisclone(LP); /* flag it: all prime divisors in FB */
     698      210344 :     F->FB[++i]= p;
     699      210344 :     gel(F->LV,p) = LP;
     700      210344 :     F->iLP[p] = ip; ip += k;
     701      210344 :     if (p == C2) break;
     702             :   }
     703       56633 :   if (!F->KC) { F->KCZ = i; F->KC = ip; }
     704             :   /* Note F->KC > 0 otherwise GRHchk is false */
     705       56633 :   setlg(F->FB, F->KCZ+1); F->KCZ2 = i;
     706       56633 :   F->prodZ = zv_prod_Z(F->FB);
     707       56633 :   if (DEBUGLEVEL>1)
     708             :   {
     709           0 :     err_printf("\n");
     710           0 :     if (DEBUGLEVEL>6)
     711             :     {
     712           0 :       err_printf("########## FACTORBASE ##########\n\n");
     713           0 :       err_printf("KC2=%ld, KC=%ld, KCZ=%ld, KCZ2=%ld\n",
     714             :                   ip, F->KC, F->KCZ, F->KCZ2);
     715           0 :       for (i=1; i<=F->KCZ; i++) err_printf("++ LV[%ld] = %Ps",i,gel(F->LV,F->FB[i]));
     716             :     }
     717             :   }
     718       56633 :   F->perm = NULL; F->L_jid = NULL;
     719       56633 :   F->ballvol = ballvol(nf_get_degree(nf));
     720       56633 : }
     721             : 
     722             : static int
     723      424152 : GRHchk(GEN nf, GRHcheck_t *S, ulong LIMC)
     724             : {
     725      424152 :   double logC = log((double)LIMC), SA = 0, SB = 0;
     726      424152 :   GRHprime_t *pr = S->primes;
     727             : 
     728      424152 :   cache_prime_dec(S, LIMC, nf);
     729      424152 :   for (pr = S->primes;; pr++)
     730     2614182 :   {
     731     3038334 :     ulong p = pr->p;
     732             :     GEN dec, fs, ns;
     733             :     double logCslogp;
     734             :     long j;
     735             : 
     736     3038334 :     if (p > LIMC) break;
     737     2705034 :     dec = pr->dec; fs = gel(dec, 1); ns = gel(dec,2);
     738     2705034 :     logCslogp = logC/pr->logp;
     739     4257570 :     for (j = 1; j < lg(fs); j++)
     740             :     {
     741     3329196 :       long f = fs[j], M, nb;
     742             :       double logNP, q, A, B;
     743     3329196 :       if (f > logCslogp) break;
     744     1552536 :       logNP = f * pr->logp;
     745     1552536 :       q = 1/sqrt((double)upowuu(p, f));
     746     1552536 :       A = logNP * q; B = logNP * A; M = (long)(logCslogp/f);
     747     1552536 :       if (M > 1)
     748             :       {
     749      321912 :         double inv1_q = 1 / (1-q);
     750      321912 :         A *= (1 - pow(q, (double)M)) * inv1_q;
     751      321912 :         B *= (1 - pow(q, (double)M)*(M+1 - M*q)) * inv1_q * inv1_q;
     752             :       }
     753     1552536 :       nb = ns[j];
     754     1552536 :       SA += nb * A;
     755     1552536 :       SB += nb * B;
     756             :     }
     757     2705034 :     if (p == LIMC) break;
     758             :   }
     759      424152 :   return GRHok(S, logC, SA, SB);
     760             : }
     761             : 
     762             : /*  SMOOTH IDEALS */
     763             : static void
     764     7819899 : store(long i, long e, FACT *fact)
     765             : {
     766     7819899 :   ++fact[0].pr;
     767     7819899 :   fact[fact[0].pr].pr = i; /* index */
     768     7819899 :   fact[fact[0].pr].ex = e; /* exponent */
     769     7819899 : }
     770             : 
     771             : /* divide out m by all P|p, k = v_p(Nm) */
     772             : static int
     773        2067 : divide_p_elt(GEN LP, long ip, long k, GEN m, FACT *fact)
     774             : {
     775        2067 :   long j, l = lg(LP);
     776        2836 :   for (j=1; j<l; j++)
     777             :   {
     778        2836 :     GEN P = gel(LP,j);
     779        2836 :     long v = ZC_nfval(m, P);
     780        2836 :     if (!v) continue;
     781        2463 :     store(ip + j, v, fact); /* v = v_P(m) > 0 */
     782        2463 :     k -= v * pr_get_f(P);
     783        2463 :     if (!k) return 1;
     784             :   }
     785           0 :   return 0;
     786             : }
     787             : /* divide out I by all P|p, k = v_p(NI) */
     788             : static int
     789      140203 : divide_p_id(GEN LP, long ip, long k, GEN nf, GEN I, FACT *fact)
     790             : {
     791      140203 :   long j, l = lg(LP);
     792      210308 :   for (j=1; j<l; j++)
     793             :   {
     794      203570 :     GEN P = gel(LP,j);
     795      203570 :     long v = idealval(nf,I, P);
     796      203570 :     if (!v) continue;
     797      136466 :     store(ip + j, v, fact); /* v = v_P(I) > 0 */
     798      136466 :     k -= v * pr_get_f(P);
     799      136466 :     if (!k) return 1;
     800             :   }
     801        6738 :   return 0;
     802             : }
     803             : /* divide out m/I by all P|p, k = v_p(Nm/NI) */
     804             : static int
     805     4486354 : divide_p_quo(GEN LP, long ip, long k, GEN nf, GEN I, GEN m, FACT *fact)
     806             : {
     807     4486354 :   long j, l = lg(LP);
     808    14864837 :   for (j=1; j<l; j++)
     809             :   {
     810    14789039 :     GEN P = gel(LP,j);
     811    14789039 :     long v = ZC_nfval(m, P);
     812    14789039 :     if (!v) continue;
     813     6697661 :     v -= idealval(nf,I, P);
     814     6697661 :     if (!v) continue;
     815     5701633 :     store(ip + j, v, fact); /* v = v_P(m / I) > 0 */
     816     5701633 :     k -= v * pr_get_f(P);
     817     5701633 :     if (!k) return 1;
     818             :   }
     819       75798 :   return 0;
     820             : }
     821             : 
     822             : static int
     823     4628624 : divide_p(FB_t *F, long p, long k, GEN nf, GEN I, GEN m, FACT *fact)
     824             : {
     825     4628624 :   GEN LP = gel(F->LV,p);
     826     4628624 :   long ip = F->iLP[p];
     827     4628624 :   if (!m) return divide_p_id (LP,ip,k,nf,I,fact);
     828     4488421 :   if (!I) return divide_p_elt(LP,ip,k,m,fact);
     829     4486354 :   return divide_p_quo(LP,ip,k,nf,I,m,fact);
     830             : }
     831             : 
     832             : /* Let x = m if I == NULL,
     833             :  *         I if m == NULL,
     834             :  *         m/I otherwise.
     835             :  * Can we factor the integral primitive ideal x ? |N| = Norm x > 0 */
     836             : static long
     837    15429611 : can_factor(FB_t *F, GEN nf, GEN I, GEN m, GEN N, FACT *fact)
     838             : {
     839             :   GEN f, p, e;
     840             :   long i, l;
     841    15429611 :   fact[0].pr = 0;
     842    15429611 :   if (is_pm1(N)) return 1;
     843    14607014 :   if (!is_pm1(Z_ppo(N, F->prodZ))) return 0;
     844     2329463 :   f = absZ_factor(N); p = gel(f,1); e = gel(f,2); l = lg(p);
     845     6875551 :   for (i = 1; i < l; i++)
     846     4628624 :     if (!divide_p(F, itou(gel(p,i)), itou(gel(e,i)), nf, I, m, fact))
     847             :     {
     848       82536 :       if (DEBUGLEVEL > 1) err_printf(".");
     849       82536 :       return 0;
     850             :     }
     851     2246927 :   return 1;
     852             : }
     853             : 
     854             : /* can we factor m/I ? [m in I from idealpseudomin_nonscalar], NI = norm I */
     855             : static long
     856    14279175 : factorgen(FB_t *F, GEN nf, GEN I, GEN NI, GEN m, FACT *fact)
     857             : {
     858             :   long e;
     859    14279175 :   GEN Nm = embed_norm(RgM_RgC_mul(nf_get_M(nf),m), nf_get_r1(nf));
     860    14279175 :   GEN N = grndtoi(NI? divri(Nm, NI): Nm, &e); /* ~ N(m/I) */
     861    14279175 :   if (e > -32)
     862             :   {
     863           0 :     if (DEBUGLEVEL > 1) err_printf("+");
     864           0 :     return 0;
     865             :   }
     866    14279175 :   return can_factor(F, nf, I, m, N, fact);
     867             : }
     868             : 
     869             : /*  FUNDAMENTAL UNITS */
     870             : 
     871             : /* a, y real. Return  (Re(x) + a) + I * (Im(x) % y) */
     872             : static GEN
     873     5651211 : addRe_modIm(GEN x, GEN a, GEN y, GEN iy)
     874             : {
     875             :   GEN z;
     876     5651211 :   if (typ(x) == t_COMPLEX)
     877             :   {
     878     4018991 :     GEN re, im = modRr_i(gel(x,2), y, iy);
     879     4018991 :     if (!im) return NULL;
     880     4018991 :     re = gadd(gel(x,1), a);
     881     4018991 :     z = gequal0(im)? re: mkcomplex(re, im);
     882             :   }
     883             :   else
     884     1632220 :     z = gadd(x, a);
     885     5651211 :   return z;
     886             : }
     887             : static GEN
     888      173088 : modIm(GEN x, GEN y, GEN iy)
     889             : {
     890      173088 :   if (typ(x) == t_COMPLEX)
     891             :   {
     892      162186 :     GEN im = modRr_i(gel(x,2), y, iy);
     893      162186 :     if (!im) return NULL;
     894      162186 :     x = gequal0(im)? gel(x,1): mkcomplex(gel(x,1), im);
     895             :   }
     896      173088 :   return x;
     897             : }
     898             : 
     899             : /* clean archimedean components. ipi = 2^n / pi (n arbitrary); its
     900             :  * exponent may be modified */
     901             : static GEN
     902     2509386 : cleanarch(GEN x, long N, GEN ipi, long prec)
     903             : {
     904             :   long i, l, R1, RU;
     905     2509386 :   GEN s, y = cgetg_copy(x, &l);
     906             : 
     907     2509386 :   if (!ipi) ipi = invr(mppi(prec));
     908     2509386 :   if (typ(x) == t_MAT)
     909             :   {
     910      450773 :     for (i = 1; i < l; i++)
     911      395939 :       if (!(gel(y,i) = cleanarch(gel(x,i), N, ipi, prec))) return NULL;
     912       54834 :     return y;
     913             :   }
     914     2454552 :   RU = l-1; R1 = (RU<<1) - N;
     915     2454552 :   s = gdivgs(RgV_sum(real_i(x)), -N); /* -log |norm(x)| / N */
     916     2454552 :   i = 1;
     917     2454552 :   if (R1)
     918             :   {
     919     2044223 :     GEN pi2 = Pi2n(1, prec);
     920     2044223 :     setexpo(ipi, -3); /* 1/(2pi) */
     921     6293868 :     for (; i <= R1; i++)
     922     4249645 :       if (!(gel(y,i) = addRe_modIm(gel(x,i), s, pi2, ipi))) return NULL;
     923             :   }
     924     2454552 :   if (i <= RU)
     925             :   {
     926      921938 :     GEN pi4 = Pi2n(2, prec), s2 = gmul2n(s, 1);
     927      921938 :     setexpo(ipi, -4); /* 1/(4pi) */
     928     2323504 :     for (; i <= RU; i++)
     929     1401566 :       if (!(gel(y,i) = addRe_modIm(gel(x,i), s2, pi4, ipi))) return NULL;
     930             :   }
     931     2454552 :   return y;
     932             : }
     933             : GEN
     934      167097 : nf_cxlog_normalize(GEN nf, GEN x, long prec)
     935             : {
     936      167097 :   long N = nf_get_degree(nf);
     937      167097 :   return cleanarch(x, N, NULL, prec);
     938             : }
     939             : 
     940             : /* clean unit archimedean components. ipi = 2^n / pi (n arbitrary); its
     941             :  * exponent may be modified */
     942             : static GEN
     943      114018 : cleanarchunit(GEN x, long N, GEN ipi, long prec)
     944             : {
     945             :   long i, l, R1, RU;
     946      114018 :   GEN y = cgetg_copy(x, &l);
     947             : 
     948      114018 :   if (!ipi) ipi = invr(mppi(prec));
     949      114018 :   if (typ(x) == t_MAT)
     950             :   {
     951      114012 :     for (i = 1; i < l; i++)
     952       59310 :       if (!(gel(y,i) = cleanarchunit(gel(x,i), N, ipi, prec))) return NULL;
     953       54702 :     return y;
     954             :   }
     955       59310 :   if (gexpo(RgV_sum(real_i(x))) > -10) return NULL;
     956       59304 :   RU = l-1; R1 = (RU<<1) - N;
     957       59304 :   i = 1;
     958       59304 :   if (R1)
     959             :   {
     960       46872 :     GEN pi2 = Pi2n(1, prec);
     961       46872 :     setexpo(ipi, -3); /* 1/(2pi) */
     962      159336 :     for (; i <= R1; i++)
     963      112464 :       if (!(gel(y,i) = modIm(gel(x,i), pi2, ipi))) return NULL;
     964             :   }
     965       59304 :   if (i <= RU)
     966             :   {
     967       29550 :     GEN pi4 = Pi2n(2, prec);
     968       29550 :     setexpo(ipi, -4); /* 1/(4pi) */
     969       90174 :     for (; i <= RU; i++)
     970       60624 :       if (!(gel(y,i) = modIm(gel(x,i), pi4, ipi))) return NULL;
     971             :   }
     972       59304 :   return y;
     973             : }
     974             : 
     975             : static GEN
     976         334 : not_given(long reason)
     977             : {
     978         334 :   if (DEBUGLEVEL)
     979           0 :     switch(reason)
     980             :     {
     981           0 :       case fupb_LARGE:
     982           0 :         pari_warn(warner,"fundamental units too large, not given");
     983           0 :         break;
     984           0 :       case fupb_PRECI:
     985           0 :         pari_warn(warner,"insufficient precision for fundamental units, not given");
     986           0 :         break;
     987             :     }
     988         334 :   return NULL;
     989             : }
     990             : 
     991             : /* check whether exp(x) will 1) get too big (real(x) large), 2) require
     992             :  * large accuracy for argument reduction (imag(x) large) */
     993             : static long
     994     2302387 : expbitprec(GEN x, long *e)
     995             : {
     996             :   GEN re, im;
     997     2302387 :   if (typ(x) != t_COMPLEX) re = x;
     998             :   else
     999             :   {
    1000     1423298 :     im = gel(x,2); *e = maxss(*e, expo(im) + 5 - bit_prec(im));
    1001     1423298 :     re = gel(x,1);
    1002             :   }
    1003     2302387 :   return (expo(re) <= 20);
    1004             : 
    1005             : }
    1006             : static long
    1007     1000221 : RgC_expbitprec(GEN x)
    1008             : {
    1009     1000221 :   long l = lg(x), i, e = - (long)HIGHEXPOBIT;
    1010     3129124 :   for (i = 1; i < l; i++)
    1011     2129395 :     if (!expbitprec(gel(x,i), &e)) return LONG_MAX;
    1012      999729 :   return e;
    1013             : }
    1014             : static long
    1015       41640 : RgM_expbitprec(GEN x)
    1016             : {
    1017       41640 :   long i, j, I, J, e = - (long)HIGHEXPOBIT;
    1018       41640 :   RgM_dimensions(x, &I,&J);
    1019      100884 :   for (j = 1; j <= J; j++)
    1020      232236 :     for (i = 1; i <= I; i++)
    1021      172992 :       if (!expbitprec(gcoeff(x,i,j), &e)) return LONG_MAX;
    1022       41586 :   return e;
    1023             : }
    1024             : 
    1025             : static GEN
    1026        1209 : FlxqX_chinese_unit(GEN X, GEN U, GEN invzk, GEN D, GEN T, ulong p)
    1027             : {
    1028        1209 :   long i, lU = lg(U), lX = lg(X), d = lg(invzk)-1;
    1029        1209 :   GEN M = cgetg(lU, t_MAT);
    1030        1209 :   if (D)
    1031             :   {
    1032        1115 :     D = Flv_inv(D, p);
    1033       61113 :     for (i = 1; i < lX; i++)
    1034       59998 :       if (uel(D, i) != 1)
    1035       49587 :         gel(X,i) = Flx_Fl_mul(gel(X,i), uel(D,i), p);
    1036             :   }
    1037        3399 :   for (i = 1; i < lU; i++)
    1038             :   {
    1039        2190 :     GEN H = FlxqV_factorback(X, gel(U, i), T, p);
    1040        2190 :     gel(M, i) = Flm_Flc_mul(invzk, Flx_to_Flv(H, d), p);
    1041             :   }
    1042        1209 :   return M;
    1043             : }
    1044             : 
    1045             : static GEN
    1046         238 : chinese_unit_slice(GEN A, GEN U, GEN B, GEN D, GEN C, GEN P, GEN *mod)
    1047             : {
    1048         238 :   pari_sp av = avma;
    1049         238 :   long i, n = lg(P)-1, v = varn(C);
    1050             :   GEN H, T;
    1051         238 :   if (n == 1)
    1052             :   {
    1053           0 :     ulong p = uel(P,1);
    1054           0 :     GEN a = ZXV_to_FlxV(A, p), b = ZM_to_Flm(B, p), c = ZX_to_Flx(C, p);
    1055           0 :     GEN d = D ? ZV_to_Flv(D, p): NULL;
    1056           0 :     GEN Hp = FlxqX_chinese_unit(a, U, b, d, c, p);
    1057           0 :     H = gerepileupto(av, Flm_to_ZM(Hp));
    1058           0 :     *mod = utoi(p);
    1059           0 :     return H;
    1060             :   }
    1061         238 :   T = ZV_producttree(P);
    1062         238 :   A = ZXC_nv_mod_tree(A, P, T, v);
    1063         238 :   B = ZM_nv_mod_tree(B, P, T);
    1064         238 :   D = D ? ZV_nv_mod_tree(D, P, T): NULL;
    1065         238 :   C = ZX_nv_mod_tree(C, P, T);
    1066             : 
    1067         238 :   H = cgetg(n+1, t_VEC);
    1068        1447 :   for(i=1; i <= n; i++)
    1069             :   {
    1070        1209 :     ulong p = P[i];
    1071        1209 :     GEN a = gel(A,i), b = gel(B,i), c = gel(C,i), d = D ? gel(D,i): NULL;
    1072        1209 :     gel(H,i) = FlxqX_chinese_unit(a, U, b, d, c, p);
    1073             :   }
    1074         238 :   H = nmV_chinese_center_tree_seq(H, P, T, ZV_chinesetree(P, T));
    1075         238 :   *mod = gmael(T, lg(T)-1, 1); return gc_all(av, 2, &H, mod);
    1076             : }
    1077             : 
    1078             : GEN
    1079         238 : chinese_unit_worker(GEN P, GEN A, GEN U, GEN B, GEN D, GEN C)
    1080             : {
    1081         238 :   GEN V = cgetg(3, t_VEC);
    1082         238 :   gel(V,1) = chinese_unit_slice(A, U, B, isintzero(D) ? NULL: D, C, P, &gel(V,2));
    1083         238 :   return V;
    1084             : }
    1085             : 
    1086             : /* Let x = \prod X[i]^E[i] = u, return u.
    1087             :  * If dX != NULL, X[i] = nX[i] / dX[i] where nX[i] is a ZX, dX[i] in Z */
    1088             : static GEN
    1089          81 : chinese_unit(GEN nf, GEN nX, GEN dX, GEN U, ulong bnd)
    1090             : {
    1091          81 :   pari_sp av = avma;
    1092          81 :   GEN f = nf_get_index(nf), T = nf_get_pol(nf), invzk = nf_get_invzk(nf);
    1093             :   GEN H, mod;
    1094             :   forprime_t S;
    1095          81 :   GEN worker = snm_closure(is_entry("_chinese_unit_worker"),
    1096             :                mkcol5(nX, U, invzk, dX? dX: gen_0, T));
    1097          81 :   init_modular_big(&S);
    1098          81 :   H = gen_crt("chinese_units", worker, &S, f, bnd, 0, &mod, nmV_chinese_center, FpM_center);
    1099          81 :   settyp(H, t_VEC); return gerepilecopy(av, H);
    1100             : }
    1101             : 
    1102             : /* *pE a ZM */
    1103             : static void
    1104         141 : ZM_remove_unused(GEN *pE, GEN *pX)
    1105             : {
    1106         141 :   long j, k, l = lg(*pX);
    1107         141 :   GEN E = *pE, v = cgetg(l, t_VECSMALL);
    1108       14068 :   for (j = k = 1; j < l; j++)
    1109       13927 :     if (!ZMrow_equal0(E, j)) v[k++] = j;
    1110         141 :   if (k < l)
    1111             :   {
    1112         141 :     setlg(v, k);
    1113         141 :     *pX = vecpermute(*pX,v);
    1114         141 :     *pE = rowpermute(E,v);
    1115             :   }
    1116         141 : }
    1117             : 
    1118             : /* s = -log|norm(x)|/N */
    1119             : static GEN
    1120     1059525 : fixarch(GEN x, GEN s, long R1)
    1121             : {
    1122             :   long i, l;
    1123     1059525 :   GEN y = cgetg_copy(x, &l);
    1124     2933050 :   for (i = 1; i <= R1; i++) gel(y,i) = gadd(s, gel(x,i));
    1125     1488987 :   for (     ; i <   l; i++) gel(y,i) = gadd(s, gmul2n(gel(x,i),-1));
    1126     1059525 :   return y;
    1127             : }
    1128             : 
    1129             : static GEN
    1130       54702 : getfu(GEN nf, GEN *ptA, GEN *ptU, long prec)
    1131             : {
    1132       54702 :   GEN U, y, matep, A, T = nf_get_pol(nf), M = nf_get_M(nf);
    1133       54702 :   long e, j, R1, RU, N = degpol(T);
    1134             : 
    1135       54702 :   R1 = nf_get_r1(nf); RU = (N+R1) >> 1;
    1136       54702 :   if (RU == 1) return cgetg(1,t_VEC);
    1137             : 
    1138       41640 :   A = *ptA;
    1139       41640 :   matep = cgetg(RU,t_MAT);
    1140      100944 :   for (j = 1; j < RU; j++)
    1141             :   {
    1142       59304 :     GEN Aj = gel(A,j), s = gdivgs(RgV_sum(real_i(Aj)), -N);
    1143       59304 :     gel(matep,j) = fixarch(Aj, s, R1);
    1144             :   }
    1145       41640 :   U = lll(real_i(matep));
    1146       41640 :   if (lg(U) < RU) return not_given(fupb_PRECI);
    1147       41640 :   if (ptU) { *ptU = U; *ptA = A = RgM_ZM_mul(A,U); }
    1148       41640 :   y = RgM_ZM_mul(matep,U);
    1149       41640 :   e = RgM_expbitprec(y);
    1150       41640 :   if (e >= 0) return not_given(e == LONG_MAX? fupb_LARGE: fupb_PRECI);
    1151       41586 :   if (prec <= 0) prec = gprecision(A);
    1152       41586 :   y = RgM_solve_realimag(M, gexp(y,prec));
    1153       41586 :   if (!y) return not_given(fupb_PRECI);
    1154       41586 :   y = grndtoi(y, &e); if (e >= 0) return not_given(fupb_PRECI);
    1155       41313 :   settyp(y, t_VEC);
    1156             : 
    1157       41313 :   if (!ptU) *ptA = A = RgM_ZM_mul(A, U);
    1158       99987 :   for (j = 1; j < RU; j++)
    1159             :   { /* y[i] are hopefully unit generators. Normalize: smallest T2 norm */
    1160       58681 :     GEN u = gel(y,j), v = zk_inv(nf, u);
    1161       58681 :     if (!v || !is_pm1(Q_denom(v)) || ZV_isscalar(u))
    1162           7 :       return not_given(fupb_PRECI);
    1163       58674 :     if (gcmp(RgC_fpnorml2(v,DEFAULTPREC), RgC_fpnorml2(u,DEFAULTPREC)) < 0)
    1164             :     {
    1165       25233 :       gel(A,j) = RgC_neg(gel(A,j));
    1166       25233 :       if (ptU) gel(U,j) = ZC_neg(gel(U,j));
    1167       25233 :       u = v;
    1168             :     }
    1169       58674 :     gel(y,j) = nf_to_scalar_or_alg(nf, u);
    1170             :   }
    1171       41306 :   return y;
    1172             : }
    1173             : 
    1174             : static void
    1175           0 : err_units() { pari_err_PREC("makeunits [cannot get units, use bnfinit(,1)]"); }
    1176             : 
    1177             : /* bound for log2 |sigma(u)|, sigma complex embedding, u fundamental unit
    1178             :  * attached to bnf_get_logfu */
    1179             : static double
    1180          81 : log2fubound(GEN bnf)
    1181             : {
    1182          81 :   GEN LU = bnf_get_logfu(bnf);
    1183          81 :   long i, j, l = lg(LU), r1 = nf_get_r1(bnf_get_nf(bnf));
    1184          81 :   double e = 0.0;
    1185         284 :   for (j = 1; j < l; j++)
    1186             :   {
    1187         203 :     GEN u = gel(LU,j);
    1188         537 :     for (i = 1; i <= r1; i++)
    1189             :     {
    1190         334 :       GEN E = real_i(gel(u,i));
    1191         334 :       e = maxdd(e, gtodouble(E));
    1192             :     }
    1193         723 :     for (     ; i <= l; i++)
    1194             :     {
    1195         520 :       GEN E = real_i(gel(u,i));
    1196         520 :       e = maxdd(e, gtodouble(E) / 2);
    1197             :     }
    1198             :   }
    1199          81 :   return e / M_LN2;
    1200             : }
    1201             : /* bound for log2(|RgM_solve_realimag(M, y)|_oo / |y|_oo)*/
    1202             : static double
    1203          81 : log2Mbound(GEN nf)
    1204             : {
    1205          81 :   GEN G = nf_get_G(nf), D = nf_get_disc(nf);
    1206          81 :   long r2 = nf_get_r2(nf), l = lg(G), i;
    1207          81 :   double e, d = dbllog2(D)/2 - r2 * M_LN2; /* log2 |det(split_realimag(M))| */
    1208          81 :   e = log2(nf_get_degree(nf));
    1209         460 :   for (i = 2; i < l; i++) e += dbllog2(gnorml2(gel(G,i))); /* Hadamard bound */
    1210          81 :   return e / 2 - d;
    1211             : }
    1212             : 
    1213             : static GEN
    1214          81 : vec_chinese_units(GEN bnf)
    1215             : {
    1216          81 :   GEN nf = bnf_get_nf(bnf), SUnits = bnf_get_sunits(bnf);
    1217          81 :   double bnd = ceil(log2Mbound(nf) + log2fubound(bnf));
    1218          81 :   GEN X, dX, Y, U, f = nf_get_index(nf);
    1219          81 :   long j, l, v = nf_get_varn(nf);
    1220          81 :   if (!SUnits) err_units(); /* no compact units */
    1221          81 :   Y = gel(SUnits,1);
    1222          81 :   U = gel(SUnits,2);
    1223          81 :   ZM_remove_unused(&U, &Y); l = lg(Y); X = cgetg(l, t_VEC);
    1224          81 :   if (is_pm1(f)) f = dX = NULL; else dX = cgetg(l, t_VEC);
    1225        4420 :   for (j = 1; j < l; j++)
    1226             :   {
    1227        4339 :     GEN t = nf_to_scalar_or_alg(nf, gel(Y,j));
    1228        4339 :     if (f)
    1229             :     {
    1230             :       GEN den;
    1231        3612 :       t = Q_remove_denom(t, &den);
    1232        3612 :       gel(dX,j) = den ? den: gen_1;
    1233             :     }
    1234        4339 :     gel(X,j) = typ(t) == t_INT? scalarpol_shallow(t,v): t;
    1235             :   }
    1236          81 :   if (dblexpo(bnd) >= BITS_IN_LONG)
    1237           0 :     pari_err_OVERFLOW("vec_chinese_units [units too large]");
    1238          81 :   return chinese_unit(nf, X, dX, U, (ulong)bnd);
    1239             : }
    1240             : 
    1241             : static GEN
    1242       21344 : makeunits(GEN bnf)
    1243             : {
    1244       21344 :   GEN nf = bnf_get_nf(bnf), fu = bnf_get_fu_nocheck(bnf);
    1245       21344 :   GEN tu = nf_to_scalar_or_basis(nf, bnf_get_tuU(bnf));
    1246       21344 :   fu = (typ(fu) == t_MAT)? vec_chinese_units(bnf): matalgtobasis(nf, fu);
    1247       21344 :   return vec_prepend(fu, tu);
    1248             : }
    1249             : 
    1250             : /*******************************************************************/
    1251             : /*                                                                 */
    1252             : /*           PRINCIPAL IDEAL ALGORITHM (DISCRETE LOG)              */
    1253             : /*                                                                 */
    1254             : /*******************************************************************/
    1255             : 
    1256             : /* G: prime ideals, E: vector of nonnegative exponents.
    1257             :  * C = possible extra prime (^1) or NULL
    1258             :  * Return Norm (product) */
    1259             : static GEN
    1260          58 : get_norm_fact_primes(GEN G, GEN E, GEN C)
    1261             : {
    1262          58 :   pari_sp av=avma;
    1263          58 :   GEN N = gen_1, P, p;
    1264          58 :   long i, c = lg(E);
    1265          58 :   for (i=1; i<c; i++)
    1266             :   {
    1267           0 :     GEN ex = gel(E,i);
    1268           0 :     long s = signe(ex);
    1269           0 :     if (!s) continue;
    1270             : 
    1271           0 :     P = gel(G,i); p = pr_get_p(P);
    1272           0 :     N = mulii(N, powii(p, mului(pr_get_f(P), ex)));
    1273             :   }
    1274          58 :   if (C) N = mulii(N, pr_norm(C));
    1275          58 :   return gerepileuptoint(av, N);
    1276             : }
    1277             : 
    1278             : /* gen: HNF ideals */
    1279             : static GEN
    1280      995411 : get_norm_fact(GEN gen, GEN ex, GEN *pd)
    1281             : {
    1282      995411 :   long i, c = lg(ex);
    1283             :   GEN d,N,I,e,n,ne,de;
    1284      995411 :   d = N = gen_1;
    1285     1249585 :   for (i=1; i<c; i++)
    1286      254174 :     if (signe(gel(ex,i)))
    1287             :     {
    1288      150374 :       I = gel(gen,i); e = gel(ex,i); n = ZM_det_triangular(I);
    1289      150374 :       ne = powii(n,e);
    1290      150374 :       de = equalii(n, gcoeff(I,1,1))? ne: powii(gcoeff(I,1,1), e);
    1291      150374 :       N = mulii(N, ne);
    1292      150374 :       d = mulii(d, de);
    1293             :     }
    1294      995411 :   *pd = d; return N;
    1295             : }
    1296             : 
    1297             : static GEN
    1298     1133336 : get_pr_lists(GEN FB, long N, int list_pr)
    1299             : {
    1300             :   GEN pr, L;
    1301     1133336 :   long i, l = lg(FB), p, pmax;
    1302             : 
    1303     1133336 :   pmax = 0;
    1304     7871090 :   for (i=1; i<l; i++)
    1305             :   {
    1306     6737754 :     pr = gel(FB,i); p = pr_get_smallp(pr);
    1307     6737754 :     if (p > pmax) pmax = p;
    1308             :   }
    1309     1133336 :   L = const_vec(pmax, NULL);
    1310     1133336 :   if (list_pr)
    1311             :   {
    1312           0 :     for (i=1; i<l; i++)
    1313             :     {
    1314           0 :       pr = gel(FB,i); p = pr_get_smallp(pr);
    1315           0 :       if (!L[p]) gel(L,p) = vectrunc_init(N+1);
    1316           0 :       vectrunc_append(gel(L,p), pr);
    1317             :     }
    1318           0 :     for (p=1; p<=pmax; p++)
    1319           0 :       if (L[p]) gen_sort_inplace(gel(L,p), (void*)&cmp_prime_over_p,
    1320             :                                  &cmp_nodata, NULL);
    1321             :   }
    1322             :   else
    1323             :   {
    1324     7871090 :     for (i=1; i<l; i++)
    1325             :     {
    1326     6737754 :       pr = gel(FB,i); p = pr_get_smallp(pr);
    1327     6737754 :       if (!L[p]) gel(L,p) = vecsmalltrunc_init(N+1);
    1328     6737754 :       vecsmalltrunc_append(gel(L,p), i);
    1329             :     }
    1330             :   }
    1331     1133336 :   return L;
    1332             : }
    1333             : 
    1334             : /* recover FB, LV, iLP, KCZ from Vbase */
    1335             : static GEN
    1336     1133336 : recover_partFB(FB_t *F, GEN Vbase, long N)
    1337             : {
    1338     1133336 :   GEN FB, LV, iLP, L = get_pr_lists(Vbase, N, 0);
    1339     1133336 :   long l = lg(L), p, ip, i;
    1340             : 
    1341     1133336 :   i = ip = 0;
    1342     1133336 :   FB = cgetg(l, t_VECSMALL);
    1343     1133336 :   iLP= cgetg(l, t_VECSMALL);
    1344     1133336 :   LV = cgetg(l, t_VEC);
    1345    17168764 :   for (p = 2; p < l; p++)
    1346             :   {
    1347    16035428 :     if (!L[p]) continue;
    1348     3688878 :     FB[++i] = p;
    1349     3688878 :     gel(LV,p) = vecpermute(Vbase, gel(L,p));
    1350     3688878 :     iLP[p]= ip; ip += lg(gel(L,p))-1;
    1351             :   }
    1352     1133336 :   F->KCZ = i;
    1353     1133336 :   F->KC = ip;
    1354     1133336 :   F->FB = FB; setlg(FB, i+1);
    1355     1133336 :   F->prodZ = zv_prod_Z(F->FB);
    1356     1133336 :   F->LV = LV;
    1357     1133336 :   F->iLP= iLP; return L;
    1358             : }
    1359             : 
    1360             : /* add v^e to factorization */
    1361             : static void
    1362     2428722 : add_to_fact(long v, long e, FACT *fact)
    1363             : {
    1364     2428722 :   long i, n = fact[0].pr;
    1365     8213830 :   for (i=1; i<=n; i++)
    1366     6234493 :     if (fact[i].pr == v) { fact[i].ex += e; return; }
    1367     1979337 :   store(v, e, fact);
    1368             : }
    1369             : static void
    1370           0 : inv_fact(FACT *fact)
    1371             : {
    1372           0 :   long i, n = fact[0].pr;
    1373           0 :   for (i=1; i<=n; i++) fact[i].ex = -fact[i].ex;
    1374           0 : }
    1375             : 
    1376             : /* L (small) list of primes above the same p including pr. Return pr index */
    1377             : static int
    1378        2870 : pr_index(GEN L, GEN pr)
    1379             : {
    1380        2870 :   long j, l = lg(L);
    1381        2870 :   GEN al = pr_get_gen(pr);
    1382        2870 :   for (j=1; j<l; j++)
    1383        2870 :     if (ZV_equal(al, pr_get_gen(gel(L,j)))) return j;
    1384           0 :   pari_err_BUG("codeprime");
    1385             :   return 0; /* LCOV_EXCL_LINE */
    1386             : }
    1387             : 
    1388             : static long
    1389        2870 : Vbase_to_FB(FB_t *F, GEN pr)
    1390             : {
    1391        2870 :   long p = pr_get_smallp(pr);
    1392        2870 :   return F->iLP[p] + pr_index(gel(F->LV,p), pr);
    1393             : }
    1394             : 
    1395             : /* x, y 2 extended ideals whose first component is an integral HNF and second
    1396             :  * a famat */
    1397             : static GEN
    1398        3015 : idealHNF_mulred(GEN nf, GEN x, GEN y)
    1399             : {
    1400        3015 :   GEN A = idealHNF_mul(nf, gel(x,1), gel(y,1));
    1401        3015 :   GEN F = famat_mul_shallow(gel(x,2), gel(y,2));
    1402        3015 :   return idealred(nf, mkvec2(A, F));
    1403             : }
    1404             : /* idealred(x * pr^n), n > 0 is small, x extended ideal. Reduction in order to
    1405             :  * avoid prec pb: don't let id become too large as lgsub increases */
    1406             : static GEN
    1407        3846 : idealmulpowprime2(GEN nf, GEN x, GEN pr, ulong n)
    1408             : {
    1409        3846 :   GEN A = idealmulpowprime(nf, gel(x,1), pr, utoipos(n));
    1410        3846 :   return mkvec2(A, gel(x,2));
    1411             : }
    1412             : static GEN
    1413       56200 : init_famat(GEN x) { return mkvec2(x, trivial_fact()); }
    1414             : /* optimized idealfactorback + reduction; z = init_famat() */
    1415             : static GEN
    1416       24696 : genback(GEN z, GEN nf, GEN P, GEN E)
    1417             : {
    1418       24696 :   long i, l = lg(E);
    1419       24696 :   GEN I = NULL;
    1420       65740 :   for (i = 1; i < l; i++)
    1421       41044 :     if (signe(gel(E,i)))
    1422             :     {
    1423             :       GEN J;
    1424       27711 :       gel(z,1) = gel(P,i);
    1425       27711 :       J = idealpowred(nf, z, gel(E,i));
    1426       27711 :       I = I? idealHNF_mulred(nf, I, J): J;
    1427             :     }
    1428       24696 :   return I; /* != NULL since a generator */
    1429             : }
    1430             : 
    1431             : static GEN
    1432     1032184 : SPLIT_i(FB_t *F, GEN nf, GEN G, GEN x, GEN xred, GEN Nx, FACT *fact)
    1433             : {
    1434     1032184 :   pari_sp av = avma;
    1435     1032184 :   GEN L = idealpseudominvec(xred, G);
    1436     1032184 :   long k, l = lg(L);
    1437     1103187 :   for(k = 1; k < l; k++)
    1438     1089538 :     if (factorgen(F, nf, x, Nx, gel(L,k), fact)) return gel(L,k);
    1439       13649 :   return gc_NULL(av);
    1440             : }
    1441             : /* return famat y (principal ideal) such that y / x is smooth [wrt Vbase] */
    1442             : static GEN
    1443     1147346 : SPLIT(FB_t *F, GEN nf, GEN x, GEN Vbase, FACT *fact)
    1444             : {
    1445     1147346 :   GEN vecG, ex, y, x0, Nx = ZM_det_triangular(x);
    1446             :   long nbtest_lim, nbtest, i, j, ru, lgsub;
    1447             :   pari_sp av;
    1448             : 
    1449             :   /* try without reduction if x is small */
    1450     2294534 :   if (expi(gcoeff(x,1,1)) < 100 &&
    1451     1275999 :       can_factor(F, nf, x, NULL, Nx, fact)) return NULL;
    1452     1018535 :   if ((y = SPLIT_i(F, nf, nf_get_roundG(nf), x, x, Nx, fact))) return y;
    1453             : 
    1454             :   /* reduce in various directions */
    1455        7539 :   ru = lg(nf_get_roots(nf));
    1456        7539 :   vecG = cgetg(ru, t_VEC);
    1457       12294 :   for (j=1; j<ru; j++)
    1458             :   {
    1459       10796 :     gel(vecG,j) = nf_get_Gtwist1(nf, j);
    1460       10796 :     if ((y = SPLIT_i(F, nf, gel(vecG,j), x, x, Nx, fact))) return y;
    1461             :   }
    1462             : 
    1463             :   /* tough case, multiply by random products */
    1464        1498 :   lgsub = 3; nbtest = 1; nbtest_lim = 4;
    1465        1498 :   ex = cgetg(lgsub, t_VECSMALL);
    1466        1498 :   x0 = init_famat(x);
    1467             :   for(;;)
    1468         509 :   {
    1469        2007 :     GEN Ired, I, NI, id = x0;
    1470        2007 :     av = avma;
    1471        2007 :     if (DEBUGLEVEL>2) err_printf("# ideals tried = %ld\n",nbtest);
    1472        6117 :     for (i=1; i<lgsub; i++)
    1473             :     {
    1474        4110 :       ex[i] = random_bits(RANDOM_BITS);
    1475        4110 :       if (ex[i]) id = idealmulpowprime2(nf, id, gel(Vbase,i), ex[i]);
    1476             :     }
    1477        2007 :     if (id == x0) continue;
    1478             :     /* I^(-1) * \prod Vbase[i]^ex[i] = (id[2]) / x */
    1479             : 
    1480        1989 :     I = gel(id,1); NI = ZM_det_triangular(I);
    1481        1989 :     if (can_factor(F, nf, I, NULL, NI, fact))
    1482             :     {
    1483           0 :       inv_fact(fact); /* I^(-1) */
    1484           0 :       for (i=1; i<lgsub; i++)
    1485           0 :         if (ex[i]) add_to_fact(Vbase_to_FB(F,gel(Vbase,i)), ex[i], fact);
    1486           0 :       return gel(id,2);
    1487             :     }
    1488        1989 :     Ired = ru == 2? I: ZM_lll(I, 0.99, LLL_INPLACE);
    1489        3344 :     for (j=1; j<ru; j++)
    1490        2853 :       if ((y = SPLIT_i(F, nf, gel(vecG,j), I, Ired, NI, fact)))
    1491             :       {
    1492        4512 :         for (i=1; i<lgsub; i++)
    1493        3014 :           if (ex[i]) add_to_fact(Vbase_to_FB(F,gel(Vbase,i)), ex[i], fact);
    1494        1498 :         return famat_mul_shallow(gel(id,2), y);
    1495             :       }
    1496         491 :     set_avma(av);
    1497         491 :     if (++nbtest > nbtest_lim)
    1498             :     {
    1499          18 :       nbtest = 0;
    1500          18 :       if (++lgsub < minss(8, lg(Vbase)-1))
    1501             :       {
    1502          18 :         nbtest_lim <<= 1;
    1503          18 :         ex = cgetg(lgsub, t_VECSMALL);
    1504             :       }
    1505           0 :       else nbtest_lim = LONG_MAX; /* don't increase further */
    1506          18 :       if (DEBUGLEVEL>2) err_printf("SPLIT: increasing factor base [%ld]\n",lgsub);
    1507             :     }
    1508             :   }
    1509             : }
    1510             : 
    1511             : INLINE GEN
    1512     1137547 : bnf_get_W(GEN bnf) { return gel(bnf,1); }
    1513             : INLINE GEN
    1514     2266581 : bnf_get_B(GEN bnf) { return gel(bnf,2); }
    1515             : INLINE GEN
    1516     2296163 : bnf_get_C(GEN bnf) { return gel(bnf,4); }
    1517             : INLINE GEN
    1518     1133353 : bnf_get_vbase(GEN bnf) { return gel(bnf,5); }
    1519             : INLINE GEN
    1520     1133282 : bnf_get_Ur(GEN bnf) { return gmael(bnf,9,1); }
    1521             : INLINE GEN
    1522      232972 : bnf_get_ga(GEN bnf) { return gmael(bnf,9,2); }
    1523             : INLINE GEN
    1524      237220 : bnf_get_GD(GEN bnf) { return gmael(bnf,9,3); }
    1525             : 
    1526             : /* Return y (as an elt of K or a t_MAT representing an elt in Z[K])
    1527             :  * such that x / (y) is smooth and store the exponents of  its factorization
    1528             :  * on g_W and g_B in Wex / Bex; return NULL for y = 1 */
    1529             : static GEN
    1530     1133282 : split_ideal(GEN bnf, GEN x, GEN *pWex, GEN *pBex)
    1531             : {
    1532     1133282 :   GEN L, y, Vbase = bnf_get_vbase(bnf);
    1533     1133282 :   GEN Wex, W  = bnf_get_W(bnf);
    1534     1133282 :   GEN Bex, B  = bnf_get_B(bnf);
    1535             :   long p, j, i, l, nW, nB;
    1536             :   FACT *fact;
    1537             :   FB_t F;
    1538             : 
    1539     1133282 :   L = recover_partFB(&F, Vbase, lg(x)-1);
    1540     1133282 :   fact = (FACT*)stack_malloc((F.KC+1)*sizeof(FACT));
    1541     1133282 :   y = SPLIT(&F, bnf_get_nf(bnf), x, Vbase, fact);
    1542     1133282 :   nW = lg(W)-1; *pWex = Wex = zero_zv(nW);
    1543     1133282 :   nB = lg(B)-1; *pBex = Bex = zero_zv(nB); l = lg(F.FB);
    1544     1133282 :   p = j = 0; /* -Wall */
    1545     1688358 :   for (i = 1; i <= fact[0].pr; i++)
    1546             :   { /* decode index C = ip+j --> (p,j) */
    1547      555076 :     long a, b, t, C = fact[i].pr;
    1548     1566261 :     for (t = 1; t < l; t++)
    1549             :     {
    1550     1503375 :       long q = F.FB[t], k = C - F.iLP[q];
    1551     1503375 :       if (k <= 0) break;
    1552     1011185 :       p = q;
    1553     1011185 :       j = k;
    1554             :     }
    1555      555076 :     a = gel(L, p)[j];
    1556      555076 :     b = a - nW;
    1557      555076 :     if (b <= 0) Wex[a] = y? -fact[i].ex: fact[i].ex;
    1558      423496 :     else        Bex[b] = y? -fact[i].ex: fact[i].ex;
    1559             :   }
    1560     1133282 :   return y;
    1561             : }
    1562             : 
    1563             : GEN
    1564      891237 : init_red_mod_units(GEN bnf, long prec)
    1565             : {
    1566      891237 :   GEN s = gen_0, p1,s1,mat, logfu = bnf_get_logfu(bnf);
    1567      891237 :   long i,j, RU = lg(logfu);
    1568             : 
    1569      891237 :   if (RU == 1) return NULL;
    1570      891237 :   mat = cgetg(RU,t_MAT);
    1571     2020915 :   for (j=1; j<RU; j++)
    1572             :   {
    1573     1129678 :     p1 = cgetg(RU+1,t_COL); gel(mat,j) = p1;
    1574     1129678 :     s1 = gen_0;
    1575     2797052 :     for (i=1; i<RU; i++)
    1576             :     {
    1577     1667374 :       gel(p1,i) = real_i(gcoeff(logfu,i,j));
    1578     1667374 :       s1 = mpadd(s1, mpsqr(gel(p1,i)));
    1579             :     }
    1580     1129678 :     gel(p1,RU) = gen_0; if (mpcmp(s1,s) > 0) s = s1;
    1581             :   }
    1582      891237 :   s = gsqrt(gmul2n(s,RU),prec);
    1583      891237 :   if (expo(s) < 27) s = utoipos(1UL << 27);
    1584      891237 :   return mkvec2(mat, s);
    1585             : }
    1586             : 
    1587             : /* z computed above. Return unit exponents that would reduce col (arch) */
    1588             : GEN
    1589      891237 : red_mod_units(GEN col, GEN z)
    1590             : {
    1591             :   long i,RU;
    1592             :   GEN x,mat,N2;
    1593             : 
    1594      891237 :   if (!z) return NULL;
    1595      891237 :   mat= gel(z,1);
    1596      891237 :   N2 = gel(z,2);
    1597      891237 :   RU = lg(mat); x = cgetg(RU+1,t_COL);
    1598     2020915 :   for (i=1; i<RU; i++) gel(x,i) = real_i(gel(col,i));
    1599      891237 :   gel(x,RU) = N2;
    1600      891237 :   x = lll(shallowconcat(mat,x));
    1601      891237 :   if (typ(x) != t_MAT || lg(x) <= RU) return NULL;
    1602      891237 :   x = gel(x,RU);
    1603      891237 :   if (signe(gel(x,RU)) < 0) x = gneg_i(x);
    1604      891237 :   if (!gequal1(gel(x,RU))) pari_err_BUG("red_mod_units");
    1605      891237 :   setlg(x,RU); return x;
    1606             : }
    1607             : 
    1608             : static GEN
    1609     1823866 : add(GEN a, GEN t) { return a = a? RgC_add(a,t): t; }
    1610             : 
    1611             : /* [x] archimedian components, A column vector. return [x] A */
    1612             : static GEN
    1613     1702822 : act_arch(GEN A, GEN x)
    1614             : {
    1615             :   GEN a;
    1616     1702822 :   long i,l = lg(A), tA = typ(A);
    1617     1702822 :   if (tA == t_MAT)
    1618             :   { /* assume lg(x) >= l */
    1619      164355 :     a = cgetg(l, t_MAT);
    1620      241467 :     for (i=1; i<l; i++) gel(a,i) = act_arch(gel(A,i), x);
    1621      164355 :     return a;
    1622             :   }
    1623     1538467 :   if (l==1) return cgetg(1, t_COL);
    1624     1538467 :   a = NULL;
    1625     1538467 :   if (tA == t_VECSMALL)
    1626             :   {
    1627     5856614 :     for (i=1; i<l; i++)
    1628             :     {
    1629     4861203 :       long c = A[i];
    1630     4861203 :       if (c) a = add(a, gmulsg(c, gel(x,i)));
    1631             :     }
    1632             :   }
    1633             :   else
    1634             :   { /* A a t_COL of t_INT. Assume lg(A)==lg(x) */
    1635     1186108 :     for (i=1; i<l; i++)
    1636             :     {
    1637      643052 :       GEN c = gel(A,i);
    1638      643052 :       if (signe(c)) a = add(a, gmul(c, gel(x,i)));
    1639             :     }
    1640             :   }
    1641     1538467 :   return a? a: zerocol(lgcols(x)-1);
    1642             : }
    1643             : /* act_arch(matdiagonal(v), x) */
    1644             : static GEN
    1645       54785 : diagact_arch(GEN v, GEN x)
    1646             : {
    1647       54785 :   long i, l = lg(v);
    1648       54785 :   GEN a = cgetg(l, t_MAT);
    1649       79541 :   for (i = 1; i < l; i++) gel(a,i) = gmul(gel(x,i), gel(v,i));
    1650       54785 :   return a;
    1651             : }
    1652             : 
    1653             : static long
    1654     1148842 : prec_arch(GEN bnf)
    1655             : {
    1656     1148842 :   GEN a = bnf_get_C(bnf);
    1657     1148842 :   long i, l = lg(a), prec;
    1658             : 
    1659     1148842 :   for (i=1; i<l; i++)
    1660     1148770 :     if ( (prec = gprecision(gel(a,i))) ) return prec;
    1661          72 :   return DEFAULTPREC;
    1662             : }
    1663             : 
    1664             : static long
    1665        3289 : needed_bitprec(GEN x)
    1666             : {
    1667        3289 :   long i, e = 0, l = lg(x);
    1668       19243 :   for (i = 1; i < l; i++)
    1669             :   {
    1670       15954 :     GEN c = gel(x,i);
    1671       15954 :     long f = gexpo(c) - gprecision(c);
    1672       15954 :     if (f > e) e = f;
    1673             :   }
    1674        3289 :   return e;
    1675             : }
    1676             : 
    1677             : /* col = archimedian components of x, Nx its norm, dx a multiple of its
    1678             :  * denominator. Return x or NULL (fail) */
    1679             : GEN
    1680     1000221 : isprincipalarch(GEN bnf, GEN col, GEN kNx, GEN e, GEN dx, long *pe)
    1681             : {
    1682             :   GEN nf, x, y, logfu, s, M;
    1683     1000221 :   long N, prec = gprecision(col);
    1684     1000221 :   bnf = checkbnf(bnf); nf = bnf_get_nf(bnf); M = nf_get_M(nf);
    1685     1000221 :   if (!prec) prec = prec_arch(bnf);
    1686     1000221 :   *pe = 128;
    1687     1000221 :   logfu = bnf_get_logfu(bnf);
    1688     1000221 :   N = nf_get_degree(nf);
    1689     1000221 :   if (!(col = cleanarch(col,N,NULL,prec))) return NULL;
    1690     1000221 :   if (lg(col) > 2)
    1691             :   { /* reduce mod units */
    1692      891237 :     GEN u, z = init_red_mod_units(bnf,prec);
    1693      891237 :     if (!(u = red_mod_units(col,z))) return NULL;
    1694      891237 :     col = RgC_add(col, RgM_RgC_mul(logfu, u));
    1695      891237 :     if (!(col = cleanarch(col,N,NULL,prec))) return NULL;
    1696             :   }
    1697     1000221 :   s = divru(mulir(e, glog(kNx,prec)), N);
    1698     1000221 :   col = fixarch(col, s, nf_get_r1(nf));
    1699     1000221 :   if (RgC_expbitprec(col) >= 0) return NULL;
    1700      999729 :   col = gexp(col, prec);
    1701             :   /* d.alpha such that x = alpha \prod gj^ej */
    1702      999729 :   x = RgM_solve_realimag(M,col); if (!x) return NULL;
    1703      999729 :   x = RgC_Rg_mul(x, dx);
    1704      999729 :   y = grndtoi(x, pe);
    1705      999729 :   if (*pe > -5) { *pe = needed_bitprec(x); return NULL; }
    1706      996440 :   return RgC_Rg_div(y, dx);
    1707             : }
    1708             : 
    1709             : /* y = C \prod g[i]^e[i] ? */
    1710             : static int
    1711      992957 : fact_ok(GEN nf, GEN y, GEN C, GEN g, GEN e)
    1712             : {
    1713      992957 :   pari_sp av = avma;
    1714      992957 :   long i, c = lg(e);
    1715      992957 :   GEN z = C? C: gen_1;
    1716     1230443 :   for (i=1; i<c; i++)
    1717      237486 :     if (signe(gel(e,i))) z = idealmul(nf, z, idealpow(nf, gel(g,i), gel(e,i)));
    1718      992957 :   if (typ(z) != t_MAT) z = idealhnf_shallow(nf,z);
    1719      992957 :   if (typ(y) != t_MAT) y = idealhnf_shallow(nf,y);
    1720      992957 :   return gc_bool(av, ZM_equal(y,z));
    1721             : }
    1722             : static GEN
    1723     1133282 : ZV_divrem(GEN A, GEN B, GEN *pR)
    1724             : {
    1725     1133282 :   long i, l = lg(A);
    1726     1133282 :   GEN Q = cgetg(l, t_COL), R = cgetg(l, t_COL);
    1727     1567227 :   for (i = 1; i < l; i++) gel(Q,i) = truedvmdii(gel(A,i), gel(B,i), &gel(R,i));
    1728     1133282 :   *pR = R; return Q;
    1729             : }
    1730             : 
    1731             : static GEN
    1732     1133282 : Ur_ZC_mul(GEN bnf, GEN v)
    1733             : {
    1734     1133282 :   GEN w, U = bnf_get_Ur(bnf);
    1735     1133282 :   long i, l = lg(bnf_get_cyc(bnf)); /* may be < lgcols(U) */
    1736             : 
    1737     1133282 :   w = cgetg(l, t_COL);
    1738     1567227 :   for (i = 1; i < l; i++) gel(w,i) = ZMrow_ZC_mul(U, v, i);
    1739     1133282 :   return w;
    1740             : }
    1741             : 
    1742             : static GEN
    1743        6237 : ZV_mul(GEN x, GEN y)
    1744             : {
    1745        6237 :   long i, l = lg(x);
    1746        6237 :   GEN z = cgetg(l, t_COL);
    1747       27229 :   for (i = 1; i < l; i++) gel(z,i) = mulii(gel(x,i), gel(y,i));
    1748        6237 :   return z;
    1749             : }
    1750             : static int
    1751      992477 : dump_gen(GEN SUnits, GEN x, long flag)
    1752             : {
    1753             :   GEN d;
    1754             :   long e;
    1755      992477 :   if (!(flag & nf_GENMAT) || !SUnits) return 0;
    1756      228245 :   e = gexpo(gel(SUnits,2)); if (e > 64) return 0; /* U large */
    1757      228162 :   x = Q_remove_denom(x, &d);
    1758      228162 :   return (d && expi(d) > 32) || gexpo(x) > 32;
    1759             : }
    1760             : 
    1761             : /* assume x in HNF; cf class_group_gen for notations. Return NULL iff
    1762             :  * flag & nf_FORCE and computation of principal ideal generator fails */
    1763             : static GEN
    1764     1147304 : isprincipalall(GEN bnf, GEN x, long *pprec, long flag)
    1765             : {
    1766             :   GEN xar, Wex, Bex, gen, xc, col, A, Q, R, UA, SUnits;
    1767     1147304 :   GEN C = bnf_get_C(bnf), nf = bnf_get_nf(bnf), cyc = bnf_get_cyc(bnf);
    1768             :   long nB, nW, e;
    1769             : 
    1770     1147304 :   if (lg(cyc) == 1 && !(flag & (nf_GEN|nf_GENMAT|nf_GEN_IF_PRINCIPAL)))
    1771        4056 :     return cgetg(1,t_COL);
    1772     1143248 :   if (lg(x) == 2)
    1773             :   { /* nf = Q */
    1774          72 :     col = gel(x,1);
    1775          72 :     if (flag & nf_GENMAT) col = Q_to_famat(gel(col,1));
    1776          72 :     return (flag & nf_GEN_IF_PRINCIPAL)? col: mkvec2(cgetg(1,t_COL), col);
    1777             :   }
    1778             : 
    1779     1143176 :   x = Q_primitive_part(x, &xc);
    1780     1143176 :   if (equali1(gcoeff(x,1,1))) /* trivial ideal */
    1781             :   {
    1782        9894 :     R = zerocol(lg(cyc)-1);
    1783        9894 :     if (!(flag & (nf_GEN|nf_GENMAT|nf_GEN_IF_PRINCIPAL))) return R;
    1784        9852 :     if (flag & nf_GEN_IF_PRINCIPAL)
    1785        5544 :       return scalarcol_shallow(xc? xc: gen_1, nf_get_degree(nf));
    1786        4308 :     if (flag & nf_GENMAT)
    1787        1878 :       col = xc? Q_to_famat(xc): trivial_fact();
    1788             :     else
    1789        2430 :       col = scalarcol_shallow(xc? xc: gen_1, nf_get_degree(nf));
    1790        4308 :     return mkvec2(R, col);
    1791             :   }
    1792     1133282 :   xar = split_ideal(bnf, x, &Wex, &Bex);
    1793             :   /* x = g_W Wex + g_B Bex + [xar] = g_W (Wex - B*Bex) + [xar] + [C_B]Bex */
    1794     1133282 :   A = zc_to_ZC(Wex); nB = lg(Bex)-1;
    1795     1133282 :   if (nB) A = ZC_sub(A, ZM_zc_mul(bnf_get_B(bnf), Bex));
    1796     1133282 :   UA = Ur_ZC_mul(bnf, A);
    1797     1133282 :   Q = ZV_divrem(UA, cyc, &R);
    1798             :   /* g_W (Wex - B*Bex) = G Ur A - [ga]A = G R + [GD]Q - [ga]A
    1799             :    * Finally: x = G R + [xar] + [C_B]Bex + [GD]Q - [ga]A */
    1800     1133282 :   if (!(flag & (nf_GEN|nf_GENMAT|nf_GEN_IF_PRINCIPAL))) return R;
    1801      995944 :   if ((flag & nf_GEN_IF_PRINCIPAL) && !ZV_equal0(R)) return gen_0;
    1802             : 
    1803      995938 :   nW = lg(Wex)-1;
    1804      995938 :   gen = bnf_get_gen(bnf);
    1805      995938 :   col = NULL;
    1806      995938 :   SUnits = bnf_get_sunits(bnf);
    1807      995938 :   if (lg(R) == 1
    1808      233499 :       || abscmpiu(gel(R,vecindexmax(R)), 4 * (*pprec)) < 0)
    1809             :   { /* q = N (x / prod gj^ej) = N(alpha), denom(alpha) | d */
    1810      995411 :     GEN d, q = gdiv(ZM_det_triangular(x), get_norm_fact(gen, R, &d));
    1811      995411 :     col = xar? nf_cxlog(nf, xar, *pprec): NULL;
    1812      995411 :     if (nB) col = add(col, act_arch(Bex, nW? vecslice(C,nW+1,lg(C)-1): C));
    1813      995411 :     if (nW) col = add(col, RgC_sub(act_arch(Q, bnf_get_GD(bnf)),
    1814             :                                    act_arch(A, bnf_get_ga(bnf))));
    1815      995411 :     col = isprincipalarch(bnf, col, q, gen_1, d, &e);
    1816      995411 :     if (col && (dump_gen(SUnits, col, flag)
    1817      992477 :                 || !fact_ok(nf,x, col,gen,R))) col = NULL;
    1818             :   }
    1819      995938 :   if (!col && (flag & nf_GENMAT))
    1820             :   {
    1821        6872 :     if (SUnits)
    1822             :     {
    1823        6453 :       GEN X = gel(SUnits,1), U = gel(SUnits,2), C = gel(SUnits,3);
    1824        6453 :       GEN v = gel(bnf,9), Ge = gel(v,4), M1 = gel(v,5), M2 = gel(v,6);
    1825        6453 :       GEN z = NULL, F = NULL;
    1826        6453 :       if (nB)
    1827             :       {
    1828        6453 :         GEN C2 = nW? vecslice(C, nW+1, lg(C)-1): C;
    1829        6453 :         z = ZM_zc_mul(C2, Bex);
    1830             :       }
    1831        6453 :       if (nW)
    1832             :       { /* [GD]Q - [ga]A = ([X]M1 - [Ge]D) Q - ([X]M2 - [Ge]Ur) A */
    1833        6237 :         GEN C1 = vecslice(C, 1, nW);
    1834        6237 :         GEN v = ZC_sub(ZM_ZC_mul(M1,Q), ZM_ZC_mul(M2,A));
    1835        6237 :         z = add(z, ZM_ZC_mul(C1, v));
    1836        6237 :         F = famat_reduce(famatV_factorback(Ge, ZC_sub(UA, ZV_mul(cyc,Q))));
    1837        6237 :         if (lgcols(F) == 1) F = NULL;
    1838             :       }
    1839             :       /* reduce modulo units and Q^* */
    1840        6453 :       if (lg(U) != 1) z = ZC_sub(z, ZM_ZC_mul(U, RgM_Babai(U,z)));
    1841        6453 :       col = mkmat2(X, z);
    1842        6453 :       if (F) col = famat_mul_shallow(col, F);
    1843        6453 :       col = famat_remove_trivial(col);
    1844        6453 :       if (xar) col = famat_mul_shallow(col, xar);
    1845             :     }
    1846         419 :     else if (!ZV_equal0(R))
    1847             :     { /* in case isprincipalfact calls bnfinit() due to prec trouble...*/
    1848         414 :       GEN y = isprincipalfact(bnf, x, gen, ZC_neg(R), flag);
    1849         414 :       if (typ(y) != t_VEC) return y;
    1850         414 :       col = gel(y,2);
    1851             :     }
    1852             :   }
    1853      995938 :   if (col)
    1854             :   { /* add back missing content */
    1855      995861 :     if (typ(col) == t_MAT)
    1856        6867 :     { if (xc) col = famat_mul_shallow(col, xc); }
    1857      988994 :     else if (flag & nf_GENMAT)
    1858             :     {
    1859             :       GEN c;
    1860      977252 :       if (RgV_isscalar(col))
    1861        3132 :         col = Q_to_famat(mul_content(xc, gel(col,1)));
    1862             :       else
    1863             :       {
    1864      974120 :         col = Q_primitive_part(col, &c);
    1865      974120 :         col = to_famat_shallow(col, gen_1);
    1866      974120 :         xc = mul_content(xc, c);
    1867      974120 :         if (xc) col = famat_mul(col, Q_to_famat(xc));
    1868             :       }
    1869             :     }
    1870             :     else
    1871       11742 :     { if (xc) col = RgC_Rg_mul(col,xc); }
    1872             :   }
    1873             :   else
    1874             :   {
    1875          77 :     if (e < 0) e = 0;
    1876          77 :     *pprec += nbits2extraprec(e + 128);
    1877          77 :     if (flag & nf_FORCE)
    1878             :     {
    1879          65 :       if (DEBUGLEVEL)
    1880           0 :         pari_warn(warner,"precision too low for generators, e = %ld",e);
    1881          65 :       return NULL;
    1882             :     }
    1883          12 :     pari_warn(warner,"precision too low for generators, not given");
    1884          12 :     col = cgetg(1, t_COL);
    1885             :   }
    1886      995873 :   return (flag & nf_GEN_IF_PRINCIPAL)? col: mkvec2(R, col);
    1887             : }
    1888             : 
    1889             : static GEN
    1890      396762 : triv_gen(GEN bnf, GEN x, long flag)
    1891             : {
    1892      396762 :   pari_sp av = avma;
    1893      396762 :   GEN nf = bnf_get_nf(bnf);
    1894             :   long c;
    1895      396762 :   if (flag & nf_GEN_IF_PRINCIPAL)
    1896             :   {
    1897           6 :     if (!(flag & nf_GENMAT)) return algtobasis(nf,x);
    1898           6 :     x = nf_to_scalar_or_basis(nf,x);
    1899           6 :     if (typ(x) == t_INT && is_pm1(x)) return trivial_fact();
    1900           0 :     return gerepilecopy(av, to_famat_shallow(x, gen_1));
    1901             :   }
    1902      396756 :   c = lg(bnf_get_cyc(bnf)) - 1;
    1903      396756 :   if (flag & nf_GENMAT)
    1904      388524 :     retmkvec2(zerocol(c), to_famat_shallow(algtobasis(nf,x), gen_1));
    1905        8232 :   if (flag & nf_GEN)
    1906          24 :     retmkvec2(zerocol(c), algtobasis(nf,x));
    1907        8208 :   return zerocol(c);
    1908             : }
    1909             : 
    1910             : GEN
    1911     1516436 : bnfisprincipal0(GEN bnf,GEN x,long flag)
    1912             : {
    1913     1516436 :   pari_sp av = avma;
    1914             :   GEN c, nf;
    1915             :   long pr;
    1916             : 
    1917     1516436 :   bnf = checkbnf(bnf);
    1918     1516436 :   nf = bnf_get_nf(bnf);
    1919     1516436 :   switch( idealtyp(&x, NULL) )
    1920             :   {
    1921       49200 :     case id_PRINCIPAL:
    1922       49200 :       if (gequal0(x)) pari_err_DOMAIN("bnfisprincipal","ideal","=",gen_0,x);
    1923       49200 :       return triv_gen(bnf, x, flag);
    1924     1446920 :     case id_PRIME:
    1925     1446920 :       if (pr_is_inert(x)) return triv_gen(bnf, pr_get_p(x), flag);
    1926     1099364 :       x = pr_hnf(nf, x);
    1927     1099364 :       break;
    1928       20316 :     case id_MAT:
    1929       20316 :       if (lg(x)==1) pari_err_DOMAIN("bnfisprincipal","ideal","=",gen_0,x);
    1930       20316 :       if (nf_get_degree(nf) != lg(x)-1)
    1931           0 :         pari_err_TYPE("idealtyp [dimension != degree]", x);
    1932             :   }
    1933     1119680 :   pr = prec_arch(bnf); /* precision of unit matrix */
    1934     1119680 :   c = getrand();
    1935             :   for (;;)
    1936           5 :   {
    1937     1119685 :     pari_sp av1 = avma;
    1938     1119685 :     GEN y = isprincipalall(bnf,x,&pr,flag);
    1939     1119685 :     if (y) return gerepilecopy(av, y);
    1940             : 
    1941           5 :     if (DEBUGLEVEL) pari_warn(warnprec,"isprincipal",pr);
    1942           5 :     set_avma(av1); bnf = bnfnewprec_shallow(bnf,pr); setrand(c);
    1943             :   }
    1944             : }
    1945             : GEN
    1946      149602 : isprincipal(GEN bnf,GEN x) { return bnfisprincipal0(bnf,x,0); }
    1947             : 
    1948             : /* FIXME: OBSOLETE */
    1949             : GEN
    1950           0 : isprincipalgen(GEN bnf,GEN x)
    1951           0 : { return bnfisprincipal0(bnf,x,nf_GEN); }
    1952             : GEN
    1953           0 : isprincipalforce(GEN bnf,GEN x)
    1954           0 : { return bnfisprincipal0(bnf,x,nf_FORCE); }
    1955             : GEN
    1956           0 : isprincipalgenforce(GEN bnf,GEN x)
    1957           0 : { return bnfisprincipal0(bnf,x,nf_GEN | nf_FORCE); }
    1958             : 
    1959             : /* lg(u) > 1 */
    1960             : static int
    1961          90 : RgV_is1(GEN u) { return isint1(gel(u,1)) && RgV_isscalar(u); }
    1962             : static GEN
    1963       27559 : add_principal_part(GEN nf, GEN u, GEN v, long flag)
    1964             : {
    1965       27559 :   if (flag & nf_GENMAT)
    1966       12463 :     return (typ(u) == t_COL && RgV_is1(u))? v: famat_mul_shallow(v,u);
    1967             :   else
    1968       15096 :     return nfmul(nf, v, u);
    1969             : }
    1970             : 
    1971             : #if 0
    1972             : /* compute C prod P[i]^e[i],  e[i] >=0 for all i. C may be NULL (omitted)
    1973             :  * e destroyed ! */
    1974             : static GEN
    1975             : expand(GEN nf, GEN C, GEN P, GEN e)
    1976             : {
    1977             :   long i, l = lg(e), done = 1;
    1978             :   GEN id = C;
    1979             :   for (i=1; i<l; i++)
    1980             :   {
    1981             :     GEN ei = gel(e,i);
    1982             :     if (signe(ei))
    1983             :     {
    1984             :       if (mod2(ei)) id = id? idealmul(nf, id, gel(P,i)): gel(P,i);
    1985             :       ei = shifti(ei,-1);
    1986             :       if (signe(ei)) done = 0;
    1987             :       gel(e,i) = ei;
    1988             :     }
    1989             :   }
    1990             :   if (id != C) id = idealred(nf, id);
    1991             :   if (done) return id;
    1992             :   return idealmulred(nf, id, idealsqr(nf, expand(nf,id,P,e)));
    1993             : }
    1994             : /* C is an extended ideal, possibly with C[1] = NULL */
    1995             : static GEN
    1996             : expandext(GEN nf, GEN C, GEN P, GEN e)
    1997             : {
    1998             :   long i, l = lg(e), done = 1;
    1999             :   GEN A = gel(C,1);
    2000             :   for (i=1; i<l; i++)
    2001             :   {
    2002             :     GEN ei = gel(e,i);
    2003             :     if (signe(ei))
    2004             :     {
    2005             :       if (mod2(ei)) A = A? idealmul(nf, A, gel(P,i)): gel(P,i);
    2006             :       ei = shifti(ei,-1);
    2007             :       if (signe(ei)) done = 0;
    2008             :       gel(e,i) = ei;
    2009             :     }
    2010             :   }
    2011             :   if (A == gel(C,1))
    2012             :     A = C;
    2013             :   else
    2014             :     A = idealred(nf, mkvec2(A, gel(C,2)));
    2015             :   if (done) return A;
    2016             :   return idealmulred(nf, A, idealsqr(nf, expand(nf,A,P,e)));
    2017             : }
    2018             : #endif
    2019             : 
    2020             : static GEN
    2021           0 : expand(GEN nf, GEN C, GEN P, GEN e)
    2022             : {
    2023           0 :   long i, l = lg(e);
    2024           0 :   GEN B, A = C;
    2025           0 :   for (i=1; i<l; i++) /* compute prod P[i]^e[i] */
    2026           0 :     if (signe(gel(e,i)))
    2027             :     {
    2028           0 :       B = idealpowred(nf, gel(P,i), gel(e,i));
    2029           0 :       A = A? idealmulred(nf,A,B): B;
    2030             :     }
    2031           0 :   return A;
    2032             : }
    2033             : static GEN
    2034       27577 : expandext(GEN nf, GEN C, GEN P, GEN e)
    2035             : {
    2036       27577 :   long i, l = lg(e);
    2037       27577 :   GEN B, A = gel(C,1), C1 = A;
    2038       81606 :   for (i=1; i<l; i++) /* compute prod P[i]^e[i] */
    2039       54029 :     if (signe(gel(e,i)))
    2040             :     {
    2041       30169 :       gel(C,1) = gel(P,i);
    2042       30169 :       B = idealpowred(nf, C, gel(e,i));
    2043       30169 :       A = A? idealmulred(nf,A,B): B;
    2044             :     }
    2045       27577 :   return A == C1? C: A;
    2046             : }
    2047             : 
    2048             : /* isprincipal for C * \prod P[i]^e[i] (C omitted if NULL) */
    2049             : GEN
    2050       27577 : isprincipalfact(GEN bnf, GEN C, GEN P, GEN e, long flag)
    2051             : {
    2052       27577 :   const long gen = flag & (nf_GEN|nf_GENMAT|nf_GEN_IF_PRINCIPAL);
    2053             :   long prec;
    2054       27577 :   pari_sp av = avma;
    2055       27577 :   GEN C0, Cext, c, id, nf = bnf_get_nf(bnf);
    2056             : 
    2057       27577 :   if (gen)
    2058             :   {
    2059       12469 :     Cext = (flag & nf_GENMAT)? trivial_fact()
    2060       27577 :                              : mkpolmod(gen_1,nf_get_pol(nf));
    2061       27577 :     C0 = mkvec2(C, Cext);
    2062       27577 :     id = expandext(nf, C0, P, e);
    2063             :   } else {
    2064           0 :     Cext = NULL;
    2065           0 :     C0 = C;
    2066           0 :     id = expand(nf, C, P, e);
    2067             :   }
    2068       27577 :   if (id == C0) /* e = 0 */
    2069             :   {
    2070       10694 :     if (!C) return bnfisprincipal0(bnf, gen_1, flag);
    2071       10682 :     switch(typ(C))
    2072             :     {
    2073           6 :       case t_INT: case t_FRAC: case t_POL: case t_POLMOD: case t_COL:
    2074           6 :         return triv_gen(bnf, C, flag);
    2075             :     }
    2076       10676 :     C = idealhnf_shallow(nf,C);
    2077             :   }
    2078             :   else
    2079             :   {
    2080       16883 :     if (gen) { C = gel(id,1); Cext = gel(id,2); } else C = id;
    2081             :   }
    2082       27559 :   prec = prec_arch(bnf);
    2083       27559 :   c = getrand();
    2084             :   for (;;)
    2085          60 :   {
    2086       27619 :     pari_sp av1 = avma;
    2087       27619 :     GEN y = isprincipalall(bnf, C, &prec, flag);
    2088       27619 :     if (y)
    2089             :     {
    2090       27559 :       if (flag & nf_GEN_IF_PRINCIPAL)
    2091             :       {
    2092       17844 :         if (typ(y) == t_INT) return gc_NULL(av);
    2093       17844 :         y = add_principal_part(nf, y, Cext, flag);
    2094             :       }
    2095             :       else
    2096             :       {
    2097        9715 :         GEN u = gel(y,2);
    2098        9715 :         if (!gen || typ(y) != t_VEC) return gerepileupto(av,y);
    2099        9715 :         if (lg(u) != 1) gel(y,2) = add_principal_part(nf, u, Cext, flag);
    2100             :       }
    2101       27559 :       return gerepilecopy(av, y);
    2102             :     }
    2103          60 :     if (DEBUGLEVEL) pari_warn(warnprec,"isprincipal",prec);
    2104          60 :     set_avma(av1); bnf = bnfnewprec_shallow(bnf,prec); setrand(c);
    2105             :   }
    2106             : }
    2107             : GEN
    2108           0 : isprincipalfact_or_fail(GEN bnf, GEN C, GEN P, GEN e)
    2109             : {
    2110           0 :   const long flag = nf_GENMAT|nf_FORCE;
    2111             :   long prec;
    2112           0 :   pari_sp av = avma;
    2113           0 :   GEN u, y, id, C0, Cext, nf = bnf_get_nf(bnf);
    2114             : 
    2115           0 :   Cext = trivial_fact();
    2116           0 :   C0 = mkvec2(C, Cext);
    2117           0 :   id = expandext(nf, C0, P, e);
    2118           0 :   if (id == C0) /* e = 0 */
    2119           0 :     C = idealhnf_shallow(nf,C);
    2120             :   else {
    2121           0 :     C = gel(id,1); Cext = gel(id,2);
    2122             :   }
    2123           0 :   prec = prec_arch(bnf);
    2124           0 :   y = isprincipalall(bnf, C, &prec, flag);
    2125           0 :   if (!y) return gc_utoipos(av, prec);
    2126           0 :   u = gel(y,2);
    2127           0 :   if (lg(u) != 1) gel(y,2) = add_principal_part(nf, u, Cext, flag);
    2128           0 :   return gerepilecopy(av, y);
    2129             : }
    2130             : 
    2131             : GEN
    2132      127656 : nfsign_from_logarch(GEN LA, GEN invpi, GEN archp)
    2133             : {
    2134      127656 :   long l = lg(archp), i;
    2135      127656 :   GEN y = cgetg(l, t_VECSMALL);
    2136      127656 :   pari_sp av = avma;
    2137             : 
    2138      239712 :   for (i=1; i<l; i++)
    2139             :   {
    2140      112056 :     GEN c = ground( gmul(imag_i(gel(LA,archp[i])), invpi) );
    2141      112056 :     y[i] = mpodd(c)? 1: 0;
    2142             :   }
    2143      127656 :   set_avma(av); return y;
    2144             : }
    2145             : 
    2146             : GEN
    2147      194748 : nfsign_tu(GEN bnf, GEN archp)
    2148             : {
    2149             :   long n;
    2150      194748 :   if (bnf_get_tuN(bnf) != 2) return cgetg(1, t_VECSMALL);
    2151      137226 :   n = archp? lg(archp) - 1: nf_get_r1(bnf_get_nf(bnf));
    2152      137226 :   return const_vecsmall(n, 1);
    2153             : }
    2154             : GEN
    2155      195756 : nfsign_fu(GEN bnf, GEN archp)
    2156             : {
    2157      195756 :   GEN invpi, y, A = bnf_get_logfu(bnf), nf = bnf_get_nf(bnf);
    2158      195756 :   long j = 1, RU = lg(A);
    2159             : 
    2160      195756 :   if (!archp) archp = identity_perm( nf_get_r1(nf) );
    2161      195756 :   invpi = invr( mppi(nf_get_prec(nf)) );
    2162      195756 :   y = cgetg(RU,t_MAT);
    2163      323328 :   for (j = 1; j < RU; j++)
    2164      127572 :     gel(y,j) = nfsign_from_logarch(gel(A,j), invpi, archp);
    2165      195756 :   return y;
    2166             : }
    2167             : GEN
    2168          30 : nfsign_units(GEN bnf, GEN archp, int add_zu)
    2169             : {
    2170          30 :   GEN sfu = nfsign_fu(bnf, archp);
    2171          30 :   return add_zu? vec_prepend(sfu, nfsign_tu(bnf, archp)): sfu;
    2172             : }
    2173             : 
    2174             : /* obsolete */
    2175             : GEN
    2176           6 : signunits(GEN bnf)
    2177             : {
    2178             :   pari_sp av;
    2179             :   GEN S, y, nf;
    2180             :   long i, j, r1, r2;
    2181             : 
    2182           6 :   bnf = checkbnf(bnf); nf = bnf_get_nf(bnf);
    2183           6 :   nf_get_sign(nf, &r1,&r2);
    2184           6 :   S = zeromatcopy(r1, r1+r2-1); av = avma;
    2185           6 :   y = nfsign_fu(bnf, NULL);
    2186          12 :   for (j = 1; j < lg(y); j++)
    2187             :   {
    2188           6 :     GEN Sj = gel(S,j), yj = gel(y,j);
    2189          18 :     for (i = 1; i <= r1; i++) gel(Sj,i) = yj[i]? gen_m1: gen_1;
    2190             :   }
    2191           6 :   set_avma(av); return S;
    2192             : }
    2193             : 
    2194             : static GEN
    2195      618476 : get_log_embed(REL_t *rel, GEN M, long RU, long R1, long prec)
    2196             : {
    2197      618476 :   GEN arch, C, z = rel->m;
    2198             :   long i;
    2199      618476 :   arch = typ(z) == t_COL? RgM_RgC_mul(M, z): const_col(nbrows(M), z);
    2200      618476 :   C = cgetg(RU+1, t_COL); arch = glog(arch, prec);
    2201     1400511 :   for (i=1; i<=R1; i++) gel(C,i) = gel(arch,i);
    2202     1337770 :   for (   ; i<=RU; i++) gel(C,i) = gmul2n(gel(arch,i), 1);
    2203      618476 :   return C;
    2204             : }
    2205             : static GEN
    2206      864198 : rel_embed(REL_t *rel, FB_t *F, GEN embs, long ind, GEN M, long RU, long R1,
    2207             :           long prec)
    2208             : {
    2209             :   GEN C, D, perm;
    2210             :   long i, n;
    2211      864198 :   if (!rel->relaut) return get_log_embed(rel, M, RU, R1, prec);
    2212             :   /* image of another relation by automorphism */
    2213      245722 :   C = gel(embs, ind - rel->relorig);
    2214      245722 :   perm = gel(F->embperm, rel->relaut);
    2215      245722 :   D = cgetg_copy(C, &n);
    2216     1024433 :   for (i = 1; i < n; i++)
    2217             :   {
    2218      778711 :     long v = perm[i];
    2219      778711 :     gel(D,i) = (v > 0)? gel(C,v): conj_i(gel(C,-v));
    2220             :   }
    2221      245722 :   return D;
    2222             : }
    2223             : static GEN
    2224      103902 : get_embs(FB_t *F, RELCACHE_t *cache, GEN nf, GEN embs, long PREC)
    2225             : {
    2226      103902 :   long ru, j, k, l = cache->last - cache->chk + 1, r1 = nf_get_r1(nf);
    2227      103902 :   GEN M = nf_get_M(nf), nembs = cgetg(cache->last - cache->base+1, t_MAT);
    2228             :   REL_t *rel;
    2229             : 
    2230     1269989 :   for (k = 1; k <= cache->chk - cache->base; k++) gel(nembs,k) = gel(embs,k);
    2231      103902 :   embs = nembs; ru = nbrows(M);
    2232      957195 :   for (j=1,rel = cache->chk + 1; j < l; rel++,j++,k++)
    2233      853293 :     gel(embs,k) = rel_embed(rel, F, embs, k, M, ru, r1, PREC);
    2234      103902 :   return embs;
    2235             : }
    2236             : static void
    2237      805176 : set_rel_alpha(REL_t *rel, GEN auts, GEN vA, long ind)
    2238             : {
    2239             :   GEN u;
    2240      805176 :   if (!rel->relaut)
    2241      574268 :     u = rel->m;
    2242             :   else
    2243      230908 :     u = ZM_ZC_mul(gel(auts, rel->relaut), gel(vA, ind - rel->relorig));
    2244      805176 :   gel(vA, ind) = u;
    2245      805176 : }
    2246             : static GEN
    2247     1922166 : set_fact(FB_t *F, FACT *fact, GEN e, long *pnz)
    2248             : {
    2249     1922166 :   long i, n = fact[0].pr, nz = F->KC + 1;
    2250     1922166 :   GEN c = zero_Flv(F->KC);
    2251     9002183 :   for (i = 1; i <= n; i++)
    2252             :   {
    2253     7080017 :     long p = fact[i].pr;
    2254     7080017 :     if (p < nz) nz = p;
    2255     7080017 :     c[p] = fact[i].ex;
    2256             :   }
    2257     1922166 :   if (e)
    2258             :   {
    2259       97809 :     long l = lg(e);
    2260      284849 :     for (i = 1; i < l; i++)
    2261      187040 :       if (e[i]) { long v = F->subFB[i]; c[v] += e[i]; if (v < nz) nz = v; }
    2262             :   }
    2263     1922166 :   *pnz = nz; return c;
    2264             : }
    2265             : 
    2266             : /* Is cols already in the cache ? bs = index of first non zero coeff in cols
    2267             :  * General check for colinearity useless since exceedingly rare */
    2268             : static int
    2269     2475029 : already_known(RELCACHE_t *cache, long bs, GEN cols)
    2270             : {
    2271             :   REL_t *r;
    2272     2475029 :   long l = lg(cols);
    2273   183764888 :   for (r = cache->last; r > cache->base; r--)
    2274   181703788 :     if (bs == r->nz)
    2275             :     {
    2276    29167992 :       GEN coll = r->R;
    2277    29167992 :       long b = bs;
    2278   104262266 :       while (b < l && cols[b] == coll[b]) b++;
    2279    29167992 :       if (b == l) return 1;
    2280             :     }
    2281     2061100 :   return 0;
    2282             : }
    2283             : 
    2284             : /* Add relation R to cache, nz = index of first non zero coeff in R.
    2285             :  * If relation is a linear combination of the previous ones, return 0.
    2286             :  * Otherwise, update basis and return > 0. Compute mod p (much faster)
    2287             :  * so some kernel vector might not be genuine. */
    2288             : static int
    2289     2478586 : add_rel_i(RELCACHE_t *cache, GEN R, long nz, GEN m, long orig, long aut, REL_t **relp, long in_rnd_rel)
    2290             : {
    2291     2478586 :   long i, k, n = lg(R)-1;
    2292             : 
    2293     2478586 :   if (nz == n+1) { k = 0; goto ADD_REL; }
    2294     2475029 :   if (already_known(cache, nz, R)) return -1;
    2295     2061100 :   if (cache->last >= cache->base + cache->len) return 0;
    2296     2061100 :   if (DEBUGLEVEL>6)
    2297             :   {
    2298           0 :     err_printf("adding vector = %Ps\n",R);
    2299           0 :     err_printf("generators =\n%Ps\n", cache->basis);
    2300             :   }
    2301     2061100 :   if (cache->missing)
    2302             :   {
    2303     1724807 :     GEN a = leafcopy(R), basis = cache->basis;
    2304     1724807 :     k = lg(a);
    2305   106460087 :     do --k; while (!a[k]);
    2306     6053452 :     while (k)
    2307             :     {
    2308     4728322 :       GEN c = gel(basis, k);
    2309     4728322 :       if (c[k])
    2310             :       {
    2311     4328645 :         long ak = a[k];
    2312   224665065 :         for (i=1; i < k; i++) if (c[i]) a[i] = (a[i] + ak*(mod_p-c[i])) % mod_p;
    2313     4328645 :         a[k] = 0;
    2314   110344557 :         do --k; while (!a[k]); /* k cannot go below 0: codeword is a sentinel */
    2315             :       }
    2316             :       else
    2317             :       {
    2318      399677 :         ulong invak = Fl_inv(uel(a,k), mod_p);
    2319             :         /* Cleanup a */
    2320    11808727 :         for (i = k; i-- > 1; )
    2321             :         {
    2322    11409050 :           long j, ai = a[i];
    2323    11409050 :           c = gel(basis, i);
    2324    11409050 :           if (!ai || !c[i]) continue;
    2325      202389 :           ai = mod_p-ai;
    2326     3811438 :           for (j = 1; j < i; j++) if (c[j]) a[j] = (a[j] + ai*c[j]) % mod_p;
    2327      202389 :           a[i] = 0;
    2328             :         }
    2329             :         /* Insert a/a[k] as k-th column */
    2330      399677 :         c = gel(basis, k);
    2331    11808727 :         for (i = 1; i<k; i++) if (a[i]) c[i] = (a[i] * invak) % mod_p;
    2332      399677 :         c[k] = 1; a = c;
    2333             :         /* Cleanup above k */
    2334    11638240 :         for (i = k+1; i<n; i++)
    2335             :         {
    2336             :           long j, ck;
    2337    11238563 :           c = gel(basis, i);
    2338    11238563 :           ck = c[k];
    2339    11238563 :           if (!ck) continue;
    2340     2338726 :           ck = mod_p-ck;
    2341    85010032 :           for (j = 1; j < k; j++) if (a[j]) c[j] = (c[j] + ck*a[j]) % mod_p;
    2342     2338726 :           c[k] = 0;
    2343             :         }
    2344      399677 :         cache->missing--;
    2345      399677 :         break;
    2346             :       }
    2347             :     }
    2348             :   }
    2349             :   else
    2350      336293 :     k = (cache->last - cache->base) + 1;
    2351     2061100 :   if (k || cache->relsup > 0 || (m && in_rnd_rel))
    2352             :   {
    2353             :     REL_t *rel;
    2354             : 
    2355      840111 : ADD_REL:
    2356      843668 :     rel = ++cache->last;
    2357      843668 :     if (!k && cache->relsup && nz < n+1)
    2358             :     {
    2359      103860 :       cache->relsup--;
    2360      103860 :       k = (rel - cache->base) + cache->missing;
    2361             :     }
    2362      843668 :     rel->R  = gclone(R);
    2363      843668 :     rel->m  = m ? gclone(m) : NULL;
    2364      843668 :     rel->nz = nz;
    2365      843668 :     if (aut)
    2366             :     {
    2367      243484 :       rel->relorig = (rel - cache->base) - orig;
    2368      243484 :       rel->relaut = aut;
    2369             :     }
    2370             :     else
    2371      600184 :       rel->relaut = 0;
    2372      843668 :     if (relp) *relp = rel;
    2373      843668 :     if (DEBUGLEVEL) dbg_newrel(cache);
    2374             :   }
    2375     2064657 :   return k;
    2376             : }
    2377             : 
    2378             : /* m a t_INT or primitive t_COL */
    2379             : static int
    2380     2069577 : add_rel(RELCACHE_t *cache, FB_t *F, GEN R, long nz, GEN m, long in_rnd_rel)
    2381             : {
    2382             :   REL_t *rel;
    2383             :   long k, l, reln;
    2384     2069577 :   const long lauts = lg(F->idealperm), KC = F->KC;
    2385             : 
    2386     2069577 :   k = add_rel_i(cache, R, nz, m, 0, 0, &rel, in_rnd_rel);
    2387     2069577 :   if (k > 0 && typ(m) != t_INT)
    2388             :   {
    2389      452397 :     GEN Rl = cgetg(KC+1, t_VECSMALL);
    2390      452397 :     reln = rel - cache->base;
    2391      861406 :     for (l = 1; l < lauts; l++)
    2392             :     {
    2393      409009 :       GEN perml = gel(F->idealperm, l);
    2394      409009 :       long i, nzl = perml[nz];
    2395             : 
    2396    17420826 :       for (i = 1; i <= KC; i++) Rl[i] = 0;
    2397    15543131 :       for (i = nz; i <= KC; i++)
    2398    15134122 :         if (R[i])
    2399             :         {
    2400     1087941 :           long v = perml[i];
    2401             : 
    2402     1087941 :           if (v < nzl) nzl = v;
    2403     1087941 :           Rl[v] = R[i];
    2404             :         }
    2405      409009 :       (void)add_rel_i(cache, Rl, nzl, NULL, reln, l, NULL, in_rnd_rel);
    2406             :     }
    2407             :   }
    2408     2069577 :   return k;
    2409             : }
    2410             : 
    2411             : INLINE void
    2412    24005272 : step(GEN x, double *y, GEN inc, long k)
    2413             : {
    2414    24005272 :   if (!y[k])
    2415     1881268 :     x[k]++; /* leading coeff > 0 */
    2416             :   else
    2417             :   {
    2418    22124004 :     long i = inc[k];
    2419    22124004 :     x[k] += i;
    2420    22124004 :     inc[k] = (i > 0)? -1-i: 1-i;
    2421             :   }
    2422    24005272 : }
    2423             : 
    2424             : static double
    2425      226579 : Fincke_Pohst_bound(double T, GEN r)
    2426             : {
    2427      226579 :   pari_sp av = avma;
    2428      226579 :   GEN zT = dbltor(T * T), p = gmael(r,1,1), B = real_1(DEFAULTPREC);
    2429      226579 :   long i, n = lg(r)-1;
    2430             :   double g;
    2431      519333 :   for (i = 2; i <= n; i++)
    2432             :   {
    2433      519333 :     p = gmul(p, gmael(r,i,i));
    2434      519333 :     B = sqrtnr(gmul(zT,p), i);
    2435      519333 :     if (i == n || cmprr(B, gmael(r,i+1,i+1)) < 0) break;
    2436             :   }
    2437      226579 :   if (!gisdouble(B,&g)) return gc_double(av, 0.);
    2438      226579 :   return gc_double(av, rtodbl(B));
    2439             : }
    2440             : 
    2441             : static void
    2442     1689986 : fact_update(GEN R, FB_t *F, long ipr, GEN c)
    2443             : {
    2444     1689986 :   GEN pr = gel(F->LP,ipr), p = pr_get_p(pr);
    2445     1689986 :   long v = Z_lval(c, itou(p));
    2446     1689986 :   if (v) R[ipr] -= pr_get_e(pr) * v;
    2447     1689986 : }
    2448             : 
    2449             : static long
    2450      226579 : Fincke_Pohst_ideal(RELCACHE_t *cache, FB_t *F, GEN nf, GEN I, GEN NI,
    2451             :   FACT *fact, long Nrelid, FP_t *fp, GEN rex, long jid, long jid0, long e0,
    2452             :   long *Nsmall, long *Nfact)
    2453             : {
    2454             :   pari_sp av;
    2455      226579 :   GEN G = nf_get_G(nf), G0 = nf_get_roundG(nf), r, u, gx, cgx, inc, ideal;
    2456      226579 :   long prec = nf_get_prec(nf), N = nf_get_degree(nf);
    2457      226579 :   long j, k, skipfirst, relid = 0, try_factor = 0;
    2458      226579 :   long try_elt = 0, maxtry_ELEMENT = 4*maxtry_FACT*maxtry_FACT;
    2459             :   double BOUND, B1, B2;
    2460             : 
    2461      226579 :   inc = const_vecsmall(N, 1);
    2462      226579 :   u = ZM_lll(ZM_mul(G0, I), 0.99, LLL_IM);
    2463      226579 :   ideal = ZM_mul(I,u); /* approximate T2-LLL reduction */
    2464      226579 :   r = gaussred_from_QR(RgM_mul(G, ideal), prec); /* Cholesky for T2 | ideal */
    2465      226579 :   if (!r) pari_err_BUG("small_norm (precision too low)");
    2466             : 
    2467     1005640 :   for (k=1; k<=N; k++)
    2468             :   {
    2469      779061 :     if (!gisdouble(gcoeff(r,k,k),&(fp->v[k]))) return 0;
    2470     2316151 :     for (j=1; j<k; j++) if (!gisdouble(gcoeff(r,j,k),&(fp->q[j][k]))) return 0;
    2471      779061 :     if (DEBUGLEVEL>3) err_printf("v[%ld]=%.4g ",k,fp->v[k]);
    2472             :   }
    2473      226579 :   B1 = fp->v[1]; /* T2(ideal[1]) */
    2474      226579 :   B2 = fp->v[2] + B1 * fp->q[1][2] * fp->q[1][2]; /* T2(ideal[2]) */
    2475      226579 :   skipfirst = ZV_isscalar(gel(ideal,1));
    2476      226579 :   BOUND = maxdd(2*B2, Fincke_Pohst_bound(4 * maxtry_FACT / F->ballvol, r));
    2477      226579 :   if (DEBUGLEVEL>1)
    2478             :   {
    2479           0 :     if (DEBUGLEVEL>3) err_printf("\n");
    2480           0 :     err_printf("BOUND = %.4g\n",BOUND);
    2481             :   }
    2482             : 
    2483      226579 :   k = N; fp->y[N] = fp->z[N] = 0; fp->x[N] = 0;
    2484    15819173 :   for (av = avma;; set_avma(av), step(fp->x,fp->y,inc,k))
    2485    15592594 :   {
    2486             :     GEN R;
    2487             :     long nz;
    2488             :     do
    2489             :     { /* look for primitive element of small norm, cf minim00 */
    2490    19958204 :       int fl = 0;
    2491             :       double p;
    2492    19958204 :       if (k > 1)
    2493             :       {
    2494     4365610 :         long l = k-1;
    2495     4365610 :         fp->z[l] = 0;
    2496    38934338 :         for (j=k; j<=N; j++) fp->z[l] += fp->q[l][j]*fp->x[j];
    2497     4365610 :         p = (double)fp->x[k] + fp->z[k];
    2498     4365610 :         fp->y[l] = fp->y[k] + p*p*fp->v[k];
    2499     4365610 :         if (l <= skipfirst && !fp->y[1]) fl = 1;
    2500     4365610 :         fp->x[l] = (long)floor(-fp->z[l] + 0.5);
    2501     4365610 :         k = l;
    2502             :       }
    2503     3817640 :       for(;; step(fp->x,fp->y,inc,k))
    2504             :       {
    2505    23775844 :         if (!fl)
    2506             :         {
    2507    23741988 :           if (++try_elt > maxtry_ELEMENT) goto END_Fincke_Pohst_ideal;
    2508    23739924 :           p = (double)fp->x[k] + fp->z[k];
    2509    23739924 :           if (fp->y[k] + p*p*fp->v[k] <= BOUND) break;
    2510             : 
    2511     4595038 :           step(fp->x,fp->y,inc,k);
    2512             : 
    2513     4595038 :           p = (double)fp->x[k] + fp->z[k];
    2514     4595038 :           if (fp->y[k] + p*p*fp->v[k] <= BOUND) break;
    2515             :         }
    2516     3819704 :         fl = 0; inc[k] = 1;
    2517     3819704 :         if (++k > N) goto END_Fincke_Pohst_ideal;
    2518             :       }
    2519    19956140 :     } while (k > 1);
    2520             : 
    2521             :     /* element complete */
    2522    28570926 :     if (zv_content(fp->x) !=1) continue; /* not primitive */
    2523    13223815 :     gx = ZM_zc_mul(ideal,fp->x);
    2524    13223815 :     if (ZV_isscalar(gx)) continue;
    2525    13329744 :     if (++try_factor > maxtry_FACT) break;
    2526             : 
    2527    13189637 :     if (DEBUGLEVEL && Nsmall) (*Nsmall)++;
    2528    13189637 :     if (!factorgen(F,nf,I,NI,gx,fact)) continue;
    2529     2005315 :     if (!Nrelid) return 1;
    2530     1920907 :     if (jid == jid0)
    2531       23614 :       add_to_fact(jid, 1 + e0, fact);
    2532             :     else
    2533             :     {
    2534     1897293 :       add_to_fact(jid, 1, fact);
    2535     1897293 :       if (jid0) add_to_fact(jid0, e0, fact);
    2536             :     }
    2537             : 
    2538             :     /* smooth element */
    2539     1920907 :     R = set_fact(F, fact, rex, &nz);
    2540     1920907 :     cgx = Z_content(gx);
    2541     1920907 :     if (cgx)
    2542             :     { /* relatively rare, compute relation attached to gx/cgx */
    2543      413550 :       long i, n = fact[0].pr;
    2544      413550 :       gx = Q_div_to_int(gx, cgx);
    2545     2061067 :       for (i = 1; i <= n; i++) fact_update(R, F, fact[i].pr, cgx);
    2546      413550 :       if (rex)
    2547             :       {
    2548       28168 :         long l = lg(rex);
    2549       92573 :         for (i = 1; i < l; i++)
    2550       64405 :           if (rex[i])
    2551             :           {
    2552       62746 :             long t, ipr = F->subFB[i];
    2553      201327 :             for (t = 1; t <= n; t++)
    2554      158858 :               if (fact[t].pr == ipr) break;
    2555       62746 :             if (t > n) fact_update(R, F, ipr, cgx);
    2556             :           }
    2557             :       }
    2558             :     }
    2559     1920907 :     if (DEBUGLEVEL && Nfact) (*Nfact)++;
    2560             :     /* make sure we get maximal rank first, then allow all relations */
    2561     1920907 :     if (add_rel(cache, F, R, nz, gx, rex? 1: 0) <= 0)
    2562             :     { /* probably Q-dependent from previous ones: forget it */
    2563     1468889 :       if (DEBUGLEVEL>1) err_printf("*");
    2564     1468889 :       continue;
    2565             :     }
    2566      452018 :     if (cache->last >= cache->end) return 1; /* we have enough */
    2567      367622 :     if (++relid == Nrelid) break;
    2568             :   }
    2569      142171 :   END_Fincke_Pohst_ideal:
    2570      142171 :   return 0;
    2571             : }
    2572             : 
    2573             : static void
    2574       56520 : small_norm(RELCACHE_t *cache, FB_t *F, GEN nf, long Nrelid, FACT *fact, long j0)
    2575             : {
    2576       56520 :   const long N = nf_get_degree(nf);
    2577             :   FP_t fp;
    2578             :   pari_sp av;
    2579       56520 :   GEN L_jid = F->L_jid, Np0 = NULL, p0 = j0? gel(F->LP,j0): NULL;
    2580       56520 :   long Nsmall, Nfact, n = lg(L_jid), e0 = 0;
    2581             :   pari_timer T;
    2582             : 
    2583       56520 :   if (DEBUGLEVEL)
    2584             :   {
    2585           0 :     timer_start(&T);
    2586           0 :     err_printf("#### Look for %ld relations in %ld ideals (small_norm)\n",
    2587           0 :                cache->end - cache->last, lg(L_jid)-1);
    2588           0 :     if (p0) err_printf("Look in p0 = %Ps\n", vecslice(p0,1,4));
    2589             :   }
    2590       56520 :   Nsmall = Nfact = 0;
    2591       56520 :   minim_alloc(N+1, &fp.q, &fp.x, &fp.y, &fp.z, &fp.v);
    2592       56520 :   if (p0)
    2593             :   {
    2594       22351 :     GEN n = pr_norm(p0);
    2595       22351 :     e0 = logint0(sqri(pr_norm(veclast(F->LP))), n, NULL);
    2596       22351 :     p0 = idealpows(nf, p0, e0);
    2597       22351 :     Np0 = powiu(n,e0);
    2598             :   }
    2599      139940 :   for (av = avma; --n; set_avma(av))
    2600             :   {
    2601      139602 :     long j = L_jid[n];
    2602      139602 :     GEN id = gel(F->LP, j), Nid;
    2603      139602 :     if (DEBUGLEVEL>1)
    2604           0 :       err_printf("\n*** Ideal no %ld: %Ps\n", j, vecslice(id,1,4));
    2605      139602 :     if (p0)
    2606             :     {
    2607       27203 :       if (j == j0)
    2608             :       { /* avoid trivial relation */
    2609        3158 :         long e = pr_get_e(id);
    2610        3158 :         if ((e0 + 1) % e == 0 && e * pr_get_f(id) == N) continue;
    2611             :       }
    2612       26647 :       Nid = mulii(Np0, pr_norm(id)); id = idealmul(nf, p0, id);
    2613             :     }
    2614             :     else
    2615      112399 :     { Nid = pr_norm(id); id = pr_hnf(nf, id);}
    2616      139046 :     if (Fincke_Pohst_ideal(cache, F, nf, id, Nid, fact, Nrelid, &fp,
    2617       56182 :                            NULL, j, j0, e0, &Nsmall, &Nfact)) break;
    2618             :   }
    2619       56520 :   if (DEBUGLEVEL && Nsmall)
    2620             :   {
    2621           0 :     if (DEBUGLEVEL == 1)
    2622           0 :     { if (Nfact) err_printf("\n"); }
    2623             :     else
    2624           0 :       err_printf("  \nnb. fact./nb. small norm = %ld/%ld = %.3f\n",
    2625           0 :                   Nfact,Nsmall,((double)Nfact)/Nsmall);
    2626           0 :     if (timer_get(&T)>1) timer_printf(&T,"small_norm");
    2627             :   }
    2628       56520 : }
    2629             : 
    2630             : static GEN
    2631       47349 : get_random_ideal(FB_t *F, GEN nf, GEN ex)
    2632             : {
    2633       47349 :   long i, l = lg(ex);
    2634             :   for (;;)
    2635         932 :   {
    2636       48281 :     GEN I = NULL;
    2637      134730 :     for (i = 1; i < l; i++)
    2638       86449 :       if ((ex[i] = random_bits(RANDOM_BITS)))
    2639             :       {
    2640       82884 :         GEN pr = gel(F->LP, F->subFB[i]), e = utoipos(ex[i]);
    2641       82884 :         I = I? idealmulpowprime(nf, I, pr, e): idealpow(nf, pr, e);
    2642             :       }
    2643       48281 :     if (I && !ZM_isscalar(I,NULL)) return I; /* != (n)Z_K */
    2644             :   }
    2645             : }
    2646             : 
    2647             : static void
    2648       47349 : rnd_rel(RELCACHE_t *cache, FB_t *F, GEN nf, FACT *fact)
    2649             : {
    2650             :   pari_timer T;
    2651       47349 :   GEN L_jid = F->L_jid, R, NR, ex;
    2652       47349 :   long i, l = lg(L_jid), Nfact = 0;
    2653             :   FP_t fp;
    2654             :   pari_sp av;
    2655             : 
    2656       47349 :   if (DEBUGLEVEL) {
    2657           0 :     timer_start(&T);
    2658           0 :     err_printf("#### Look for %ld relations in %ld ideals (rnd_rel)\n",
    2659           0 :                cache->end - cache->last, l-1);
    2660             :   }
    2661       47349 :   ex = cgetg(lg(F->subFB), t_VECSMALL);
    2662       47349 :   R = get_random_ideal(F, nf, ex); /* random product from subFB */
    2663       47349 :   NR = ZM_det_triangular(R);
    2664       47349 :   minim_alloc(nf_get_degree(nf)+1, &fp.q, &fp.x, &fp.y, &fp.z, &fp.v);
    2665      106656 :   for (av = avma, i = 1; i < l; i++, set_avma(av))
    2666             :   { /* try P[j] * base */
    2667       87521 :     long j = L_jid[i];
    2668       87521 :     GEN P = gel(F->LP, j), Nid = mulii(NR, pr_norm(P));
    2669       87521 :     if (DEBUGLEVEL>1) err_printf("\n*** Ideal %ld: %Ps\n", j, vecslice(P,1,4));
    2670       87521 :     if (Fincke_Pohst_ideal(cache, F, nf, idealHNF_mul(nf, R, P), Nid, fact,
    2671       28214 :           RND_REL_RELPID, &fp, ex, j, 0, 0, NULL, &Nfact)) break;
    2672             :   }
    2673       47349 :   if (DEBUGLEVEL)
    2674             :   {
    2675           0 :     if (Nfact) err_printf("\n");
    2676           0 :     if (timer_get(&T)>=0) timer_printf(&T,"rnd_rel");
    2677             :   }
    2678       47349 : }
    2679             : 
    2680             : static GEN
    2681       54702 : automorphism_perms(GEN M, GEN auts, GEN cyclic, long r1, long r2, long N)
    2682             : {
    2683       54702 :   long L = lgcols(M), lauts = lg(auts), lcyc = lg(cyclic), i, j, l, m;
    2684       54702 :   GEN Mt, perms = cgetg(lauts, t_VEC);
    2685             :   pari_sp av;
    2686             : 
    2687      109788 :   for (l = 1; l < lauts; l++) gel(perms, l) = cgetg(L, t_VECSMALL);
    2688       54702 :   av = avma;
    2689       54702 :   Mt = shallowtrans(gprec_w(M, LOWDEFAULTPREC));
    2690       54702 :   Mt = shallowconcat(Mt, conj_i(vecslice(Mt, r1+1, r1+r2)));
    2691       94890 :   for (l = 1; l < lcyc; l++)
    2692             :   {
    2693       40188 :     GEN thiscyc = gel(cyclic, l), thisperm, perm, prev, Nt;
    2694       40188 :     long k = thiscyc[1];
    2695             : 
    2696       40188 :     Nt = RgM_mul(shallowtrans(gel(auts, k)), Mt);
    2697       40188 :     perm = gel(perms, k);
    2698      132168 :     for (i = 1; i < L; i++)
    2699             :     {
    2700       91980 :       GEN v = gel(Nt, i), minD;
    2701       91980 :       minD = gnorml2(gsub(v, gel(Mt, 1)));
    2702       91980 :       perm[i] = 1;
    2703      486114 :       for (j = 2; j <= N; j++)
    2704             :       {
    2705      394134 :         GEN D = gnorml2(gsub(v, gel(Mt, j)));
    2706      394134 :         if (gcmp(D, minD) < 0) { minD = D; perm[i] = j >= L ? r2-j : j; }
    2707             :       }
    2708             :     }
    2709       56142 :     for (prev = perm, m = 2; m < lg(thiscyc); m++, prev = thisperm)
    2710             :     {
    2711       15954 :       thisperm = gel(perms, thiscyc[m]);
    2712       80880 :       for (i = 1; i < L; i++)
    2713             :       {
    2714       64926 :         long pp = labs(prev[i]);
    2715       64926 :         thisperm[i] = prev[i] < 0 ? -perm[pp] : perm[pp];
    2716             :       }
    2717             :     }
    2718             :   }
    2719       54702 :   set_avma(av); return perms;
    2720             : }
    2721             : 
    2722             : /* Determine the field automorphisms as matrices on the integral basis */
    2723             : static GEN
    2724       54756 : automorphism_matrices(GEN nf, GEN *cycp)
    2725             : {
    2726       54756 :   pari_sp av = avma;
    2727       54756 :   GEN auts = galoisconj(nf, NULL), mats, cyclic, cyclicidx;
    2728       54756 :   long nauts = lg(auts)-1, i, j, k, l;
    2729             : 
    2730       54756 :   cyclic = cgetg(nauts+1, t_VEC);
    2731       54756 :   cyclicidx = zero_Flv(nauts);
    2732       84108 :   for (l = 1; l <= nauts; l++)
    2733             :   {
    2734       84108 :     GEN aut = gel(auts, l);
    2735       84108 :     if (gequalX(aut)) { swap(gel(auts, l), gel(auts, nauts)); break; }
    2736             :   }
    2737             :   /* trivial automorphism is last */
    2738      164622 :   for (l = 1; l <= nauts; l++) gel(auts, l) = algtobasis(nf, gel(auts, l));
    2739             :   /* Compute maximal cyclic subgroups */
    2740      109866 :   for (l = nauts; --l > 0; ) if (!cyclicidx[l])
    2741             :   {
    2742       41478 :     GEN elt = gel(auts, l), aut = elt, cyc = cgetg(nauts+1, t_VECSMALL);
    2743       41478 :     cyc[1] = cyclicidx[l] = l; j = 1;
    2744             :     do
    2745             :     {
    2746       57900 :       elt = galoisapply(nf, elt, aut);
    2747      187992 :       for (k = 1; k <= nauts; k++) if (gequal(elt, gel(auts, k))) break;
    2748       57900 :       cyclicidx[k] = l; cyc[++j] = k;
    2749             :     }
    2750       57900 :     while (k != nauts);
    2751       41478 :     setlg(cyc, j);
    2752       41478 :     gel(cyclic, l) = cyc;
    2753             :   }
    2754      109866 :   for (i = j = 1; i < nauts; i++)
    2755       55110 :     if (cyclicidx[i] == i) cyclic[j++] = cyclic[i];
    2756       54756 :   setlg(cyclic, j);
    2757       54756 :   mats = cgetg(nauts, t_VEC);
    2758       94968 :   while (--j > 0)
    2759             :   {
    2760       40212 :     GEN cyc = gel(cyclic, j);
    2761       40212 :     long id = cyc[1];
    2762       40212 :     GEN M, Mi, aut = gel(auts, id);
    2763             : 
    2764       40212 :     gel(mats, id) = Mi = M = nfgaloismatrix(nf, aut);
    2765       56166 :     for (i = 2; i < lg(cyc); i++) gel(mats, cyc[i]) = Mi = ZM_mul(Mi, M);
    2766             :   }
    2767       54756 :   gerepileall(av, 2, &mats, &cyclic);
    2768       54756 :   if (cycp) *cycp = cyclic;
    2769       54756 :   return mats;
    2770             : }
    2771             : 
    2772             : /* vP a list of maximal ideals above the same p from idealprimedec: f(P/p) is
    2773             :  * increasing; 1 <= j <= #vP; orbit a zc of length <= #vP; auts a vector of
    2774             :  * automorphisms in ZM form.
    2775             :  * Set orbit[i] = 1 for all vP[i], i >= j, in the orbit of pr = vP[j] wrt auts.
    2776             :  * N.B.1 orbit need not be initialized to 0: useful to incrementally run
    2777             :  * through successive orbits
    2778             :  * N.B.2 i >= j, so primes with index < j will be missed; run incrementally
    2779             :  * starting from j = 1 ! */
    2780             : static void
    2781       10170 : pr_orbit_fill(GEN orbit, GEN auts, GEN vP, long j)
    2782             : {
    2783       10170 :   GEN pr = gel(vP,j), gen = pr_get_gen(pr);
    2784       10170 :   long i, l = lg(auts), J = lg(orbit), f = pr_get_f(pr);
    2785       10170 :   orbit[j] = 1;
    2786       20340 :   for (i = 1; i < l; i++)
    2787             :   {
    2788       10170 :     GEN g = ZM_ZC_mul(gel(auts,i), gen);
    2789             :     long k;
    2790       10188 :     for (k = j+1; k < J; k++)
    2791             :     {
    2792          30 :       GEN prk = gel(vP,k);
    2793          30 :       if (pr_get_f(prk) > f) break; /* f(P[k]) increases with k */
    2794             :       /* don't check that e matches: (almost) always 1 ! */
    2795          30 :       if (!orbit[k] && ZC_prdvd(g, prk)) { orbit[k] = 1; break; }
    2796             :     }
    2797             :   }
    2798       10170 : }
    2799             : /* remark: F->KCZ changes if be_honest() fails */
    2800             : static int
    2801           6 : be_honest(FB_t *F, GEN nf, GEN auts, FACT *fact)
    2802             : {
    2803             :   long i, iz, nbtest;
    2804           6 :   long lgsub = lg(F->subFB), KCZ0 = F->KCZ, N = nf_get_degree(nf);
    2805             :   FP_t fp;
    2806             :   pari_sp av;
    2807             : 
    2808           6 :   if (DEBUGLEVEL) {
    2809           0 :     err_printf("Be honest for %ld primes from %ld to %ld\n", F->KCZ2 - F->KCZ,
    2810           0 :                F->FB[ F->KCZ+1 ], F->FB[ F->KCZ2 ]);
    2811             :   }
    2812           6 :   minim_alloc(N+1, &fp.q, &fp.x, &fp.y, &fp.z, &fp.v);
    2813           6 :   if (lg(auts) == 1) auts = NULL;
    2814           6 :   av = avma;
    2815          12 :   for (iz=F->KCZ+1; iz<=F->KCZ2; iz++, set_avma(av))
    2816             :   {
    2817           6 :     long p = F->FB[iz];
    2818           6 :     GEN pr_orbit, P = gel(F->LV,p);
    2819           6 :     long j, J = lg(P); /* > 1 */
    2820             :     /* the P|p, NP > C2 are assumed in subgroup generated by FB + last P
    2821             :      * with NP <= C2 is unramified --> check all but last */
    2822           6 :     if (pr_get_e(gel(P,J-1)) == 1) J--;
    2823           6 :     if (J == 1) continue;
    2824           6 :     if (DEBUGLEVEL>1) err_printf("%ld ", p);
    2825           6 :     pr_orbit = auts? zero_zv(J-1): NULL;
    2826          24 :     for (j = 1; j < J; j++)
    2827             :     {
    2828             :       GEN Nid, id, id0;
    2829          18 :       if (pr_orbit)
    2830             :       {
    2831          18 :         if (pr_orbit[j]) continue;
    2832             :         /* discard all primes in automorphism orbit simultaneously */
    2833          12 :         pr_orbit_fill(pr_orbit, auts, P, j);
    2834             :       }
    2835          12 :       id = id0 = pr_hnf(nf,gel(P,j));
    2836          12 :       Nid = pr_norm(gel(P,j));
    2837          12 :       for (nbtest=0;;)
    2838             :       {
    2839          12 :         if (Fincke_Pohst_ideal(NULL, F, nf, id, Nid, fact, 0, &fp,
    2840          12 :                                NULL, 0, 0, 0, NULL, NULL)) break;
    2841           0 :         if (++nbtest > maxtry_HONEST)
    2842             :         {
    2843           0 :           if (DEBUGLEVEL)
    2844           0 :             pari_warn(warner,"be_honest() failure on prime %Ps\n", gel(P,j));
    2845           0 :           return 0;
    2846             :         }
    2847             :         /* occurs at most once in the whole function */
    2848           0 :         for (i = 1, id = id0; i < lgsub; i++)
    2849             :         {
    2850           0 :           long ex = random_bits(RANDOM_BITS);
    2851           0 :           if (ex)
    2852             :           {
    2853           0 :             GEN pr = gel(F->LP, F->subFB[i]);
    2854           0 :             id = idealmulpowprime(nf, id, pr, utoipos(ex));
    2855             :           }
    2856             :         }
    2857           0 :         if (!equali1(gcoeff(id,N,N))) id = Q_primpart(id);
    2858           0 :         if (expi(gcoeff(id,1,1)) > 100) id = idealred(nf, id);
    2859           0 :         Nid = ZM_det_triangular(id);
    2860             :       }
    2861             :     }
    2862           6 :     F->KCZ++; /* SUCCESS, "enlarge" factorbase */
    2863             :   }
    2864           6 :   F->KCZ = KCZ0; return gc_bool(av,1);
    2865             : }
    2866             : 
    2867             : /* all primes with N(P) <= BOUND factor on factorbase ? */
    2868             : void
    2869          54 : bnftestprimes(GEN bnf, GEN BOUND)
    2870             : {
    2871          54 :   pari_sp av0 = avma, av;
    2872          54 :   ulong count = 0;
    2873          54 :   GEN auts, p, nf = bnf_get_nf(bnf), Vbase = bnf_get_vbase(bnf);
    2874          54 :   GEN fb = gen_sort_shallow(Vbase, (void*)&cmp_prime_ideal, cmp_nodata);
    2875          54 :   ulong pmax = pr_get_smallp(veclast(fb)); /*largest p in factorbase*/
    2876             :   forprime_t S;
    2877             :   FACT *fact;
    2878             :   FB_t F;
    2879             : 
    2880          54 :   (void)recover_partFB(&F, Vbase, nf_get_degree(nf));
    2881          54 :   fact = (FACT*)stack_malloc((F.KC+1)*sizeof(FACT));
    2882          54 :   forprime_init(&S, gen_2, BOUND);
    2883          54 :   auts = automorphism_matrices(nf, NULL);
    2884          54 :   if (lg(auts) == 1) auts = NULL;
    2885          54 :   av = avma;
    2886       32232 :   while (( p = forprime_next(&S) ))
    2887             :   {
    2888             :     GEN pr_orbit, vP;
    2889             :     long j, J;
    2890             : 
    2891       32178 :     if (DEBUGLEVEL == 1 && ++count > 1000)
    2892             :     {
    2893           0 :       err_printf("passing p = %Ps / %Ps\n", p, BOUND);
    2894           0 :       count = 0;
    2895             :     }
    2896       32178 :     set_avma(av);
    2897       32178 :     vP = idealprimedec_limit_norm(nf, p, BOUND);
    2898       32178 :     J = lg(vP);
    2899             :     /* if last is unramified, all P|p in subgroup generated by FB: skip last */
    2900       32178 :     if (J > 1 && pr_get_e(gel(vP,J-1)) == 1) J--;
    2901       32178 :     if (J == 1) continue;
    2902       12450 :     if (DEBUGLEVEL>1) err_printf("*** p = %Ps\n",p);
    2903       12450 :     pr_orbit = auts? zero_zv(J-1): NULL;
    2904       27042 :     for (j = 1; j < J; j++)
    2905             :     {
    2906       14592 :       GEN P = gel(vP,j);
    2907       14592 :       long k = 0;
    2908       14592 :       if (pr_orbit)
    2909             :       {
    2910       10164 :         if (pr_orbit[j]) continue;
    2911             :         /* discard all primes in automorphism orbit simultaneously */
    2912       10158 :         pr_orbit_fill(pr_orbit, auts, vP, j);
    2913             :       }
    2914       14586 :       if (abscmpiu(p, pmax) > 0 || !(k = tablesearch(fb, P, &cmp_prime_ideal)))
    2915       14064 :         (void)SPLIT(&F, nf, pr_hnf(nf,P), Vbase, fact);
    2916       14586 :       if (DEBUGLEVEL>1)
    2917             :       {
    2918           0 :         err_printf("  Testing P = %Ps\n",P);
    2919           0 :         if (k) err_printf("    #%ld in factor base\n",k);
    2920           0 :         else err_printf("    is %Ps\n", isprincipal(bnf,P));
    2921             :       }
    2922             :     }
    2923             :   }
    2924          54 :   set_avma(av0);
    2925          54 : }
    2926             : 
    2927             : /* A t_MAT of complex floats, in fact reals. Extract a submatrix B
    2928             :  * whose columns are definitely nonzero, i.e. gexpo(A[j]) >= -2
    2929             :  *
    2930             :  * If possible precision problem (t_REAL 0 with large exponent), set
    2931             :  * *precpb to 1 */
    2932             : static GEN
    2933       78657 : clean_cols(GEN A, int *precpb)
    2934             : {
    2935       78657 :   long l = lg(A), h, i, j, k;
    2936             :   GEN B;
    2937       78657 :   *precpb = 0;
    2938       78657 :   if (l == 1) return A;
    2939       78657 :   h = lgcols(A);;
    2940       78657 :   B = cgetg(l, t_MAT);
    2941      912703 :   for (i = k = 1; i < l; i++)
    2942             :   {
    2943      834046 :     GEN Ai = gel(A,i);
    2944      834046 :     int non0 = 0;
    2945     3614832 :     for (j = 1; j < h; j++)
    2946             :     {
    2947     2780786 :       GEN c = gel(Ai,j);
    2948     2780786 :       if (gexpo(c) >= -2)
    2949             :       {
    2950     1662466 :         if (gequal0(c)) *precpb = 1; else non0 = 1;
    2951             :       }
    2952             :     }
    2953      834046 :     if (non0) gel(B, k++) = Ai;
    2954             :   }
    2955       78657 :   setlg(B, k); return B;
    2956             : }
    2957             : 
    2958             : static long
    2959      476819 : compute_multiple_of_R_pivot(GEN X, GEN x0/*unused*/, long ix, GEN c)
    2960             : {
    2961      476819 :   GEN x = gel(X,ix);
    2962      476819 :   long i, k = 0, ex = - (long)HIGHEXPOBIT, lx = lg(x);
    2963             :   (void)x0;
    2964     2342596 :   for (i=1; i<lx; i++)
    2965     1865777 :     if (!c[i] && !gequal0(gel(x,i)))
    2966             :     {
    2967      601838 :       long e = gexpo(gel(x,i));
    2968      601838 :       if (e > ex) { ex = e; k = i; }
    2969             :     }
    2970      476819 :   return (k && ex > -32)? k: lx;
    2971             : }
    2972             : 
    2973             : /* Ar = (log |sigma_i(u_j)|) for units (u_j) found so far;
    2974             :  * RU = R1+R2 = target rank for unit matrix, after adding [1 x r1, 2 x r2];
    2975             :  * N = field degree, need = unit rank defect;
    2976             :  * L = NULL (prec problem) or B^(-1) * A with approximate rational entries
    2977             :  * (as t_REAL), B a submatrix of A, with (probably) maximal rank RU */
    2978             : static GEN
    2979      103314 : compute_multiple_of_R(GEN Ar, long RU, long N, long *pneed, long *bit, GEN *ptL)
    2980             : {
    2981             :   GEN T, d, mdet, Im_mdet, kR, L;
    2982      103314 :   long i, j, r, R1 = 2*RU - N;
    2983             :   int precpb;
    2984      103314 :   pari_sp av = avma;
    2985             : 
    2986      103314 :   if (RU == 1) { *ptL = zeromat(0, lg(Ar)-1); return gen_1; }
    2987             : 
    2988       78657 :   if (DEBUGLEVEL) err_printf("\n#### Computing regulator multiple\n");
    2989       78657 :   mdet = clean_cols(Ar, &precpb);
    2990             :   /* will cause precision to increase on later failure, but we may succeed! */
    2991       78657 :   *ptL = precpb? NULL: gen_1;
    2992       78657 :   T = cgetg(RU+1,t_COL);
    2993      195944 :   for (i=1; i<=R1; i++) gel(T,i) = gen_1;
    2994      164506 :   for (   ; i<=RU; i++) gel(T,i) = gen_2;
    2995       78657 :   mdet = shallowconcat(T, mdet); /* det(Span(mdet)) = N * R */
    2996             : 
    2997             :   /* could be using indexrank(), but need custom "get_pivot" function */
    2998       78657 :   d = RgM_pivots(mdet, &r, &compute_multiple_of_R_pivot, NULL);
    2999             :   /* # of independent columns = target rank ? */
    3000       78657 :   if (lg(mdet)-1 - r != RU)
    3001             :   {
    3002       21002 :     if (DEBUGLEVEL)
    3003           0 :       err_printf("Units matrix target rank = %ld < %ld\n",lg(mdet)-1 - r, RU);
    3004       21002 :     *pneed = RU - (lg(mdet)-1-r); return gc_NULL(av);
    3005             :   }
    3006             : 
    3007       57655 :   Im_mdet = cgetg(RU+1, t_MAT); /* extract independent columns */
    3008             :   /* N.B: d[1] = 1, corresponding to T above */
    3009       57655 :   gel(Im_mdet, 1) = T;
    3010      215341 :   for (i = j = 2; i <= RU; j++)
    3011      157686 :     if (d[j]) gel(Im_mdet, i++) = gel(mdet,j);
    3012             : 
    3013             :   /* integral multiple of R: the cols we picked form a Q-basis, they have an
    3014             :    * index in the full lattice. First column is T */
    3015       57655 :   kR = divru(det2(Im_mdet), N);
    3016             :   /* R > 0.2 uniformly */
    3017       57655 :   if (!signe(kR) || expo(kR) < -3)
    3018             :   {
    3019           0 :     if (DEBUGLEVEL) err_printf("Regulator is zero.\n");
    3020           0 :     *pneed = 0; return gc_NULL(av);
    3021             :   }
    3022       57655 :   d = det2(rowslice(vecslice(Im_mdet, 2, RU), 2, RU));
    3023       57655 :   setabssign(d); setabssign(kR);
    3024       57655 :   if (gexpo(gsub(d,kR)) - gexpo(d) > -20) { *ptL = NULL; return gc_NULL(av); }
    3025       57654 :   L = RgM_inv(Im_mdet);
    3026             :   /* estimate # of correct bits in result */
    3027       57654 :   if (!L || (*bit = -gexpo(RgM_Rg_sub_shallow(RgM_mul(L,Im_mdet), gen_1))) < 16)
    3028           9 :   { *ptL = NULL; return gc_NULL(av); }
    3029             : 
    3030       57645 :   *ptL = RgM_mul(rowslice(L,2,RU), Ar); /* approximate rational entries */
    3031       57645 :   return gc_all(av,2, &kR, ptL);
    3032             : }
    3033             : 
    3034             : /* leave small integer n as is, convert huge n to t_REAL (for readability) */
    3035             : static GEN
    3036           0 : i2print(GEN n)
    3037           0 : { return lgefint(n) <= DEFAULTPREC? n: itor(n,LOWDEFAULTPREC); }
    3038             : 
    3039             : static long
    3040       82180 : bad_check(GEN c)
    3041             : {
    3042       82180 :   long ec = gexpo(c);
    3043       82180 :   if (DEBUGLEVEL) err_printf("\n ***** check = %.28Pg\n",c);
    3044             :   /* safe check for c < 0.75 : avoid underflow in gtodouble() */
    3045       82180 :   if (ec < -1 || (ec == -1 && gtodouble(c) < 0.75)) return fupb_PRECI;
    3046             :   /* safe check for c > 1.3 : avoid overflow */
    3047       82180 :   if (ec > 0 || (ec == 0 && gtodouble(c) > 1.3)) return fupb_RELAT;
    3048       54708 :   return fupb_NONE;
    3049             : }
    3050             : /* Input:
    3051             :  * lambda = approximate rational entries: coords of units found so far on a
    3052             :  * sublattice of maximal rank (sublambda)
    3053             :  * *ptkR = regulator of sublambda = multiple of regulator of lambda
    3054             :  * Compute R = true regulator of lambda.
    3055             :  *
    3056             :  * If c := Rz ~ 1, by Dirichlet's formula, then lambda is the full group of
    3057             :  * units AND the full set of relations for the class group has been computed.
    3058             :  * In fact z is a very rough approximation and we only expect 0.75 < Rz < 1.3
    3059             :  *
    3060             :  * Output: *ptkR = R, *ptL = numerator(units) (in terms of lambda) */
    3061             : static long
    3062       82233 : compute_R(GEN lambda, GEN z, GEN *ptL, GEN *ptkR)
    3063             : {
    3064       82233 :   pari_sp av = avma;
    3065       82233 :   long bit, r, reason, RU = lg(lambda) == 1? 1: lgcols(lambda);
    3066             :   GEN L, H, D, den, R, c;
    3067             : 
    3068       82233 :   *ptL = NULL;
    3069       82233 :   if (RU == 1) { *ptkR = gen_1; *ptL = lambda; return bad_check(z); }
    3070       57576 :   D = gmul2n(mpmul(*ptkR,z), 1); /* bound for denom(lambda) */
    3071       57576 :   if (expo(D) < 0 && rtodbl(D) < 0.95) return fupb_PRECI;
    3072       57576 :   L = bestappr(lambda,D);
    3073       57576 :   if (lg(L) == 1)
    3074             :   {
    3075           0 :     if (DEBUGLEVEL) err_printf("truncation error in bestappr\n");
    3076           0 :     return fupb_PRECI;
    3077             :   }
    3078       57576 :   den = Q_denom(L);
    3079       57576 :   if (mpcmp(den,D) > 0)
    3080             :   {
    3081          18 :     if (DEBUGLEVEL) err_printf("D = %Ps\nden = %Ps\n",D, i2print(den));
    3082          18 :     return fupb_PRECI;
    3083             :   }
    3084       57558 :   bit = -gexpo(gsub(L, lambda)); /* input accuracy */
    3085       57558 :   L = Q_muli_to_int(L, den);
    3086       57558 :   if (gexpo(L) + expi(den) > bit - 32)
    3087             :   {
    3088          35 :     if (DEBUGLEVEL) err_printf("dubious bestappr; den = %Ps\n", i2print(den));
    3089          35 :     return fupb_PRECI;
    3090             :   }
    3091       57523 :   H = ZM_hnf(L); r = lg(H)-1;
    3092       57523 :   if (!r || r != nbrows(H))
    3093           0 :     R = gen_0; /* wrong rank */
    3094             :   else
    3095       57523 :     R = gmul(*ptkR, gdiv(ZM_det_triangular(H), powiu(den, r)));
    3096             :   /* R = tentative regulator; regulator > 0.2 uniformly */
    3097       57523 :   if (gexpo(R) < -3) {
    3098           0 :     if (DEBUGLEVEL) err_printf("\n#### Tentative regulator: %.28Pg\n", R);
    3099           0 :     return gc_long(av, fupb_PRECI);
    3100             :   }
    3101       57523 :   c = gmul(R,z); /* should be n (= 1 if we are done) */
    3102       57523 :   if (DEBUGLEVEL) err_printf("\n#### Tentative regulator: %.28Pg\n", R);
    3103       57523 :   if ((reason = bad_check(c))) return gc_long(av, reason);
    3104       41646 :   *ptkR = R; *ptL = L; return fupb_NONE;
    3105             : }
    3106             : static GEN
    3107       54785 : get_clg2(GEN cyc, GEN Ga, GEN C, GEN Ur, GEN Ge, GEN M1, GEN M2)
    3108             : {
    3109       54785 :   GEN GD = gsub(act_arch(M1, C), diagact_arch(cyc, Ga));
    3110       54785 :   GEN ga = gsub(act_arch(M2, C), act_arch(Ur, Ga));
    3111       54785 :   return mkvecn(6, Ur, ga, GD, Ge, M1, M2);
    3112             : }
    3113             : /* compute class group (clg1) + data for isprincipal (clg2) */
    3114             : static GEN
    3115       54702 : class_group_gen(GEN nf,GEN W,GEN C,GEN Vbase,long prec, GEN *pclg2)
    3116             : {
    3117             :   GEN M1, M2, z, G, Ga, Ge, cyc, X, Y, D, U, V, Ur, Ui, Uir;
    3118             :   long j, l;
    3119             : 
    3120       54702 :   D = ZM_snfall(W,&U,&V); /* UWV=D, D diagonal, G = g Ui (G=new gens, g=old) */
    3121       54702 :   Ui = ZM_inv(U, NULL);
    3122       54702 :   l = lg(D); cyc = cgetg(l, t_VEC); /* elementary divisors */
    3123       79398 :   for (j = 1; j < l; j++)
    3124             :   {
    3125       26060 :     gel(cyc,j) = gcoeff(D,j,j); /* strip useless components */
    3126       26060 :     if (is_pm1(gel(cyc,j))) break;
    3127             :   }
    3128       54702 :   l = j;
    3129       54702 :   Ur  = ZM_hnfdivrem(U, D, &Y);
    3130       54702 :   Uir = ZM_hnfdivrem(Ui,W, &X);
    3131             :  /* {x} = logarithmic embedding of x (arch. component)
    3132             :   * NB: [J,z] = idealred(I) --> I = y J, with {y} = - z
    3133             :   * G = g Uir - {Ga},  Uir = Ui - WX
    3134             :   * g = G Ur  - {ga},  Ur  = U - DY */
    3135       54702 :   G = cgetg(l,t_VEC);
    3136       54702 :   Ga= cgetg(l,t_MAT);
    3137       54702 :   Ge= cgetg(l,t_COL);
    3138       54702 :   z = init_famat(NULL);
    3139       79398 :   for (j = 1; j < l; j++)
    3140             :   {
    3141       24696 :     GEN I = genback(z, nf, Vbase, gel(Uir,j));
    3142       24696 :     gel(G,j) = gel(I,1); /* generator, order cyc[j] */
    3143       24696 :     gel(Ge,j)= gel(I,2);
    3144       24696 :     gel(Ga,j)= nf_cxlog(nf, gel(I,2), prec);
    3145       24696 :     if (!gel(Ga,j)) pari_err_PREC("class_group_gen");
    3146             :   }
    3147             :   /* {ga} = - {GD}Y + G U - g = - {GD}Y - {Ga} U - gW X U
    3148             :                             = - gW (X Ur + V Y) - {Ga}Ur */
    3149       54702 :   M2 = ZM_neg(ZM_add(ZM_mul(X,Ur), ZM_mul(V,Y)));
    3150       54702 :   setlg(cyc,l); setlg(V,l); setlg(D,l);
    3151             :   /* G D =: {GD} = g (Ui - W X) D - {Ga}D = g W (V - X D) - {Ga}D
    3152             :    * NB: Ui D = W V. gW is given by (first l-1 cols of) C */
    3153       54702 :   M1 = ZM_sub(V, ZM_mul(X,D));
    3154       54702 :   *pclg2 = get_clg2(cyc, Ga, C, Ur, Ge, M1, M2);
    3155       54702 :   return mkvec3(ZV_prod(cyc), cyc, G);
    3156             : }
    3157             : 
    3158             : /* compute principal ideals corresponding to (gen[i]^cyc[i]) */
    3159             : static GEN
    3160        4248 : makecycgen(GEN bnf)
    3161             : {
    3162        4248 :   GEN cyc = bnf_get_cyc(bnf), gen = bnf_get_gen(bnf), nf = bnf_get_nf(bnf);
    3163        4248 :   GEN h, y, GD = bnf_get_GD(bnf), W = bnf_get_W(bnf); /* HNF */
    3164        4248 :   GEN SUnits = bnf_get_sunits(bnf);
    3165        4248 :   GEN X = SUnits? gel(SUnits,1): NULL, C = SUnits? gel(SUnits,3): NULL;
    3166             :   long e, i, l;
    3167             : 
    3168        4248 :   if (DEBUGLEVEL) pari_warn(warner,"completing bnf (building cycgen)");
    3169        4248 :   h = cgetg_copy(gen, &l);
    3170        9954 :   for (i = 1; i < l; i++)
    3171             :   {
    3172        5706 :     GEN gi = gel(gen,i), ci = gel(cyc,i);
    3173        5706 :     if (X && equalii(ci, gcoeff(W,i,i)))
    3174             :     {
    3175             :       long j;
    3176        7362 :       for (j = i+1; j < l; j++)
    3177        2754 :         if (signe(gcoeff(W,i,j))) break;
    3178        4757 :       if (j == i) { gel(h,i) = mkmat2(X, gel(C,i)); continue; }
    3179             :     }
    3180        5706 :     if (abscmpiu(ci, 5) < 0)
    3181             :     {
    3182        4752 :       GEN N = ZM_det_triangular(gi);
    3183        4752 :       y = isprincipalarch(bnf,gel(GD,i), N, ci, gen_1, &e);
    3184        4752 :       if (y && fact_ok(nf,y,NULL,mkvec(gi),mkvec(ci)))
    3185             :       {
    3186        3905 :         gel(h,i) = to_famat_shallow(y,gen_1);
    3187        3905 :         continue;
    3188             :       }
    3189             :     }
    3190        1801 :     y = isprincipalfact(bnf, NULL, mkvec(gi), mkvec(ci), nf_GENMAT|nf_FORCE);
    3191        1801 :     gel(h,i) = gel(y,2);
    3192             :   }
    3193        4248 :   return h;
    3194             : }
    3195             : 
    3196             : static GEN
    3197          58 : get_y(GEN bnf, GEN W, GEN B, GEN C, GEN pFB, long j)
    3198             : {
    3199          58 :   GEN y, nf  = bnf_get_nf(bnf);
    3200          58 :   long e, lW = lg(W)-1;
    3201          58 :   GEN ex = (j<=lW)? gel(W,j): gel(B,j-lW);
    3202          58 :   GEN P = (j<=lW)? NULL: gel(pFB,j);
    3203          58 :   if (C)
    3204             :   { /* archimedean embeddings known: cheap trial */
    3205          58 :     GEN Nx = get_norm_fact_primes(pFB, ex, P);
    3206          58 :     y = isprincipalarch(bnf,gel(C,j), Nx,gen_1, gen_1, &e);
    3207          58 :     if (y && fact_ok(nf,y,P,pFB,ex)) return y;
    3208             :   }
    3209           0 :   y = isprincipalfact_or_fail(bnf, P, pFB, ex);
    3210           0 :   return typ(y) == t_INT? y: gel(y,2);
    3211             : }
    3212             : /* compute principal ideals corresponding to bnf relations */
    3213             : static GEN
    3214          17 : makematal(GEN bnf)
    3215             : {
    3216          17 :   GEN W = bnf_get_W(bnf), B = bnf_get_B(bnf), C = bnf_get_C(bnf);
    3217             :   GEN pFB, ma, retry;
    3218          17 :   long lma, j, prec = 0;
    3219             : 
    3220          17 :   if (DEBUGLEVEL) pari_warn(warner,"completing bnf (building matal)");
    3221          17 :   lma=lg(W)+lg(B)-1;
    3222          17 :   pFB = bnf_get_vbase(bnf);
    3223          17 :   ma = cgetg(lma,t_VEC);
    3224          17 :   retry = vecsmalltrunc_init(lma);
    3225          75 :   for (j=lma-1; j>0; j--)
    3226             :   {
    3227          58 :     pari_sp av = avma;
    3228          58 :     GEN y = get_y(bnf, W, B, C, pFB, j);
    3229          58 :     if (typ(y) == t_INT)
    3230             :     {
    3231           0 :       long E = itos(y);
    3232           0 :       if (DEBUGLEVEL>1) err_printf("\n%ld done later at prec %ld\n",j,E);
    3233           0 :       set_avma(av);
    3234           0 :       vecsmalltrunc_append(retry, j);
    3235           0 :       if (E > prec) prec = E;
    3236             :     }
    3237             :     else
    3238             :     {
    3239          58 :       if (DEBUGLEVEL>1) err_printf("%ld ",j);
    3240          58 :       gel(ma,j) = gerepileupto(av,y);
    3241             :     }
    3242             :   }
    3243          17 :   if (prec)
    3244             :   {
    3245           0 :     long k, l = lg(retry);
    3246           0 :     GEN y, nf = bnf_get_nf(bnf);
    3247           0 :     if (DEBUGLEVEL) pari_warn(warnprec,"makematal",prec);
    3248           0 :     nf = nfnewprec_shallow(nf,prec);
    3249           0 :     bnf = Buchall(nf, nf_FORCE, prec);
    3250           0 :     if (DEBUGLEVEL) err_printf("makematal, adding missing entries:");
    3251           0 :     for (k=1; k<l; k++)
    3252             :     {
    3253           0 :       pari_sp av = avma;
    3254           0 :       long j = retry[k];
    3255           0 :       y = get_y(bnf,W,B,NULL, pFB, j);
    3256           0 :       if (typ(y) == t_INT) pari_err_PREC("makematal");
    3257           0 :       if (DEBUGLEVEL>1) err_printf("%ld ",j);
    3258           0 :       gel(ma,j) = gerepileupto(av,y);
    3259             :     }
    3260             :   }
    3261          17 :   if (DEBUGLEVEL>1) err_printf("\n");
    3262          17 :   return ma;
    3263             : }
    3264             : 
    3265             : enum { MATAL = 1, CYCGEN, UNITS };
    3266             : GEN
    3267       22908 : bnf_build_cycgen(GEN bnf)
    3268       22908 : { return obj_checkbuild(bnf, CYCGEN, &makecycgen); }
    3269             : GEN
    3270          17 : bnf_build_matalpha(GEN bnf)
    3271          17 : { return obj_checkbuild(bnf, MATAL, &makematal); }
    3272             : GEN
    3273       27477 : bnf_build_units(GEN bnf)
    3274       27477 : { return obj_checkbuild(bnf, UNITS, &makeunits); }
    3275             : 
    3276             : /* return fu in compact form if available; in terms of a fixed basis
    3277             :  * of S-units */
    3278             : GEN
    3279          60 : bnf_compactfu_mat(GEN bnf)
    3280             : {
    3281          60 :   GEN X, U, SUnits = bnf_get_sunits(bnf);
    3282          60 :   if (!SUnits) return NULL;
    3283          60 :   X = gel(SUnits,1);
    3284          60 :   U = gel(SUnits,2); ZM_remove_unused(&U, &X);
    3285          60 :   return mkvec2(X, U);
    3286             : }
    3287             : /* return fu in compact form if available; individually as famat */
    3288             : GEN
    3289       31896 : bnf_compactfu(GEN bnf)
    3290             : {
    3291       31896 :   GEN fu, X, U, SUnits = bnf_get_sunits(bnf);
    3292             :   long i, l;
    3293       31896 :   if (!SUnits) return NULL;
    3294       31698 :   X = gel(SUnits,1);
    3295       31698 :   U = gel(SUnits,2); l = lg(U); fu = cgetg(l, t_VEC);
    3296       51738 :   for (i = 1; i < l; i++)
    3297       20040 :     gel(fu,i) = famat_remove_trivial(mkmat2(X, gel(U,i)));
    3298       31698 :   return fu;
    3299             : }
    3300             : /* return expanded fu if available */
    3301             : GEN
    3302      226344 : bnf_has_fu(GEN bnf)
    3303             : {
    3304      226344 :   GEN fu = obj_check(bnf, UNITS);
    3305      226344 :   if (fu) return vecsplice(fu, 1);
    3306      225662 :   fu = bnf_get_fu_nocheck(bnf);
    3307      225662 :   return (typ(fu) == t_MAT)? NULL: fu;
    3308             : }
    3309             : /* return expanded fu if available; build if cheap */
    3310             : GEN
    3311      226104 : bnf_build_cheapfu(GEN bnf)
    3312             : {
    3313             :   GEN fu, SUnits;
    3314      226104 :   if ((fu = bnf_has_fu(bnf))) return fu;
    3315         122 :   if ((SUnits = bnf_get_sunits(bnf)))
    3316             :   {
    3317         122 :     pari_sp av = avma;
    3318         122 :     long e = gexpo(real_i(bnf_get_logfu(bnf)));
    3319         122 :     set_avma(av); if (e < 13) return vecsplice(bnf_build_units(bnf), 1);
    3320             :   }
    3321          66 :   return NULL;
    3322             : }
    3323             : 
    3324             : static GEN
    3325       41723 : get_regulator(GEN A)
    3326             : {
    3327       41723 :   pari_sp av = avma;
    3328             :   GEN R;
    3329             : 
    3330       41723 :   if (lg(A) == 1) return gen_1;
    3331       41717 :   R = det( rowslice(real_i(A), 1, lgcols(A)-2) );
    3332       41717 :   setabssign(R); return gerepileuptoleaf(av, R);
    3333             : }
    3334             : 
    3335             : /* return corrected archimedian components for elts of x (vector)
    3336             :  * (= log(sigma_i(x)) - log(|Nx|) / [K:Q]) */
    3337             : static GEN
    3338          34 : get_archclean(GEN nf, GEN x, long prec, int units)
    3339             : {
    3340          34 :   long k, N, l = lg(x);
    3341          34 :   GEN M = cgetg(l, t_MAT);
    3342             : 
    3343          34 :   if (l == 1) return M;
    3344          22 :   N = nf_get_degree(nf);
    3345          96 :   for (k = 1; k < l; k++)
    3346             :   {
    3347          74 :     pari_sp av = avma;
    3348          74 :     GEN c = nf_cxlog(nf, gel(x,k), prec);
    3349          74 :     if (!c || (!units && !(c = cleanarch(c, N, NULL,prec)))) return NULL;
    3350          74 :     gel(M,k) = gerepilecopy(av, c);
    3351             :   }
    3352          22 :   return M;
    3353             : }
    3354             : static void
    3355          66 : SUnits_archclean(GEN nf, GEN SUnits, GEN *pmun, GEN *pC, long prec)
    3356             : {
    3357          66 :   GEN ipi, M, X = gel(SUnits,1), U = gel(SUnits,2), G = gel(SUnits,3);
    3358          66 :   long k, N = nf_get_degree(nf), l = lg(X);
    3359             : 
    3360          66 :   M = cgetg(l, t_MAT);
    3361        3120 :   for (k = 1; k < l; k++)
    3362        3054 :     if (!(gel(M,k) = nf_cxlog(nf, gel(X,k), prec))) return;
    3363          66 :   ipi = invr(mppi(prec));
    3364          66 :   *pmun = cleanarch(RgM_ZM_mul(M, U), N, ipi, prec); /* not cleanarchunit ! */
    3365          66 :   if (*pmun) *pC = cleanarch(RgM_ZM_mul(M, G), N, ipi, prec);
    3366             : }
    3367             : 
    3368             : GEN
    3369          83 : bnfnewprec_shallow(GEN bnf, long prec)
    3370             : {
    3371          83 :   GEN nf0 = bnf_get_nf(bnf), nf, v, fu, matal, y, A, C;
    3372          83 :   GEN SUnits = bnf_get_sunits(bnf), Ur, Ga, Ge, M1, M2;
    3373          83 :   long r1, r2, prec0 = prec;
    3374             : 
    3375          83 :   nf_get_sign(nf0, &r1, &r2);
    3376          83 :   if (SUnits)
    3377             :   {
    3378          66 :     fu = matal = NULL;
    3379          66 :     prec += nbits2extraprec(gexpo(SUnits));
    3380             :   }
    3381             :   else
    3382             :   {
    3383          17 :     fu = bnf_build_units(bnf);
    3384          17 :     fu = vecslice(fu, 2, lg(fu)-1);
    3385          17 :     if (r1 + r2 > 1) {
    3386          11 :       long e = gexpo(bnf_get_logfu(bnf)) + 1 - TWOPOTBITS_IN_LONG;
    3387          11 :       if (e >= 0) prec += nbits2extraprec(e);
    3388             :     }
    3389          17 :     matal = bnf_build_matalpha(bnf);
    3390             :   }
    3391             : 
    3392          83 :   if (DEBUGLEVEL && prec0 != prec) pari_warn(warnprec,"bnfnewprec",prec);
    3393          83 :   for(C = NULL;;)
    3394           0 :   {
    3395          83 :     pari_sp av = avma;
    3396          83 :     nf = nfnewprec_shallow(nf0,prec);
    3397          83 :     if (SUnits)
    3398          66 :       SUnits_archclean(nf, SUnits, &A, &C, prec);
    3399             :     else
    3400             :     {
    3401          17 :       A = get_archclean(nf, fu, prec, 1);
    3402          17 :       if (A) C = get_archclean(nf, matal, prec, 0);
    3403             :     }
    3404          83 :     if (C) break;
    3405           0 :     set_avma(av); prec = precdbl(prec);
    3406           0 :     if (DEBUGLEVEL) pari_warn(warnprec,"bnfnewprec(extra)",prec);
    3407             :   }
    3408          83 :   y = leafcopy(bnf);
    3409          83 :   gel(y,3) = A;
    3410          83 :   gel(y,4) = C;
    3411          83 :   gel(y,7) = nf;
    3412          83 :   gel(y,8) = v = leafcopy(gel(bnf,8));
    3413          83 :   gel(v,2) = get_regulator(A);
    3414          83 :   v = gel(bnf,9);
    3415          83 :   if (lg(v) < 7) pari_err_TYPE("bnfnewprec [obsolete bnf format]", bnf);
    3416          83 :   Ur = gel(v,1);
    3417          83 :   Ge = gel(v,4);
    3418          83 :   Ga = nfV_cxlog(nf, Ge, prec);
    3419          83 :   M1 = gel(v,5);
    3420          83 :   M2 = gel(v,6);
    3421          83 :   gel(y,9) = get_clg2(bnf_get_cyc(bnf), Ga, C, Ur, Ge, M1, M2);
    3422          83 :   return y;
    3423             : }
    3424             : GEN
    3425           6 : bnfnewprec(GEN bnf, long prec)
    3426             : {
    3427           6 :   pari_sp av = avma;
    3428           6 :   return gerepilecopy(av, bnfnewprec_shallow(checkbnf(bnf), prec));
    3429             : }
    3430             : 
    3431             : GEN
    3432           0 : bnrnewprec_shallow(GEN bnr, long prec)
    3433             : {
    3434           0 :   GEN y = cgetg(7,t_VEC);
    3435             :   long i;
    3436           0 :   gel(y,1) = bnfnewprec_shallow(bnr_get_bnf(bnr), prec);
    3437           0 :   for (i=2; i<7; i++) gel(y,i) = gel(bnr,i);
    3438           0 :   return y;
    3439             : }
    3440             : GEN
    3441           6 : bnrnewprec(GEN bnr, long prec)
    3442             : {
    3443           6 :   GEN y = cgetg(7,t_VEC);
    3444             :   long i;
    3445           6 :   checkbnr(bnr);
    3446           6 :   gel(y,1) = bnfnewprec(bnr_get_bnf(bnr), prec);
    3447          36 :   for (i=2; i<7; i++) gel(y,i) = gcopy(gel(bnr,i));
    3448           6 :   return y;
    3449             : }
    3450             : 
    3451             : static GEN
    3452       55722 : buchall_end(GEN nf,GEN res, GEN clg2, GEN W, GEN B, GEN A, GEN C,GEN Vbase)
    3453             : {
    3454       55722 :   GEN z = obj_init(9, 3);
    3455       55722 :   gel(z,1) = W;
    3456       55722 :   gel(z,2) = B;
    3457       55722 :   gel(z,3) = A;
    3458       55722 :   gel(z,4) = C;
    3459       55722 :   gel(z,5) = Vbase;
    3460       55722 :   gel(z,6) = gen_0;
    3461       55722 :   gel(z,7) = nf;
    3462       55722 :   gel(z,8) = res;
    3463       55722 :   gel(z,9) = clg2;
    3464       55722 :   return z;
    3465             : }
    3466             : 
    3467             : GEN
    3468        2238 : bnfinit0(GEN P, long flag, GEN data, long prec)
    3469             : {
    3470        2238 :   double c1 = 0., c2 = 0.;
    3471        2238 :   long fl, relpid = BNF_RELPID;
    3472             : 
    3473        2238 :   if (data)
    3474             :   {
    3475          18 :     long lx = lg(data);
    3476          18 :     if (typ(data) != t_VEC || lx > 5) pari_err_TYPE("bnfinit",data);
    3477          18 :     switch(lx)
    3478             :     {
    3479           0 :       case 4: relpid = itos(gel(data,3));
    3480          12 :       case 3: c2 = gtodouble(gel(data,2));
    3481          18 :       case 2: c1 = gtodouble(gel(data,1));
    3482             :     }
    3483             :   }
    3484        2238 :   switch(flag)
    3485             :   {
    3486        1512 :     case 2:
    3487        1512 :     case 0: fl = 0; break;
    3488         726 :     case 1: fl = nf_FORCE; break;
    3489           0 :     default: pari_err_FLAG("bnfinit");
    3490             :       return NULL; /* LCOV_EXCL_LINE */
    3491             :   }
    3492        2238 :   return Buchall_param(P, c1, c2, relpid, fl, prec);
    3493             : }
    3494             : GEN
    3495       53496 : Buchall(GEN P, long flag, long prec)
    3496       53496 : { return Buchall_param(P, 0., 0., BNF_RELPID, flag & nf_FORCE, prec); }
    3497             : 
    3498             : static GEN
    3499        1020 : Buchall_deg1(GEN nf)
    3500             : {
    3501        1020 :   GEN v = cgetg(1,t_VEC), m = cgetg(1,t_MAT);
    3502        1020 :   GEN res, W, A, B, C, Vbase = cgetg(1,t_COL);
    3503        1020 :   GEN fu = v, R = gen_1, zu = mkvec2(gen_2, gen_m1);
    3504        1020 :   GEN clg1 = mkvec3(gen_1,v,v), clg2 = mkvecn(6, m,m,m,v,m,m);
    3505             : 
    3506        1020 :   W = A = B = C = m; res = mkvec5(clg1, R, gen_1, zu, fu);
    3507        1020 :   return buchall_end(nf,res,clg2,W,B,A,C,Vbase);
    3508             : }
    3509             : 
    3510             : /* return (small set of) indices of columns generating the same lattice as x.
    3511             :  * Assume HNF(x) is inexpensive (few rows, many columns).
    3512             :  * Dichotomy approach since interesting columns may be at the very end */
    3513             : GEN
    3514       54708 : extract_full_lattice(GEN x)
    3515             : {
    3516       54708 :   long dj, j, k, l = lg(x);
    3517             :   GEN h, h2, H, v;
    3518             : 
    3519       54708 :   if (l < 200) return NULL; /* not worth it */
    3520             : 
    3521           0 :   v = vecsmalltrunc_init(l);
    3522           0 :   H = ZM_hnf(x);
    3523           0 :   h = cgetg(1, t_MAT);
    3524           0 :   dj = 1;
    3525           0 :   for (j = 1; j < l; )
    3526             :   {
    3527           0 :     pari_sp av = avma;
    3528           0 :     long lv = lg(v);
    3529             : 
    3530           0 :     for (k = 0; k < dj; k++) v[lv+k] = j+k;
    3531           0 :     setlg(v, lv + dj);
    3532           0 :     h2 = ZM_hnf(vecpermute(x, v));
    3533           0 :     if (ZM_equal(h, h2))
    3534             :     { /* these dj columns can be eliminated */
    3535           0 :       set_avma(av); setlg(v, lv);
    3536           0 :       j += dj;
    3537           0 :       if (j >= l) break;
    3538           0 :       dj <<= 1;
    3539           0 :       if (j + dj >= l) { dj = (l - j) >> 1; if (!dj) dj = 1; }
    3540             :     }
    3541           0 :     else if (dj > 1)
    3542             :     { /* at least one interesting column, try with first half of this set */
    3543           0 :       set_avma(av); setlg(v, lv);
    3544           0 :       dj >>= 1; /* > 0 */
    3545             :     }
    3546             :     else
    3547             :     { /* this column should be kept */
    3548           0 :       if (ZM_equal(h2, H)) break;
    3549           0 :       h = h2; j++;
    3550             :     }
    3551             :   }
    3552           0 :   return v;
    3553             : }
    3554             : 
    3555             : static void
    3556       54767 : init_rel(RELCACHE_t *cache, FB_t *F, long add_need)
    3557             : {
    3558       54767 :   const long n = F->KC + add_need; /* expected # of needed relations */
    3559             :   long i, j, k, p;
    3560             :   GEN c, P;
    3561             :   GEN R;
    3562             : 
    3563       54767 :   if (DEBUGLEVEL) err_printf("KCZ = %ld, KC = %ld, n = %ld\n", F->KCZ,F->KC,n);
    3564       54767 :   reallocate(cache, 10*n + 50); /* make room for lots of relations */
    3565       54767 :   cache->chk = cache->base;
    3566       54767 :   cache->end = cache->base + n;
    3567       54767 :   cache->relsup = add_need;
    3568       54767 :   cache->last = cache->base;
    3569       54767 :   cache->missing = lg(cache->basis) - 1;
    3570      260845 :   for (i = 1; i <= F->KCZ; i++)
    3571             :   { /* trivial relations (p) = prod P^e */
    3572      206078 :     p = F->FB[i]; P = gel(F->LV,p);
    3573      206078 :     if (!isclone(P)) continue;
    3574             : 
    3575             :     /* all prime divisors in FB */
    3576      143949 :     c = zero_Flv(F->KC); k = F->iLP[p];
    3577      143949 :     R = c; c += k;
    3578      459454 :     for (j = lg(P)-1; j; j--) c[j] = pr_get_e(gel(P,j));
    3579      143949 :     add_rel(cache, F, R, k+1, pr_get_p(gel(P,1)), 0);
    3580             :   }
    3581       54767 : }
    3582             : 
    3583             : /* Let z = \zeta_n in nf. List of not-obviously-dependent generators for
    3584             :  * cyclotomic units modulo torsion in Q(z) [independent when n a prime power]:
    3585             :  * - z^a - 1,  n/(a,n) not a prime power, a \nmid n unless a=1,  1 <= a < n/2
    3586             :  * - (Z^a - 1)/(Z - 1),  p^k || n, Z = z^{n/p^k}, (p,a) = 1, 1 < a <= (p^k-1)/2
    3587             :  */
    3588             : GEN
    3589       54767 : nfcyclotomicunits(GEN nf, GEN zu)
    3590             : {
    3591       54767 :   long n = itos(gel(zu, 1)), n2, lP, i, a;
    3592             :   GEN z, fa, P, E, L, mz, powz;
    3593       54767 :   if (n <= 6) return cgetg(1, t_VEC);
    3594             : 
    3595        1638 :   z = algtobasis(nf,gel(zu, 2));
    3596        1638 :   if ((n & 3) == 2) { n = n >> 1; z = ZC_neg(z); } /* ensure n != 2 (mod 4) */
    3597        1638 :   n2 = n/2;
    3598        1638 :   mz = zk_multable(nf, z); /* multiplication by z */
    3599        1638 :   powz = cgetg(n2, t_VEC); gel(powz,1) = z;
    3600        5388 :   for (i = 2; i < n2; i++) gel(powz,i) = ZM_ZC_mul(mz, gel(powz,i-1));
    3601             :   /* powz[i] = z^i */
    3602             : 
    3603        1638 :   L = vectrunc_init(n);
    3604        1638 :   fa = factoru(n);
    3605        1638 :   P = gel(fa,1); lP = lg(P);
    3606        1638 :   E = gel(fa,2);
    3607        3954 :   for (i = 1; i < lP; i++)
    3608             :   { /* second kind */
    3609        2316 :     long p = P[i], k = E[i], pk = upowuu(p,k), pk2 = (pk-1) / 2;
    3610        2316 :     GEN u = gen_1;
    3611        4260 :     for (a = 2; a <= pk2; a++)
    3612             :     {
    3613        1944 :       u = nfadd(nf, u, gel(powz, (n/pk) * (a-1))); /* = (Z^a-1)/(Z-1) */
    3614        1944 :       if (a % p) vectrunc_append(L, u);
    3615             :     }
    3616             :   }
    3617        5280 :   if (lP > 2) for (a = 1; a < n2; a++)
    3618             :   { /* first kind, when n not a prime power */
    3619             :     ulong p;
    3620        3642 :     if (a > 1 && (n % a == 0 || uisprimepower(n/ugcd(a,n), &p))) continue;
    3621        1602 :     vectrunc_append(L, nfadd(nf, gel(powz, a), gen_m1));
    3622             :   }
    3623        1638 :   return L;
    3624             : }
    3625             : static void
    3626       54767 : add_cyclotomic_units(GEN nf, GEN zu, RELCACHE_t *cache, FB_t *F)
    3627             : {
    3628       54767 :   pari_sp av = avma;
    3629       54767 :   GEN L = nfcyclotomicunits(nf, zu);
    3630       54767 :   long i, l = lg(L);
    3631       54767 :   if (l > 1)
    3632             :   {
    3633        1638 :     GEN R = zero_Flv(F->KC);
    3634        5100 :     for(i = 1; i < l; i++) add_rel(cache, F, R, F->KC+1, gel(L,i), 0);
    3635             :   }
    3636       54767 :   set_avma(av);
    3637       54767 : }
    3638             : 
    3639             : static GEN
    3640      103934 : trim_list(FB_t *F)
    3641             : {
    3642      103934 :   pari_sp av = avma;
    3643      103934 :   GEN v, L_jid = F->L_jid, minidx = F->minidx, present = zero_Flv(F->KC);
    3644      103934 :   long i, j, imax = minss(lg(L_jid), F->KC + 1);
    3645             : 
    3646      103934 :   v = cgetg(imax, t_VECSMALL);
    3647     1126204 :   for (i = j = 1; i < imax; i++)
    3648             :   {
    3649     1022270 :     long k = minidx[ L_jid[i] ];
    3650     1022270 :     if (!present[k]) { v[j++] = L_jid[i]; present[k] = 1; }
    3651             :   }
    3652      103934 :   setlg(v, j); return gerepileuptoleaf(av, v);
    3653             : }
    3654             : 
    3655             : /* x t_INT or primitive ZC */
    3656             : static void
    3657        1455 : try_elt(RELCACHE_t *cache, FB_t *F, GEN nf, GEN x, FACT *fact)
    3658             : {
    3659        1455 :   pari_sp av = avma;
    3660             :   long nz;
    3661             :   GEN R;
    3662             : 
    3663        1455 :   if (typ(x) == t_INT /* 2nd path can't fail */
    3664        1455 :      || !can_factor(F, nf, NULL, x, nfnorm(nf, x), fact)) return;
    3665             :   /* smooth element */
    3666        1259 :   R = set_fact(F, fact, NULL, &nz);
    3667             :   /* make sure we get maximal rank first, then allow all relations */
    3668        1259 :   (void)add_rel(cache, F, R, nz, x, 0);
    3669        1259 :   set_avma(av);
    3670             : }
    3671             : 
    3672             : static void
    3673       46700 : matenlarge(GEN C, long h)
    3674             : {
    3675       46700 :   GEN _0 = zerocol(h);
    3676             :   long i;
    3677     1054013 :   for (i = lg(C); --i; ) gel(C,i) = shallowconcat(gel(C,i), _0);
    3678       46700 : }
    3679             : 
    3680             : /* E = floating point embeddings */
    3681             : static GEN
    3682       46700 : matbotidembs(RELCACHE_t *cache, GEN E)
    3683             : {
    3684       46700 :   long w = cache->last - cache->chk, h = cache->last - cache->base;
    3685       46700 :   long j, d = h - w, hE = nbrows(E);
    3686       46700 :   GEN y = cgetg(w+1,t_MAT), _0 = zerocol(h);
    3687      181908 :   for (j = 1; j <= w; j++)
    3688             :   {
    3689      135208 :     GEN c = shallowconcat(gel(E,j), _0);
    3690      135208 :     if (d + j >= 1) gel(c, d + j + hE) = gen_1;
    3691      135208 :     gel(y,j) = c;
    3692             :   }
    3693       46700 :   return y;
    3694             : }
    3695             : static GEN
    3696       53387 : matbotid(RELCACHE_t *cache)
    3697             : {
    3698       53387 :   long w = cache->last - cache->chk, h = cache->last - cache->base;
    3699       53387 :   long j, d = h - w;
    3700       53387 :   GEN y = cgetg(w+1,t_MAT);
    3701      725563 :   for (j = 1; j <= w; j++)
    3702             :   {
    3703      672176 :     GEN c = zerocol(h);
    3704      672176 :     if (d + j >= 1) gel(c, d + j) = gen_1;
    3705      672176 :     gel(y,j) = c;
    3706             :   }
    3707       53387 :   return y;
    3708             : }
    3709             : 
    3710             : static long
    3711          63 : myprecdbl(long prec, GEN C)
    3712             : {
    3713          63 :   long p = prec < 1280? precdbl(prec): (long)(prec * 1.5);
    3714          63 :   if (C) p = maxss(p, minss(3*p, prec + nbits2extraprec(gexpo(C))));
    3715          63 :   return p;
    3716             : }
    3717             : 
    3718             : static GEN
    3719       49493 : _nfnewprec(GEN nf, long prec, long *isclone)
    3720             : {
    3721       49493 :   GEN NF = gclone(nfnewprec_shallow(nf, prec));
    3722       49493 :   if (*isclone) gunclone(nf);
    3723       49493 :   *isclone = 1; return NF;
    3724             : }
    3725             : 
    3726             : /* Nrelid = nb relations per ideal, possibly 0. If flag is set, keep data in
    3727             :  * algebraic form. */
    3728             : GEN
    3729       55734 : Buchall_param(GEN P, double cbach, double cbach2, long Nrelid, long flag, long prec)
    3730             : {
    3731             :   pari_timer T;
    3732       55734 :   pari_sp av0 = avma, av, av2;
    3733             :   long PREC, N, R1, R2, RU, low, high, LIMC0, LIMC, LIMC2, LIMCMAX, zc, i;
    3734       55734 :   long LIMres, bit = 0, flag_nfinit = 0, nfisclone = 0;
    3735       55734 :   long nreldep, sfb_trials, need, old_need, precdouble = 0, TRIES = 0;
    3736             :   long done_small, small_fail, fail_limit, squash_index;
    3737             :   double LOGD, LOGD2, lim;
    3738       55734 :   GEN computed = NULL, fu = NULL, zu, nf, D, A, W, R, h, Ce, PERM;
    3739             :   GEN small_multiplier, auts, cyclic, embs, SUnits;
    3740             :   GEN res, L, invhr, B, C, lambda, dep, clg1, clg2, Vbase;
    3741       55734 :   const char *precpb = NULL;
    3742       55734 :   REL_t *old_cache = NULL;
    3743             :   nfmaxord_t nfT;
    3744             :   RELCACHE_t cache;
    3745             :   FB_t F;
    3746             :   GRHcheck_t GRHcheck;
    3747             :   FACT *fact;
    3748             : 
    3749       55734 :   if (DEBUGLEVEL) timer_start(&T);
    3750       55734 :   P = get_nfpol(P, &nf);
    3751       55722 :   if (degpol(P)==2) Nrelid = 0;
    3752       55722 :   if (nf)
    3753        3156 :     D = nf_get_disc(nf);
    3754             :   else
    3755             :   {
    3756       52566 :     nfinit_basic(&nfT, P);
    3757       52566 :     D = nfT.dK;
    3758       52566 :     if (!ZX_is_monic(nfT.T0))
    3759             :     {
    3760          12 :       pari_warn(warner,"nonmonic polynomial in bnfinit, using polredbest");
    3761          12 :       flag_nfinit = nf_RED;
    3762             :     }
    3763             :   }
    3764       55722 :   PREC = maxss(DEFAULTPREC, prec);
    3765       55722 :   N = degpol(P);
    3766       55722 :   if (N <= 1)
    3767             :   {
    3768        1020 :     if (!nf) nf = nfinit_complete(&nfT, flag_nfinit, PREC);
    3769        1020 :     return gerepilecopy(av0, Buchall_deg1(nf));
    3770             :   }
    3771       54702 :   D = absi_shallow(D);
    3772       54702 :   LOGD = dbllog2(D) * M_LN2;
    3773       54702 :   LOGD2 = LOGD*LOGD;
    3774       54702 :   LIMCMAX = (long)(4.*LOGD2);
    3775       54702 :   if (nf) PREC = maxss(PREC, nf_get_prec(nf));
    3776       54702 :   PREC = maxss(PREC, nbits2prec((long)(LOGD2 * 0.02) + N*N));
    3777       54702 :   if (DEBUGLEVEL) err_printf("PREC = %ld\n", PREC);
    3778       54702 :   if (!nf)
    3779       51726 :     nf = nfinit_complete(&nfT, flag_nfinit, PREC);
    3780        2976 :   else if (nf_get_prec(nf) < PREC)
    3781         138 :     nf = nfnewprec_shallow(nf, PREC);
    3782       54702 :   zu = nfrootsof1(nf);
    3783       54702 :   gel(zu,2) = nf_to_scalar_or_alg(nf, gel(zu,2));
    3784             : 
    3785       54702 :   nf_get_sign(nf, &R1, &R2); RU = R1+R2;
    3786       54702 :   auts = automorphism_matrices(nf, &cyclic);
    3787       54702 :   F.embperm = automorphism_perms(nf_get_M(nf), auts, cyclic, R1, R2, N);
    3788       54702 :   if (DEBUGLEVEL)
    3789             :   {
    3790           0 :     timer_printf(&T, "nfinit & nfrootsof1");
    3791           0 :     err_printf("%s bnf: R1 = %ld, R2 = %ld\nD = %Ps\n",
    3792             :                flag? "Algebraic": "Floating point", R1,R2, D);
    3793             :   }
    3794       54702 :   if (LOGD < 20.)
    3795             :   { /* tiny disc, Minkowski may be smaller than Bach */
    3796       53460 :     lim = exp(-N + R2 * log(4/M_PI) + LOGD/2) * sqrt(2*M_PI*N);
    3797       53460 :     if (lim < 3) lim = 3;
    3798             :   }
    3799             :   else /* to be ignored */
    3800        1242 :     lim = -1;
    3801       54702 :   if (cbach > 12.) {
    3802           0 :     if (cbach2 < cbach) cbach2 = cbach;
    3803           0 :     cbach = 12.;
    3804             :   }
    3805       54702 :   if (cbach < 0.)
    3806           0 :     pari_err_DOMAIN("Buchall","Bach constant","<",gen_0,dbltor(cbach));
    3807             : 
    3808       54702 :   cache.base = NULL; F.subFB = NULL; F.LP = NULL; SUnits = Ce = NULL;
    3809       54702 :   init_GRHcheck(&GRHcheck, N, R1, LOGD);
    3810       54702 :   high = low = LIMC0 = maxss((long)(cbach2*LOGD2), 1);
    3811      266760 :   while (!GRHchk(nf, &GRHcheck, high)) { low = high; high *= 2; }
    3812      212094 :   while (high - low > 1)
    3813             :   {
    3814      157392 :     long test = (low+high)/2;
    3815      157392 :     if (GRHchk(nf, &GRHcheck, test)) high = test; else low = test;
    3816             :   }
    3817       54702 :   LIMC2 = (high == LIMC0+1 && GRHchk(nf, &GRHcheck, LIMC0))? LIMC0: high;
    3818       54702 :   if (LIMC2 > LIMCMAX) LIMC2 = LIMCMAX;
    3819             :   /* Assuming GRH, {P, NP <= LIMC2} generate Cl(K) */
    3820       54702 :   if (DEBUGLEVEL) err_printf("LIMC2 = %ld\n", LIMC2);
    3821       54702 :   LIMC0 = (long)(cbach*LOGD2); /* initial value for LIMC */
    3822       54702 :   LIMC = cbach? LIMC0: LIMC2; /* use {P, NP <= LIMC} as a factorbase */
    3823       54702 :   LIMC = maxss(LIMC, nthideal(&GRHcheck, nf, N));
    3824       54702 :   if (DEBUGLEVEL) timer_printf(&T, "computing Bach constant");
    3825       54702 :   LIMres = primeneeded(N, R1, R2, LOGD);
    3826       54702 :   cache_prime_dec(&GRHcheck, LIMres, nf);
    3827             :   /* invhr ~ 2^r1 (2pi)^r2 / sqrt(D) w * Res(zeta_K, s=1) = 1 / hR */
    3828      109404 :   invhr = gmul(gdiv(gmul2n(powru(mppi(DEFAULTPREC), R2), RU),
    3829       54702 :               mulri(gsqrt(D,DEFAULTPREC),gel(zu,1))),
    3830             :               compute_invres(&GRHcheck, LIMres));
    3831       54702 :   if (DEBUGLEVEL) timer_printf(&T, "computing inverse of hR");
    3832       54702 :   av = avma;
    3833             : 
    3834       56633 : START:
    3835       56633 :   if (DEBUGLEVEL) timer_start(&T);
    3836       56633 :   if (TRIES) LIMC = bnf_increase_LIMC(LIMC,LIMCMAX);
    3837       56633 :   if (DEBUGLEVEL && LIMC > LIMC0)
    3838           0 :     err_printf("%s*** Bach constant: %f\n", TRIES?"\n":"", LIMC/LOGD2);
    3839       56633 :   if (cache.base)
    3840             :   {
    3841             :     REL_t *rel;
    3842        3252 :     for (i = 1, rel = cache.base + 1; rel < cache.last; rel++)
    3843        3187 :       if (rel->m) i++;
    3844          65 :     computed = cgetg(i, t_VEC);
    3845        3252 :     for (i = 1, rel = cache.base + 1; rel < cache.last; rel++)
    3846        3187 :       if (rel->m) gel(computed, i++) = rel->m;
    3847          65 :     computed = gclone(computed); delete_cache(&cache);
    3848             :   }
    3849       56633 :   TRIES++; set_avma(av);
    3850       56633 :   if (F.LP) delete_FB(&F);
    3851       56633 :   if (LIMC2 < LIMC) LIMC2 = LIMC;
    3852       56633 :   if (DEBUGLEVEL) { err_printf("LIMC = %ld, LIMC2 = %ld\n",LIMC,LIMC2); }
    3853             : 
    3854       56633 :   FBgen(&F, nf, N, LIMC, LIMC2, &GRHcheck);
    3855       56633 :   if (!F.KC) goto START;
    3856       56633 :   av = avma;
    3857       56633 :   subFBgen(&F,auts,cyclic,lim < 0? LIMC2: mindd(lim,LIMC2),MINSFB);
    3858       56633 :   if (lg(F.subFB) == 1) goto START;
    3859       54767 :   if (DEBUGLEVEL)
    3860           0 :     timer_printf(&T, "factorbase (#subFB = %ld) and ideal permutations",
    3861           0 :                      lg(F.subFB)-1);
    3862             : 
    3863       54767 :   fact = (FACT*)stack_malloc((F.KC+1)*sizeof(FACT));
    3864       54767 :   PERM = leafcopy(F.perm); /* to be restored in case of precision increase */
    3865       54767 :   cache.basis = zero_Flm_copy(F.KC,F.KC);
    3866       54767 :   small_multiplier = zero_Flv(F.KC);
    3867       54767 :   done_small = small_fail = squash_index = zc = sfb_trials = nreldep = 0;
    3868       54767 :   fail_limit = F.KC + 1;
    3869       54767 :   W = A = R = NULL;
    3870       54767 :   av2 = avma;
    3871       54767 :   init_rel(&cache, &F, RELSUP + RU-1);
    3872       54767 :   old_need = need = cache.end - cache.last;
    3873       54767 :   add_cyclotomic_units(nf, zu, &cache, &F);
    3874       54767 :   if (DEBUGLEVEL) err_printf("\n");
    3875       54767 :   cache.end = cache.last + need;
    3876             : 
    3877       54767 :   if (computed)
    3878             :   {
    3879        1520 :     for (i = 1; i < lg(computed); i++)
    3880        1455 :       try_elt(&cache, &F, nf, gel(computed, i), fact);
    3881          65 :     gunclone(computed);
    3882          65 :     if (DEBUGLEVEL && i > 1)
    3883           0 :       timer_printf(&T, "including already computed relations");
    3884          65 :     need = 0;
    3885             :   }
    3886             : 
    3887             :   do
    3888             :   {
    3889             :     GEN Ar, C0;
    3890             :     do
    3891             :     {
    3892      104068 :       pari_sp av4 = avma;
    3893      104068 :       if (need > 0)
    3894             :       {
    3895      103934 :         long oneed = cache.end - cache.last;
    3896             :         /* Test below can be true if small_norm did not find enough linearly
    3897             :          * dependent relations */
    3898      103934 :         if (need < oneed) need = oneed;
    3899      103934 :         pre_allocate(&cache, need+lg(auts)-1+(R ? lg(W)-1 : 0));
    3900      103934 :         cache.end = cache.last + need;
    3901      103934 :         F.L_jid = trim_list(&F);
    3902             :       }
    3903      104068 :       if (need > 0 && Nrelid > 0 && (done_small <= F.KC+1 || A) &&
    3904       59220 :           small_fail <= fail_limit &&
    3905       59220 :           cache.last < cache.base + 2*F.KC+2*RU+RELSUP /* heuristic */)
    3906             :       {
    3907       56520 :         long j, k, LIE = (R && lg(W) > 1 && (done_small % 2));
    3908       56520 :         REL_t *last = cache.last;
    3909       56520 :         pari_sp av3 = avma;
    3910       56520 :         if (LIE)
    3911             :         { /* We have full rank for class group and unit. The following tries to
    3912             :            * improve the prime group lattice by looking for relations involving
    3913             :            * the primes generating the class group. */
    3914        2892 :           long n = lg(W)-1; /* need n relations to squash the class group */
    3915        2892 :           F.L_jid = vecslice(F.perm, 1, n);
    3916        2892 :           cache.end = cache.last + n;
    3917             :           /* Lie to the add_rel subsystem: pretend we miss relations involving
    3918             :            * the primes generating the class group (and only those). */
    3919        2892 :           cache.missing = n;
    3920        9028 :           for ( ; n > 0; n--) mael(cache.basis, F.perm[n], F.perm[n]) = 0;
    3921             :         }
    3922       56520 :         j = done_small % (F.KC+1);
    3923       56520 :         if (j && !A)
    3924             :         { /* Prevent considering both P_iP_j and P_jP_i in small_norm */
    3925             :           /* Not all elements end up in F.L_jid (eliminated by hnfspec/add or
    3926             :            * by trim_list): keep track of which ideals are being considered
    3927             :            * at each run. */
    3928         349 :           long mj = small_multiplier[j];
    3929        5450 :           for (i = k = 1; i < lg(F.L_jid); i++)
    3930        5101 :             if (F.L_jid[i] > mj)
    3931             :             {
    3932        5101 :               small_multiplier[F.L_jid[i]] = j;
    3933        5101 :               F.L_jid[k++] = F.L_jid[i];
    3934             :             }
    3935         349 :           setlg(F.L_jid, k);
    3936             :         }
    3937       56520 :         if (lg(F.L_jid) > 1) small_norm(&cache, &F, nf, Nrelid, fact, j);
    3938       56520 :         F.L_jid = F.perm; set_avma(av3);
    3939       56520 :         if (!A && cache.last != last) small_fail = 0; else small_fail++;
    3940       56520 :         if (LIE)
    3941             :         { /* restore add_rel subsystem: undo above lie */
    3942        2892 :           long n = lg(W) - 1;
    3943        9028 :           for ( ; n > 0; n--) mael(cache.basis, F.perm[n], F.perm[n]) = 1;
    3944        2892 :           cache.missing = 0;
    3945             :         }
    3946       56520 :         cache.end = cache.last;
    3947       56520 :         done_small++;
    3948       56520 :         need = F.sfb_chg = 0;
    3949             :       }
    3950      104068 :       if (need > 0)
    3951             :       { /* Random relations */
    3952       47414 :         if (++nreldep > F.MAXDEPSIZESFB) {
    3953          12 :           if (++sfb_trials > SFB_MAX && LIMC < LIMCMAX/2) goto START;
    3954          12 :           F.sfb_chg = sfb_INCREASE;
    3955          12 :           nreldep = 0;
    3956             :         }
    3957       47402 :         else if (!(nreldep % F.MAXDEPSFB))
    3958       22657 :           F.sfb_chg = sfb_CHANGE;
    3959       47414 :         if (F.sfb_chg && !subFB_change(&F)) goto START;
    3960       47349 :         rnd_rel(&cache, &F, nf, fact);
    3961       47349 :         F.L_jid = F.perm;
    3962             :       }
    3963      104003 :       if (DEBUGLEVEL) timer_start(&T);
    3964      104003 :       if (precpb)
    3965             :       {
    3966             :         REL_t *rel;
    3967          69 :         if (DEBUGLEVEL)
    3968             :         {
    3969           0 :           char str[64]; sprintf(str,"Buchall_param (%s)",precpb);
    3970           0 :           pari_warn(warnprec,str,PREC);
    3971             :         }
    3972          69 :         nf = _nfnewprec(nf, PREC, &nfisclone);
    3973          69 :         precdouble++; precpb = NULL;
    3974             : 
    3975          69 :         if (flag)
    3976             :         { /* recompute embs only, no need to redo HNF */
    3977          33 :           long j, le = lg(embs), lC = lg(C);
    3978          33 :           GEN E, M = nf_get_M(nf);
    3979          33 :           set_avma(av4);
    3980       10938 :           for (rel = cache.base+1, i = 1; i < le; i++,rel++)
    3981       10905 :             gel(embs,i) = rel_embed(rel, &F, embs, i, M, RU, R1, PREC);
    3982          33 :           E = RgM_ZM_mul(embs, rowslice(C, RU+1, nbrows(C)));
    3983       10938 :           for (j = 1; j < lC; j++)
    3984       56865 :             for (i = 1; i <= RU; i++) gcoeff(C,i,j) = gcoeff(E,i,j);
    3985          33 :           av4 = avma;
    3986             :         }
    3987             :         else
    3988             :         { /* recompute embs + HNF */
    3989        8844 :           for(i = 1; i < lg(PERM); i++) F.perm[i] = PERM[i];
    3990          36 :           cache.chk = cache.base;
    3991          36 :           W = NULL;
    3992             :         }
    3993          69 :         if (DEBUGLEVEL) timer_printf(&T, "increasing accuracy");
    3994             :       }
    3995      104003 :       set_avma(av4);
    3996      104003 :       if (cache.chk != cache.last)
    3997             :       { /* Reduce relation matrices */
    3998      103902 :         long l = cache.last - cache.chk + 1, j;
    3999      103902 :         GEN mat = cgetg(l, t_MAT);
    4000             :         REL_t *rel;
    4001             : 
    4002      957195 :         for (j=1,rel = cache.chk + 1; j < l; rel++,j++) gel(mat,j) = rel->R;
    4003      103902 :         if (!flag || W)
    4004             :         {
    4005       50515 :           embs = get_embs(&F, &cache, nf, embs, PREC);
    4006       50515 :           if (DEBUGLEVEL && timer_get(&T) > 1)
    4007           0 :             timer_printf(&T, "floating point embeddings");
    4008             :         }
    4009      103902 :         if (!W)
    4010             :         { /* never reduced before */
    4011       54803 :           C = flag? matbotid(&cache): embs;
    4012       54803 :           W = hnfspec_i(mat, F.perm, &dep, &B, &C, F.subFB ? lg(F.subFB)-1:0);
    4013       54803 :           if (DEBUGLEVEL)
    4014           0 :             timer_printf(&T, "hnfspec [%ld x %ld]", lg(F.perm)-1, l-1);
    4015       54803 :           if (flag)
    4016             :           {
    4017       53387 :             PREC += nbits2extraprec(gexpo(C));
    4018       53387 :             if (nf_get_prec(nf) < PREC) nf = _nfnewprec(nf, PREC, &nfisclone);
    4019       53387 :             embs = get_embs(&F, &cache, nf, embs, PREC);
    4020       53387 :             C = vconcat(RgM_ZM_mul(embs, C), C);
    4021             :           }
    4022       54803 :           if (DEBUGLEVEL)
    4023           0 :             timer_printf(&T, "hnfspec floating points");
    4024             :         }
    4025             :         else
    4026             :         {
    4027       49099 :           long k = lg(embs);
    4028       49099 :           GEN E = vecslice(embs, k-l+1,k-1);
    4029       49099 :           if (flag)
    4030             :           {
    4031       46700 :             E = matbotidembs(&cache, E);
    4032       46700 :             matenlarge(C, cache.last - cache.chk);
    4033             :           }
    4034       49099 :           W = hnfadd_i(W, F.perm, &dep, &B, &C, mat, E);
    4035       49099 :           if (DEBUGLEVEL)
    4036           0 :             timer_printf(&T, "hnfadd (%ld + %ld)", l-1, lg(dep)-1);
    4037             :         }
    4038      103902 :         gerepileall(av2, 5, &W,&C,&B,&dep,&embs);
    4039      103902 :         cache.chk = cache.last;
    4040             :       }
    4041         101 :       else if (!W)
    4042             :       {
    4043           0 :         need = old_need;
    4044           0 :         F.L_jid = vecslice(F.perm, 1, need);
    4045           0 :         continue;
    4046             :       }
    4047      104003 :       need = F.KC - (lg(W)-1) - (lg(B)-1);
    4048      104003 :       if (!need && cache.missing)
    4049             :       { /* The test above will never be true except if 27449|class number.
    4050             :          * Ensure that if we have maximal rank for the ideal lattice, then
    4051             :          * cache.missing == 0. */
    4052          12 :         for (i = 1; cache.missing; i++)
    4053           6 :           if (!mael(cache.basis, i, i))
    4054             :           {
    4055             :             long j;
    4056           6 :             cache.missing--; mael(cache.basis, i, i) = 1;
    4057         366 :             for (j = i+1; j <= F.KC; j++) mael(cache.basis, j, i) = 0;
    4058             :           }
    4059             :       }
    4060      104003 :       zc = (lg(C)-1) - (lg(B)-1) - (lg(W)-1);
    4061      104003 :       if (RU-1-zc > 0) need = minss(need + RU-1-zc, F.KC); /* for units */
    4062      104003 :       if (need)
    4063             :       { /* dependent rows */
    4064         689 :         F.L_jid = vecslice(F.perm, 1, need);
    4065         689 :         vecsmall_sort(F.L_jid);
    4066         689 :         if (need != old_need) { nreldep = 0; old_need = need; }
    4067             :       }
    4068             :       else
    4069             :       { /* If the relation lattice is too small, check will be > 1 and we will
    4070             :          * do a new run of small_norm/rnd_rel asking for 1 relation. This often
    4071             :          * gives a relation involving L_jid[1]. We rotate the first element of
    4072             :          * L_jid in order to increase the probability of finding relations that
    4073             :          * increases the lattice. */
    4074      103314 :         long j, n = lg(W) - 1;
    4075      103314 :         if (n > 1 && squash_index % n)
    4076             :         {
    4077        7750 :           F.L_jid = leafcopy(F.perm);
    4078       31333 :           for (j = 1; j <= n; j++)
    4079       23583 :             F.L_jid[j] = F.perm[1 + (j + squash_index - 1) % n];
    4080             :         }
    4081             :         else
    4082       95564 :           F.L_jid = F.perm;
    4083      103314 :         squash_index++;
    4084             :       }
    4085             :     }
    4086      104003 :     while (need);
    4087             : 
    4088      103314 :     if (!A)
    4089             :     {
    4090       54773 :       small_fail = old_need = 0;
    4091       54773 :       fail_limit = maxss(F.KC / FAIL_DIVISOR, MINFAIL);
    4092             :     }
    4093      103314 :     A = vecslice(C, 1, zc); /* cols corresponding to units */
    4094      103314 :     if (flag) A = rowslice(A, 1, RU);
    4095      103314 :     Ar = real_i(A);
    4096      103314 :     R = compute_multiple_of_R(Ar, RU, N, &need, &bit, &lambda);
    4097      103314 :     if (need < old_need) small_fail = 0;
    4098             : #if 0 /* A good idea if we are indeed stuck but needs tuning */
    4099             :     /* we have computed way more relations than should be necessary */
    4100             :     if (TRIES < 3 && LIMC < LIMCMAX / 8 &&
    4101             :                      cache.last - cache.base > 10 * F.KC) goto START;
    4102             : #endif
    4103      103314 :     old_need = need;
    4104      103314 :     if (!lambda)
    4105          10 :     { precpb = "bestappr"; PREC = myprecdbl(PREC, flag? C: NULL); continue; }
    4106      103304 :     if (!R)
    4107             :     { /* not full rank for units */
    4108       21002 :       if (!need)
    4109           0 :       { precpb = "regulator"; PREC = myprecdbl(PREC, flag? C: NULL); }
    4110       21002 :       continue;
    4111             :     }
    4112       82302 :     if (cache.last==old_cache) { need=1; continue; }
    4113       82233 :     old_cache = cache.last;
    4114       82233 :     h = ZM_det_triangular(W);
    4115       82233 :     if (DEBUGLEVEL) err_printf("\n#### Tentative class number: %Ps\n", h);
    4116       82233 :     i = compute_R(lambda, mulir(h,invhr), &L, &R);
    4117       82233 :     if (DEBUGLEVEL)
    4118             :     {
    4119           0 :       err_printf("\n");
    4120           0 :       timer_printf(&T, "computing regulator and check");
    4121             :     }
    4122       82233 :     switch(i)
    4123             :     {
    4124       27472 :       case fupb_RELAT:
    4125       27472 :         need = 1; /* not enough relations */
    4126       27472 :         continue;
    4127          53 :       case fupb_PRECI: /* prec problem unless we cheat on Bach constant */
    4128          53 :         if ((precdouble&7) == 7 && LIMC <= LIMCMAX/2) goto START;
    4129          53 :         precpb = "compute_R"; PREC = myprecdbl(PREC, flag? C: NULL);
    4130          53 :         continue;
    4131             :     }
    4132             :     /* DONE */
    4133             : 
    4134       54708 :     if (F.KCZ2 > F.KCZ)
    4135             :     {
    4136           6 :       if (F.sfb_chg && !subFB_change(&F)) goto START;
    4137           6 :       if (!be_honest(&F, nf, auts, fact)) goto START;
    4138           6 :       if (DEBUGLEVEL) timer_printf(&T, "to be honest");
    4139             :     }
    4140       54708 :     F.KCZ2 = 0; /* be honest only once */
    4141             : 
    4142             :     /* fundamental units */
    4143             :     {
    4144       54708 :       GEN AU, CU, U, v = extract_full_lattice(L); /* L may be large */
    4145       54708 :       CU = NULL;
    4146       54708 :       if (v) { A = vecpermute(A, v); L = vecpermute(L, v); }
    4147             :       /* arch. components of fund. units */
    4148       54708 :       U = ZM_lll(L, 0.99, LLL_IM);
    4149       54708 :       U = ZM_mul(U, lll(RgM_ZM_mul(real_i(A), U)));
    4150       54708 :       if (DEBUGLEVEL) timer_printf(&T, "units LLL");
    4151       54708 :       AU = RgM_ZM_mul(A, U);
    4152       54708 :       A = cleanarchunit(AU, N, NULL, PREC);
    4153       54708 :       if (RU > 1 /* if there are fund units, test we have correct regulator */
    4154       41646 :           && (!A || lg(A) < RU || expo(subrr(get_regulator(A), R)) > -1))
    4155           6 :       {
    4156           6 :         long add = nbits2extraprec( gexpo(AU) + 64 ) - gprecision(AU);
    4157           6 :         long t = maxss(PREC * 0.15, add);
    4158           6 :         if (!A && DEBUGLEVEL) err_printf("### Incorrect units lognorm");
    4159           6 :         precpb = "cleanarch"; PREC += maxss(t, EXTRAPREC64); continue;
    4160             :       }
    4161       54702 :       if (flag)
    4162             :       {
    4163       53334 :         long l = lgcols(C) - RU;
    4164             :         REL_t *rel;
    4165       53334 :         SUnits = cgetg(l, t_COL);
    4166      858510 :         for (rel = cache.base+1, i = 1; i < l; i++,rel++)
    4167      805176 :           set_rel_alpha(rel, auts, SUnits, i);
    4168       53334 :         if (RU > 1)
    4169             :         {
    4170       40722 :           GEN c = v? vecpermute(C,v): vecslice(C,1,zc);
    4171       40722 :           CU = ZM_mul(rowslice(c, RU+1, nbrows(c)), U);
    4172             :         }
    4173             :       }
    4174       54702 :       if (DEBUGLEVEL) err_printf("\n#### Computing fundamental units\n");
    4175       54702 :       fu = getfu(nf, &A, CU? &U: NULL, PREC);
    4176       54702 :       CU = CU? ZM_mul(CU, U): cgetg(1, t_MAT);
    4177       54702 :       if (DEBUGLEVEL) timer_printf(&T, "getfu");
    4178       54702 :       Ce = vecslice(C, zc+1, lg(C)-1);
    4179       54702 :       if (flag) SUnits = mkvec4(SUnits, CU, rowslice(Ce, RU+1, nbrows(Ce)),
    4180             :                                 utoipos(LIMC));
    4181             :     }
    4182             :     /* class group generators */
    4183       54702 :     if (flag) Ce = rowslice(Ce, 1, RU);
    4184       54702 :     C0 = Ce; Ce = cleanarch(Ce, N, NULL, PREC);
    4185       54702 :     if (!Ce) {
    4186           0 :       long add = nbits2extraprec( gexpo(C0) + 64 ) - gprecision(C0);
    4187           0 :       precpb = "cleanarch"; PREC += maxss(add, 1);
    4188             :     }
    4189       54702 :     if (DEBUGLEVEL) timer_printf(&T, "cleanarch");
    4190      103314 :   } while (need || precpb);
    4191             : 
    4192       54702 :   Vbase = vecpermute(F.LP, F.perm);
    4193       54702 :   if (!fu) fu = cgetg(1, t_MAT);
    4194       54702 :   if (!SUnits) SUnits = gen_1;
    4195       54702 :   clg1 = class_group_gen(nf,W,Ce,Vbase,PREC, &clg2);
    4196       54702 :   res = mkvec5(clg1, R, SUnits, zu, fu);
    4197       54702 :   res = buchall_end(nf,res,clg2,W,B,A,Ce,Vbase);
    4198       54702 :   delete_FB(&F);
    4199       54702 :   res = gerepilecopy(av0, res);
    4200       54702 :   if (flag) obj_insert_shallow(res, MATAL, cgetg(1,t_VEC));
    4201       54702 :   if (nfisclone) gunclone(nf);
    4202       54702 :   delete_cache(&cache);
    4203       54702 :   free_GRHcheck(&GRHcheck);
    4204       54702 :   return res;
    4205             : }

Generated by: LCOV version 1.16